mirror of https://github.com/OISF/suricata
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
db36f39632
SCFTPFreeResponseLine gated the release of the code buffer on a null test of the response pointer, so the code buffer had no check of its own. Neither check could fire: parse_response_line sets both pointers from Box::into_raw on a boxed slice, which never returns null, and C code obtains an FTPResponseLine only from SCFTPParseResponseLine. The comment on the code field claimed the pointer may be null; a line with no status code gets an empty buffer with code_length 0 instead. Remove both null checks, note why they are unnecessary, and correct the field comment. Ticket: 8803 |
1 week ago | |
|---|---|---|
| .. | ||
| applayertemplate | 5 months ago | |
| asn1 | 5 months ago | |
| bittorrent_dht | 5 months ago | |
| dcerpc | 3 months ago | |
| detect | 1 week ago | |
| dhcp | 2 months ago | |
| dnp3 | 3 weeks ago | |
| dns | 3 weeks ago | |
| enip | 3 weeks ago | |
| ffi | 5 months ago | |
| ftp | 1 week ago | |
| http2 | 3 weeks ago | |
| ike | 2 months ago | |
| krb | 3 weeks ago | |
| ldap | 3 weeks ago | |
| llmnr | 5 months ago | |
| mdns | 11 months ago | |
| mime | 4 months ago | |
| modbus | 3 months ago | |
| mqtt | 3 weeks ago | |
| nfs | 3 weeks ago | |
| ntp | 3 weeks ago | |
| pgsql | 1 month ago | |
| pop3 | 9 months ago | |
| quic | 5 months ago | |
| rdp | 2 months ago | |
| rfb | 3 weeks ago | |
| sctp | 3 weeks ago | |
| sdp | 4 months ago | |
| sip | 4 months ago | |
| smb | 3 weeks ago | |
| snmp | 3 weeks ago | |
| ssh | 3 weeks ago | |
| telnet | 5 months ago | |
| tftp | 5 months ago | |
| utils | 5 months ago | |
| websocket | 3 weeks ago | |
| x509 | 2 months ago | |
| applayer.rs | 4 months ago | |
| common.rs | 4 months ago | |
| conf.rs | 4 months ago | |
| core.rs | 4 months ago | |
| debug.rs | 4 months ago | |
| encryption.rs | 4 months ago | |
| feature.rs | 4 months ago | |
| filecontainer.rs | 11 months ago | |
| filetracker.rs | 1 month ago | |
| flow.rs | 9 months ago | |
| frames.rs | 4 months ago | |
| handshake.rs | 4 months ago | |
| ja4.rs | 1 year ago | |
| jsonbuilder.rs | 2 months ago | |
| kerberos.rs | 4 months ago | |
| lib.rs | 2 months ago | |
| lua.rs | 4 months ago | |
| lzma.rs | 2 months ago | |
| tls_version.rs | 1 year ago | |
| util.rs | 4 months ago | |