mirror of https://github.com/OISF/suricata
cybersecurityidsintrusion-detection-systemintrusion-prevention-systemipsnetwork-monitornetwork-monitoringnsmsecuritysuricatathreat-hunting
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
I see two problems: 1) If allocating a newlist fails, the function returns NULL, which then leaks any existing list elements. 2) The code to add the new value to the list works for the first two, but for not the third. For example, replist=A, A->next=B, B->next=NULL, then adding C results in replist=A, A->next=C, C->next=NULL, B is lost. The fix pushes new values onto the head of the list, which might not be what is needed, but there are no comments on what the function does, so I made an assumption. |
10 years ago | |
---|---|---|
benches | ||
contrib | 12 years ago | |
doc | 11 years ago | |
lua | 11 years ago | |
m4 | ||
qa | 11 years ago | |
rules | 10 years ago | |
scripts | 10 years ago | |
src | 10 years ago | |
.gitignore | 12 years ago | |
.travis.yml | 11 years ago | |
COPYING | ||
ChangeLog | 11 years ago | |
LICENSE | ||
Makefile.am | 11 years ago | |
Makefile.cvs | ||
acsite.m4 | ||
autogen.sh | 13 years ago | |
classification.config | ||
config.rpath | 12 years ago | |
configure.ac | 11 years ago | |
doxygen.cfg | 11 years ago | |
reference.config | 11 years ago | |
suricata.yaml.in | 11 years ago | |
threshold.config | 13 years ago |