b06c134b5d
CopyCommandLine allocated a buffer for the whole request line, stripped the trailing whitespace and returned the shorter length. That shorter length is what the caller stores in tx->request_length and what FTPTransactionFree later hands to FTPFree, so one byte for every stripped whitespace character is never subtracted from ftp_memuse. The memory itself is released -- SCFree ignores the size it is given -- but the counter keeps climbing for the life of the process, and a client that pads its commands with spaces can push it up with every command it sends. Once the counter reaches app-layer.protocols.ftp.memcap, FTPCheckMemcap refuses any allocation that would cross it, and request buffers are the first to be refused: the transaction is still created, but tx->request stays NULL, so command_data is missing from the log and rules that inspect it stop matching. Whether a new flow can still allocate its state depends on how much room is left below the cap. With no memcap configured, the symptom is an ftp.memuse counter that is permanently wrong. Strip the whitespace before allocating, so the size accounted for is the size returned to the caller: - CopyCommandLine shortens line->len first, then allocates and copies that length. - A line that is nothing but whitespace returns without allocating. It used to get a buffer that was stored on the transaction and freed with a length of zero, leaving the whole allocation on the counter. - When the allocation fails, line->len has already been shortened, so port_line, the transfer file name and the too-long-line check see the same length there that they see when it succeeds. - FTPParserTest13 covers the accounting and the stored request; FTPParserTest14 covers the line the parser uses afterwards. Issue: 8848 |
2 months ago | |
|---|---|---|
| .clusterfuzzlite | 1 year ago | |
| .github | 2 months ago | |
| benches | ||
| doc | 2 months ago | |
| ebpf | 10 months ago | |
| etc | 3 months ago | |
| examples | 2 months ago | |
| git-templates | ||
| lua | 1 year ago | |
| plugins | 2 months ago | |
| python | 12 months ago | |
| qa | 5 months ago | |
| rules | 2 months ago | |
| rust | 2 months ago | |
| scripts | 2 months ago | |
| src | 2 months ago | |
| suricata-update | ||
| .clang-format | ||
| .gitignore | 1 year ago | |
| .readthedocs.yaml | 4 months ago | |
| COPYING | ||
| ChangeLog | 1 year ago | |
| LICENSE | ||
| Makefile.am | 2 months ago | |
| README.md | 1 year ago | |
| SECURITY.md | 6 months ago | |
| acsite.m4 | ||
| autogen.sh | ||
| bundle.txt | 4 months ago | |
| config.rpath | ||
| configure.ac | 2 months ago | |
| doxygen.cfg | 2 years ago | |
| libsuricata-config.in | 2 years ago | |
| shell.nix | 1 year ago | |
| suricata.yaml.in | 2 months ago | |
| threshold.config | ||
README.md
Suricata
Introduction
Suricata is a network IDS, IPS and NSM engine developed by the OISF and the Suricata community.
Resources
Contributing
We're happily taking patches and other contributions. Please see our Contribution Process for how to get started.
Suricata is a complex piece of software dealing with mostly untrusted input. Mishandling this input will have serious consequences:
- in IPS mode a crash may knock a network offline
- in passive mode a compromise of the IDS may lead to loss of critical and confidential data
- missed detection may lead to undetected compromise of the network
In other words, we think the stakes are pretty high, especially since in many common cases the IDS/IPS will be directly reachable by an attacker.
For this reason, we have developed a QA process that is quite extensive. A consequence is that contributing to Suricata can be a somewhat lengthy process.
On a high level, the steps are:
- GitHub-CI based checks. This runs automatically when a pull request is made.
- Review by devs from the team and community
- QA runs from private QA setups. These are private due to the nature of the test traffic.
Overview of Suricata's QA steps
OISF team members are able to submit builds to our private QA setup. It will run a series of build tests and a regression suite to confirm no existing features break.
The final QA runs takes a few hours minimally, and generally runs overnight. It currently runs:
- extensive build tests on different OS', compilers, optimization levels, configure features
- static code analysis using cppcheck, scan-build
- runtime code analysis using valgrind, AddressSanitizer, LeakSanitizer
- regression tests for past bugs
- output validation of logging
- unix socket testing
- pcap based fuzz testing using ASAN and LSAN
- traffic replay based IDS and IPS tests
Next to these tests, based on the type of code change further tests can be run manually:
- traffic replay testing (multi-gigabit)
- large pcap collection processing (multi-terabytes)
- fuzz testing (might take multiple days or even weeks)
- pcap based performance testing
- live performance testing
- various other manual tests based on evaluation of the proposed changes
It's important to realize that almost all of the tests above are used as acceptance tests. If something fails, it's up to you to address this in your code.
One step of the QA is currently run post-merge. We submit builds to the Coverity Scan program. Due to limitations of this (free) service, we can submit once a day max. Of course it can happen that after the merge the community will find issues. For both cases we request you to help address the issues as they may come up.
FAQ
Q: Will you accept my PR?
A: That depends on a number of things, including the code quality. With new features it also depends on whether the team and/or the community think the feature is useful, how much it affects other code and features, the risk of performance regressions, etc.
Q: When will my PR be merged?
A: It depends, if it's a major feature or considered a high risk change, it will probably go into the next major version.
Q: Why was my PR closed?
A: As documented in the Suricata GitHub workflow, we expect a new pull request for every change.
Normally, the team (or community) will give feedback on a pull request after which it is expected to be replaced by an improved PR. So look at the comments. If you disagree with the comments we can still discuss them in the closed PR.
If the PR was closed without comments it's likely due to QA failure. If the GitHub-CI checks failed, the PR should be fixed right away. No need for a discussion about it, unless you believe the QA failure is incorrect.
Q: The compiler/code analyser/tool is wrong, what now?
A: To assist in the automation of the QA, we're not accepting warnings or errors to stay. In some cases this could mean that we add a suppression if the tool supports that (e.g. valgrind, DrMemory). Some warnings can be disabled. In some exceptional cases the only 'solution' is to refactor the code to work around a static code checker limitation false positive. While frustrating, we prefer this over leaving warnings in the output. Warnings tend to get ignored and then increase risk of hiding other warnings.
Q: I think your QA test is wrong
A: If you really think it is, we can discuss how to improve it. But don't come to this conclusion too quickly, more often it's the code that turns out to be wrong.
Q: Do you require signing of a contributor license agreement?
A: Yes, we do this to keep the ownership of Suricata in one hand: the Open Information Security Foundation. See http://suricata.io/about/open-source/ and http://suricata.io/about/contribution-agreement/