suricata

Commit Graph

Author	SHA1	Message	Date
Philippe Antoine	26bb18cfaa	http2: replace state todrop with a dedicated boolean Ticket: 8518	5 months ago
Philippe Antoine	8eed90ca9d	http2: global txs are unidirectional Ticket: 8518 Meaning they will now match only once per tx instead of twice: once for each direction	5 months ago
Philippe Antoine	daf68dc36f	http2: split progress per direction Ticket: 8518 Keywords that work for HTTP2 headers match now as soon as possible A push promise is now considered like a headers frame with regards to the progress (no dedicated "reserved" progress/state) http.protocol and http.stat_msg keywords are now registered at earliest progress, since these are synthetic like "HTTP/2" and not really seen on the wire. http.request_line and http.response_line match only on data, and not on headers, since we must wait the end of headers to be sure to have the full line http2.size_update now matches at headers progress as it should http2.frametype, http2.errorcode, http2.priority now match like http2.window, when the tx is complete from both sides, as a half-closed client may still send priority, rst_stream or window_update frames	5 months ago
Philippe Antoine	8217c51126	rust: format sdp files Ticket: 3836	5 months ago
Philippe Antoine	9d9d8df4cd	rust: format rdp files Ticket: 3836	5 months ago
Philippe Antoine	7352bae890	smb: avoid unsigned overflow debug assertion As we compute a padding, we can use wrapping_add as we only care about the low-weight bit anyways	5 months ago
Giuseppe Longo	8f205bb34f	llmnr: implement logger This adds an LLMNR protocol logger that reuses existing DNS functions, following the same approach as the mDNS logger: - No grouped logging - Rdata is logged in a field that is named after the rdata type - Types are logged in lower case - Flags are logged as an array Ticket #8366	5 months ago
Giuseppe Longo	13df0f7a06	llmnr: implement parser This adds a parser for LLMNR protocol over both UDP and TCP. The parser reuses the existing DNS functions since LLMNR shares the same wire format as DNS, but implements its own protocol-specific validation: - LLMNR-specific flag checks (C, TC, T bits) - Opcode validation (only standard query opcode 0 is valid) - An Event is set if Z-flag is set, since it's must be zero per RFC4795 LLMNR transactions inherit DNS behavior where each packet creates a new state with one transaction. Ticket #8366	5 months ago
Philippe Antoine	73193c7e6a	rust: format pgsql files Ticket: 3836	5 months ago
Philippe Antoine	3bfe6cf4b9	rust: format nfs files Ticket: 3836	5 months ago
Philippe Antoine	07112bc7ae	rust: format mqtt files Ticket: 3836	5 months ago
Philippe Antoine	844f2effa3	rust: format modbus files Ticket: 3836	5 months ago
Philippe Antoine	db019ebefe	rust: format ike files Ticket: 3836	5 months ago
Philippe Antoine	bcc1e6ae32	rust: format http2 files Ticket: 3836	5 months ago
Philippe Antoine	1070e733d8	rust: format websocket files Ticket: 3836	5 months ago
Philippe Antoine	89e5332d88	rust: format utils files Ticket: 3836	5 months ago
Philippe Antoine	edf29b0000	rust: format ssh files Ticket: 3836	5 months ago
Philippe Antoine	fe27a2159c	rust: format rfb files Ticket: 3836	5 months ago
Philippe Antoine	5cca346f16	rust: format quic files Ticket: 3836	5 months ago
Philippe Antoine	415360d9e8	rust: format ntp files Ticket: 3836	5 months ago
Philippe Antoine	fa864f9c2f	rust: format mime files Ticket: 3836	5 months ago
Philippe Antoine	2cfcaec1b0	rust: format ldap files Ticket: 3836	5 months ago
Philippe Antoine	64e7c671cc	rust: format ftp files Ticket: 3836	5 months ago
Philippe Antoine	f217e249cb	rust: format ffi files Ticket: 3836	5 months ago
Philippe Antoine	f7c14809f4	rust: format enip files Ticket: 3836	5 months ago
Philippe Antoine	e526eb8e2b	rust: format bittorrent_dht files Ticket: 3836	5 months ago
Philippe Antoine	f5ac0e201c	rust: format asn1 files Ticket: 3836	5 months ago
Philippe Antoine	1ced97bdbb	rust: format applayertemplate files Ticket: 3836	5 months ago
Philippe Antoine	b90adcc2bb	rust/ffi: move AppLayerTxData to ffi Ticket: 7666	5 months ago
Philippe Antoine	0773fba5fd	rust/ffi: move txdata flags to ffi Ticket: 7666	5 months ago
Philippe Antoine	2525ea2e37	rust/ffi: move direction to ffi Ticket: 7666	5 months ago
Philippe Antoine	5440e41314	rust/ffi: move debug validations macros to ffi Ticket: 7666	5 months ago
Philippe Antoine	bf64b52b95	http2: better compression against decompression bombs Ticket: 8513 Suricata decides at 2 levels if a http2 flow is doing a compression bomb. There is a direct computation when one chunk of TCP data is being parsed. In this case, do not take the ratio into account, just use the size of the decompressed data, so that if we get a big chunk of TCP data like 1 MiB, and a not so high ratio of 200, we do not trigger the debug assertion in util-file.c about 64MiB The other case stays unchanged : when accumulating over the lifetile of a flow with multiple txs, take into account the compression ratio, so that a flow of many txs, having a super high (brotli) compression ratio, ends up classified as a compression bomb. (For example, having 100 txs each turning a 100 byte input into a 700 KiB one)	5 months ago
Philippe Antoine	6d437956e2	detect/transforms: dotprefix can be chained Ticket: 8537 Otherwise, it may cause a use-after-free, in case of reallocated buffer and we used the buffer inspect which was freed.	5 months ago
Philippe Antoine	2b20a436e7	detect/transforms: decompress checks earlier if it is in-place Ticket: 8536 Otherwise, it may cause a use-after-free. So, need to allocate the temporary vector, before calling SCInspectionBufferCheckAndExpand	5 months ago
Philippe Antoine	7bf48b02be	http2: protection against decompression bombs Ticket: 8513 During decompression, fail early if we have a big decompression ratio, and enough data. Track this data also during a tx lifetime, and even a flow/state lifetime, so that we set event and fail also if the compression bomb is split over multiple packets	5 months ago
Philippe Antoine	29e4b08647	http2: code refactoring to split big function	5 months ago
Philippe Antoine	e98d419d96	ldap: bound the number of responses Ticket: 8405	5 months ago
Victor Julien	6ebd0c3cc2	http2: check for HTTP1 protocol during upgrade path Ticket: 8492	5 months ago
Philippe Antoine	10bde66586	nfs: bound file_additional_procs to 1 Ticket: 8418 As we only need to know we saw at least one NFSPROC3_COMMIT	5 months ago
Philippe Antoine	aea7ee21b8	nfs: bound namemap by using lru Ticket: 8418	5 months ago
Philippe Antoine	a50f494ef6	nfs: bound requestmap and use lru Ticket: 8418	5 months ago
Juliana Fajardini	d442c3544c	detect: opt-in keywords for firewall mode - tls.cert_chain_len - datarep - dataset - dns.opcode Part of Ticket #8387	5 months ago
Philippe Antoine	f0e246de34	detect/mqtt: reason_code keyword is now a multi-integer Ticket: 7929 Builds a vector of the reason code in a tx to do so, except if we use the default "any", where we do not append to the vector, but just run detection while iterating	6 months ago
Philippe Antoine	614c48d3c3	ikev2: remove unused field Ticket: 8415	6 months ago
Jeff Lucovsky	9ea2e29581	ftp: raise too_many_transactions event on overflow Other parsers (SMB, POP3, ENIP) already raise a too_many_transactions event when a flow exceeds its per-flow transaction limit. FTP had the limit wired up through app-layer.protocols.ftp.max-tx but just dropped the excess transaction on the floor with a "FTP does not set events yet..." TODO, so no event was raised when the limit was reached. Add the FtpEventTooManyTransactions variant, a stock rule at sid 2232002, and raise the event from FTPTransactionCreate when the live-tx count goes past ftp_config_maxtx. Issue: 8489	6 months ago
Philippe Antoine	e38888810d	detect/dcerpc: avoids FP on dcerpc.iface keyword When we got a bind without the first fragment flag, and did not set any_frag in the signature, the signature always matched, whatever the uuid value Ticket: 8457	6 months ago
Philippe Antoine	5ed394b26b	rust/ffi: move AppLayerEvent to ffi Ticket: 7666	6 months ago
Philippe Antoine	59b6de8239	rust: fix last collapsible_match warnings The ones where we need to remove a debug log	6 months ago
Philippe Antoine	1cdff9de8e	rust: fix collapsible_match warnings warning: this `if` can be collapsed into the outer `match` help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_match	6 months ago
Jason Ish	899e9f045e	ntp: expose logged fields to lua This includes: - version - mode - stratum - reference_id Ticket: #8533	6 months ago
Jason Ish	81692dd2c1	rust/lua: add method for pushing bytes Much like pushstring, but accepts an &[u8] as an argument instead of an &str. In support of ticket #8533.	6 months ago
Jason Ish	cdb02a2779	rust/dns: rustfmt	6 months ago
Philippe Antoine	7d66eb5f04	rust: remove unused function rust_string_to_c was used when a buffer should be used as it could contain nul-byte	6 months ago
Philippe Antoine	9b12fd9f09	rust/ffi: move helper trait state_get_tx_iterator to ffi Ticket: 7666	6 months ago
Philippe Antoine	07f37676b6	rust/ffi: move Flags for AppLayerParserState to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	fb20c69d8d	rust/ffi: move APP_LAYER_PARSER_OPT_X const to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	d81a10126e	detect/doc: remove unexisting links Ticket: 8257 And add TODO comments if rules doc should be written	6 months ago
Philippe Antoine	8e39539161	detect/doc: fix broken anchor links Ticket: 8257	6 months ago
Philippe Antoine	bd6a436893	detect/doc: fix broken files links Ticket: 8257	6 months ago
Philippe Antoine	b0e63a2c95	detect/dcerpc: move stub_data keyword to rust Ticket: 8391	6 months ago
Jeff Lucovsky	746f471382	transform/subslice: Add subslice transform Issue: 7672 The subslice transform creates a slice of the input buffer. Specify the subslice desired -- nbytes and truncate are optional: subslice: offset <,nbytes> <,truncate> offset: Specifies the starting offset for the new subslice. When negative, expresses how far from the end of the input buffer to begin. nbytes: Specifies the size of the subslice. When negative, specifies that the subslice will end that many bytes from the end of the input buffer. Nbytes must be non-zero. When nbytes is not specified, the size of the subslice will be the size of the input buffer - offset. truncate: Specify behavior when offset + nbytes exceeds buffer length. When present, trims nbytes such that offset + nbytes equals buffer length. When not present, an empty buffer is produced. Examples: subslice: 1; - The subslice will be a copy of the input buffer but omits the input buffer's first byte "This is Suricata" -> "his is Suricata" subslice: 0, 13; - The slice is created from the first 13 bytes of the input buffer "This is Suricata" -> "This is Suric" subslice: 10, -5; - The subslice is created starting at offset 10 and continues to 5 bytes before the end of the input buffer "This is Suricata" -> "r" subslice: -3; - The subslice will be the last 3 bytes of the input buffer. "This is Suricata" -> "ata"	6 months ago
Philippe Antoine	4fc6ca5d6c	detect/dcerpc: move iface keyword to rust Ticket: 8391 Use same buffer dce_generic as for dcerpc.opnum (name dce_generic is enforced by a SV test currently)	6 months ago
Philippe Antoine	9677851637	rust/ffi: move app-layer traits to ffi crate Ticket: 7666 Traits around structures defined in C and bindgened to rust	6 months ago
Philippe Antoine	f803c25f24	rust/ffi: move export_X_data_get macros to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	54b6885166	rust/ffi: move conf_get_bool helper to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	5f9e436c3f	detect/dcerpc: support generic integer for opnum keyword Ticket: 8179	6 months ago
Philippe Antoine	67379b009a	detect/dcerpc: move opnum keyword to rust Ticket: 8391	6 months ago
Jason Ish	fd31e50954	ntp: enable keywords for firewall mode Ticket: #8394	6 months ago
Jason Ish	713e4eb900	ntp: convert reference_id to buffer and add keyword Store the NTP reference ID as raw network-order bytes so it can be exposed as a sticky buffer and matched with payload keywords. The reference ID is often a 4 character string, or an IP address and not just an integer identifier. Updates the log reference ID to be a string of colon separated hex digits as this matches what tshark does. Ticket: #8488	6 months ago
Jason Ish	991e7f3b1d	ntp: add ntp.mode keyword This keyword also accepts strings for known mode names. Ticket: #8429	6 months ago
Jason Ish	c10c482290	ntp: add ntp.stratum keyword Ticket: #8431	6 months ago
Jason Ish	ec344fe68d	ntp: add ntp.version keyword SNMP was used as a template. Ticket: #8430	6 months ago
Jason Ish	74bb525401	ntp: create tx for all modes; log version, mode and stratum Add logging for version, mode and stratum as these will be the first keywords we will add. Ticket: #8425	6 months ago
Jason Ish	879846e153	ntp: remove unused event types NotRequest and NotResponse event type have never been used. Unsolicited is also unused, however there is a rule for it so removing support would be a breaking change at this time.	6 months ago
Jason Ish	31b967b089	ntp: add transaction logging Adds basic NTP transaction logging for the current supported message types. Includes small cleanups around reference ID. Ticket: #8425	6 months ago
Victor Julien	c7cd3b17c3	snmp: minor snmp.pdu_type type cleanup	6 months ago
Victor Julien	2cef1404bc	detect/snmp: let generic keyword share the same list	6 months ago
Victor Julien	670fdabd32	detect/snmp: add snmp.trap_type keyword Implemented as a U8 integer keyword. Ticket: #8482.	6 months ago
Philippe Antoine	8ac9a62ec4	detect: enable snmp keywords for firewall mode Ticket: #8395	6 months ago
Philippe Antoine	63603fe14a	detect/snmp: sticky buffers at progress 1 Since snmp txs are created at progress 1 which is the completion, this does not change detection, except allowing firewall mode to use these keywords with generic hook like snmp:request_complete Ticket: 8395	6 months ago
Philippe Antoine	8f824458c2	detect: helper for buffer register requires progress Ticket: 8395 For protocols where tx are complete at start, that is the `tx_get_progress` function returns 1 inconditionnally, we can use the progress 1, not losing time on detection in ips mode, and getting ready for firewall mode For the other protocols (where a tx needs both a request and response for instance), keep progress 0 as was the case before	6 months ago
Philippe Antoine	58a71d94b0	rust/ffi: move conf_get helper to ffi crate Ticket: 7666	7 months ago
Philippe Antoine	8d254f5630	dhcp/output: log app-layer metadata in alerts Ticket: 6091 log as extended	7 months ago
Philippe Antoine	db980daf5f	dhcp: standardize output code To prepare to add metadata in alerts Ticket: 6091	7 months ago
Philippe Antoine	d14af54b3b	detect/transforms: constify some callbacks arguments Ticket: 8298	7 months ago
Philippe Antoine	0a24f0afe2	smb: parse smb1 session setup with word count 13 Ticket: 5845	7 months ago
Philippe Antoine	c53b9df5a2	rust/ffi: move detection helpers to ffi crate Ticket: 7666	7 months ago
Philippe Antoine	4f4912c042	rust: bindgen SIGMATCH_ constants	7 months ago
Philippe Antoine	2fa10052cf	websocket: check pdu opcode for reassembly Ticket: 8413 RFC 6455 Section 5.4 states Control frames (see Section 5.5) MAY be injected in the middle of a fragmented message. Control frames are identified by opcodes where the most significant bit of the opcode is 1.	7 months ago
Philippe Antoine	7b0528d85f	http2: set response_frame_size Ticket: 8410 Do not set only request_frame_size whatever the direction	7 months ago
Philippe Antoine	267c3baff7	rust/ffi: move STREAM_ constants to ffi crate Ticket: 7666 reexport them in suricata crate cbindgen them to C	7 months ago
Philippe Antoine	34ed8958a6	dcerpc: only log the tx interfaces Not all the state ones Ticket: 8378	7 months ago
Philippe Antoine	05a11e2897	dcerpc: store persistently contexts So that we can log and detect on interface uuids, even if AlterContext packets change one of the contexts, but other contexts are still used after it in request/responses Ticket: 8378	7 months ago
Jeff Lucovsky	14ebba6382	gen/unused: Remove unused function Remove unused function is_alphanumeric_or_slash	7 months ago
Jeff Lucovsky	98070a7ace	misc/cleanup: remove rust if <cond> .... Cleanup the few instances of rust where if cond return true else false exist rg = ripgrep rg -n -U '^\sif . \{\s\n\sreturn true;\s\n\s\}\s\n\sreturn false;' rust/src/ --glob '.rs' rg -n -U '^\sif .* \{\s\n\sreturn false;\s\n\s\}\s\n\sreturn true;' rust/src/ --glob '*.rs'	7 months ago
Philippe Antoine	6587e363a3	dcerpc: use bind context_id in SMB Ticket: 8375 logger already read this variable but it was never set, and the rust compiler did not warn about this Allows to log the interface uuid when ctx_id > 0 Wireshark filter for related pcaps dcerpc.cn_ctx_id > 0 && dcerpc.pkt_type == 0	7 months ago
Philippe Antoine	2c2a3c800f	dcerpc: support multiple PDU in one parser call Ticket: 7254 With TCP, we receive a stream of data, which may contain multiple PDUs in one call	7 months ago
Philippe Antoine	db51314478	rust: rustfmt dcerpc.rs	7 months ago
Philippe Antoine	55ad2953bf	dcerpc: do not error the whole flow on unhandled packet type Ticket: 5133	7 months ago
Philippe Antoine	76d2925bdf	ldap: abandon request does not wait for a response Ticket: 8356 As such, abandon request is a complete tx	8 months ago
Philippe Antoine	784e173278	http2: bound number of http2 frames per tx Ticket: 8289 If stream.reassembly.depth is unlimited, an attacker controlling the 2 sides of a communication going through Suricata can send a transition with an infinite number of headers, until suricata OOMs Solution is to offer a configuration option to bound the number of HTTP2 frames we store in a HTTP2 transaction, and produce an anomaly if this bound is crossed	8 months ago
Philippe Antoine	49fd7001ff	smtp/mime: fix urls finding in buffering case We used to look for a full line, but as we look fot the last eol we need to use the right index in the not-reversed list	8 months ago
Philippe Antoine	8bba47aa09	smtp/mime: avoid quadratic complexity in mime_smtp_find_url_strings Ticket: 8292 When we have buffered something in ctx.decoded_line, we already looked for '\n' in it, so we do not need to run it again Otherwise, callers that supply mime_smtp_find_url_strings with a few bytes at a time without "\n", have a quadratic complexity	8 months ago
Philippe Antoine	062f56ddde	detect/http2: use ThreadCtx for all headers keywords Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	4e538dfa3b	detect/http2: use ThreadCtx for http.request_header And also for http.response_header Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	0933e944df	detect/http2: use ThreadCtx for http.header.raw Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	711de8a5ea	detect/http2: use ThreadCtx for http.header Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	52a2f2dd19	detect/http2: use ThreadCtx for http.header_names Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	8e886a8ecd	krb5: use app-layer incomplete support Ticket: 3540 Ticket: 8305	8 months ago
Philippe Antoine	d77c43c79b	rust/ffi: move build_slice macro to ffi crate Ticket: 7666	8 months ago
Philippe Antoine	4a0143c8d4	rust/ffi: move cast_pointer macro to ffi crate Ticket: 7666	8 months ago
Shivani Bhardwaj	d241237c0f	Revert "dcerpc: fix consumed bytes post gap handling" This reverts commit `fc9da1c7a1`. That commit incorrectly used consumed as index of the slice passed to the Frame API. Found by oss-fuzz.	8 months ago
Jeff Lucovsky	ed882ede68	output/ipv6: Utility function to compress IPv6 addrs Issue: 7399 Utility function to compress IPv6 addresses per RFC-5952	8 months ago
Giuseppe Longo	de46f4ba9d	ldap: set invalid_data event Currently in parse_request function LdapEvent::InvalidData is not set when a request is not parsed correctly. Ticket #8258	8 months ago
Victor Julien	b55be5a44f	detect/transforms: update gunzip / zlib_deflate syntax Use standard space separated syntax.	8 months ago
Philippe Antoine	71b59f6dbe	rust/ffi: move IPPROTO_TCP to ffi and reexport in suricata Allows to reduce dependencies to full suricata crate Ticket: 7666	8 months ago
Philippe Antoine	d5ea973791	detect/ike: move ike.ike.chosen_sa_attribute keyword to rust Ticket: 8310 And increases expressivity on the way by supporting other modes than equality	8 months ago
Philippe Antoine	55333a6ca0	detect/ike: move ike.vendor keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	14edd66494	detect/ike: move ike.nonce_payload keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	d1213e4440	detect/ike: move ike.key_exchange_payload keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	f23169c924	detect/ike: move ike.nonce_payload_length keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	e85bf5be4d	detect/ike: move ike.key_exchange_payload_length keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	841fe44f34	detect/ike: move ike.exchtype keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	23032ebc65	detect/ike: move ike spi keywords to rust Ticket: 8310	8 months ago
Philippe Antoine	539e4ee665	detect/transforms: add zlib_deflate transform Ticket: 7846	8 months ago
Philippe Antoine	dbea660729	detect/transforms: add gunzip transform Ticket: 7846	8 months ago
Victor Julien	336a9d05ca	krb5: fix TCP record parsing A logic error in multi-record parsing meant only the first record was parsed. Bug: #8278.	8 months ago
Jason Ish	f951477461	rust/debug: use functions from ffi crate where possible It's not possible to use all the functions and macros from the ffi crate in the main Suricata crate, as there are conditionals around when running in test mode, and "cargo test" doesn't propagate the "cfg(test)" to test crates. Which for now means duplicating the macros and some functions.	9 months ago
Philippe Antoine	536242341b	detect/smb: move smb.version keyword to rust Ticket: 8267	9 months ago
Philippe Antoine	697c641400	detect/smb: move smb share and named_pipe keywords to rust Ticket: 8267	9 months ago
Philippe Antoine	667f8b2eb7	detect/smb: move smb ntlmssp keywords to rust Ticket: 8267	9 months ago
Victor Julien	a2e9ac21f8	flow: turn flags field into uint64_t Entire space is used.	9 months ago
Jason Ish	b0c912588c	mqtt/detect: fix mqtt_parse_bool return type Previously we were boxing a u8 and returning it as a pointer to a boolean. While this is probably not an issue itself, the value 2 was allowed to be converted to a boolean, which is undefined behavior in Rust.	9 months ago
Jason Ish	b9e0f9cc8b	rfb/detect: fix rfb_parse_sec_result return type The data parsed is a u32, but returned as DetectUintData<u8>, then later free'd as a DetectUintData<u32>.	9 months ago
Jason Ish	8b2a7ac47c	nfs/detect: fix nfs_procedure_parse return type Was returning DetectNfsProcedureData as a pointer to DetectUintData<u32>, and free'ing it as such.	9 months ago
Jason Ish	e474e45429	dns/detect: fix rcode return type The parsed DNS rcode was being returned as a DetectUintData<u8>, but is parsed, and free'd as a u16. So return a DetectUintData<u16>.	9 months ago
Philippe Antoine	364d2c077d	rust: bindgen SCAppLayerRegisterParser Ticket: 7662	9 months ago
Philippe Antoine	8857b78f6a	rust: move AppLayerTxData definition to C and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerTxData Move also the free function to C SCAppLayerTxDataCleanup As suricata-sys crate defines AppLayerTxData for rust, It must itself implement the Drop trait, and thus, We need to define a feature surest	9 months ago
Philippe Antoine	8eaced3c1e	rust: move AppLayerResult definition to C and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerResult Keep From<> impl in sys crate that defines it	9 months ago
Philippe Antoine	06f78b2a22	rust: move StreamSlice definition to C and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses StreamSlice	9 months ago
Philippe Antoine	41f543ca35	rust: move AppLayerGetTxIterTuple definition to C and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerGetTxIterTuple	9 months ago
Philippe Antoine	64d29fcd1c	rust: move AppLayerStateData definition to C and bindgen it to rust, and use default trait instead of new Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerStateData	9 months ago
Philippe Antoine	76efb8af4d	rust: move AppLayerGetFileState definition to C and bindgen it to rust. Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerGetFileState	9 months ago
Shivani Bhardwaj	d4008a6508	dcerpc: remove bad tests Unittests test_parse_bind_pdu_infinite_loop and test_parse_bindack_pdu_infinite_loop seem to have artificially made up header which does not hold up to the strict calculations enforced by the parser now. Their headers mark the fraglens as 64 and 72 respectively which are not enough to hold the kind of bind(ack) items that are expected. It worked so far as the parser passed the entire input slice around but with the bugfix for issue 7546, the input passed around is strictly restricted to the fraglen parsed in the header. Bug 7546	9 months ago
Shivani Bhardwaj	ed1bd8624e	dcerpc: use fraglen from header So far, the fraglen defined in the header was used inconsistently in certain places to define bounds on input length. Make it consistent by making sure that only a slice up until fraglen is passed around as that is the maximum length the fragment should have. With the help of Applayer::incomplete API, the case when the stream_slice passed to the parser is smaller than the header defined fraglen is already handled. Bug 7546	9 months ago
Shivani Bhardwaj	fc9da1c7a1	dcerpc: fix consumed bytes post gap handling The parser could receive an input that consists of arbitrary data post gap. This is handled in the beginning of the fn handle_input_data. However, the rest of the calculation does not take into account the bytes that were consumed at this stage. Fix the indices and calculations to consider a new DCERPC fragment beginning post these consumed bytes.	9 months ago
Philippe Antoine	9a52bbcbe9	detect/quic: move quic.cyu.hash to rust Ticket: 8255	9 months ago
Philippe Antoine	01610aabe7	detect/quic: move quic.cyu.string to rust Ticket: 8255	9 months ago
Philippe Antoine	ee4d4a14d5	detect/quic: move quic.ua to rust Ticket: 8255	9 months ago
Philippe Antoine	9ba9fdcb87	detect/quic: move quic.sni to rust Ticket: 8255	9 months ago
Philippe Antoine	907e71a984	detect/quic: move quic.version to rust Ticket: 8255	9 months ago
Philippe Antoine	2cf9a327d5	detect/ssh: move ssh.hassh to rust Introduces helper SCDetectRegisterBufferLowerMd5Callbacks	9 months ago
Philippe Antoine	83360cfce0	detect/ssh: move ssh.hassh string to rust bindgen needed SCSigMatchSilentErrorEnabled on the way	9 months ago
Philippe Antoine	02cb0f2ac2	rust: fix unnecessary_unwrap warnings warning: called `unwrap` on `rd.pipe` after checking its variant with `is_some` --> src/smb/smb1.rs:858:28 \| 857 \| if rd.pipe.is_some() { \| -------------------- help: try: `if let Some(<item>) = rd.pipe` 858 \| let pipe = rd.pipe.unwrap(); \| ^^^^^^^^^^^^^^^^ \| = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_unwrap = note: `#[warn(clippy::unnecessary_unwrap)]` on by default	9 months ago
Philippe Antoine	cafc398355	dcerpc: consume bytes after gap resync Ticket: 7567 Re-applies commit `8c3bd3e8a0` which was reverted in `f64aec9d11`	9 months ago
Philippe Antoine	54cc752cf9	ssh: hassh can be truly disabled Rules will not re-enable it Ticket: 8223	9 months ago
Philippe Antoine	458211dcf2	detect/ssh: move ssh.proto to rust	9 months ago
Philippe Antoine	9cfc1cc557	detect/ssh: move obsolete keywords to rust	9 months ago
Philippe Antoine	ea8ac2a02a	detect/ssh: move ssh.software to rust Adds helper function SCDetectHelperBufferProgressMpmRegister on the way	9 months ago
Philippe Antoine	c0d6747e82	app-layer: GetTxIteratorFn uses a AppLayerGetTxIterState Even if every current rust parser uses the u64 variant of the C union	9 months ago
Philippe Antoine	4b541b39f2	rust: move AppLayerEventType definition to C and bindgen it to rust. Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerEventType	9 months ago
Philippe Antoine	c960b7d7c1	app-layer: AppLayerParserFPtr uses a mut pointer to local storage So, fix the fn prototype in rust ParseFn	9 months ago
Philippe Antoine	f470ee448b	quic: use standard tx iterator code Will make bindgen life easier As the fn prototype should not have istate: &mut u64 but a *mut AppLayerGetTxIterState which is an union with a u64	9 months ago
Philippe Antoine	076fcd61cd	bittorrent: use standard tx iterator code Will make bindgen life easier As the fn prototype should not have istate: &mut u64 but a *mut AppLayerGetTxIterState which is an union with a u64	9 months ago
Philippe Antoine	1a546936c7	rust: AppLayerTxConfig uses Default impl	9 months ago
Philippe Antoine	4e64de3b3b	rust: remove wrapper LoggerFlags struct definition just use an u32 out of the box. Will make bindgen like easier	9 months ago
Philippe Antoine	f663be5983	rust: define every RustParser fn pointer unsafe That is what bindgen will do	9 months ago
Lukas Sismis	3e4fdb2118	misc: time unit parsing function	9 months ago
Philippe Antoine	5bb9a0c3af	dcerpc/tcp: fix fragmentation handling Really count the fragments, and set it done when last was received	10 months ago
Philippe Antoine	f64aec9d11	dcerpc: use different header for different directions Header handling is wrong in the case packet A to server is fragmented (return AppLayerResult::incomplete) packet B is to client, but uses the header of the to_server packet Bug 7547	10 months ago
Philippe Antoine	1832b50506	nfs: log read/write/rename whatever the nfs version These were previously logged correctly only for nfs v3 Now, the correct opcodes are used for v2 and v4 as well Ticket: 8222	10 months ago
Philippe Antoine	b0850efd67	rust: from_str implementation for EncryptionHandling To move non-specific quic code to the right place	10 months ago
Philippe Antoine	89b6ab6730	rust: rename EncryptionHandling as it is no longer specific to SSH	10 months ago
Philippe Antoine	7acfea57a9	rust: move EncryptionHandling definition to its own file as it is not specific to ssh anymore	10 months ago
Philippe Antoine	7422c97bf2	quic: encryption-handling config parameters Ticket: 8116	10 months ago
Philippe Antoine	a48200b9e5	dcerpc: use saturating_add to count fragments And do not overflow if we have traffic with more than 65K fragments	10 months ago
Shivani Bhardwaj	e412215af9	dcerpc: add upper limit on stub data DCERPC parsers had no upper bounds when it came to extending the stub data buffer. Traffic can be crafted to bypass some internal parser conditions to create an indefinite buffering in the stub_data array that can make Suricata crash. Add a default limit of 1MiB and make it configurable for the user. Security 8182 Co-authored-by: Philippe Antoine <pantoine@oisf.net>	10 months ago
Shivani Bhardwaj	1d7b0d9b7a	tls/subjectaltname: use byte arr instead of string TLS parsers use x509-parser crate which parses X.509 certificates that use ASN.1 DER encoding that can allow arbitrary byte sequences. An attacker could inject null byte in a certificate anywhere to stump the common language parsers terminating the string at a null byte leading to a bypass of a possibly malicious certificate. So far, the rust TLS parser for "subjectaltname" used a pattern that involved: -> Get ASN.1 DER encoded raw data from the x509-parser crate -> Convert this raw data to a decoded string (Rust) -> Convert the Rust string to CString -- The problem lies here. CString only accepts proper strings/byte buffers and converts it into an owned C-compatible, null-terminated string. However, if any null byte occurs in the string passed to the CString then it panics. In the rust TLS parser, this panic is handled by returning NULL. This means that the parser will error out during the decoding of the certificate. However, Suricata must be able to detect the null byte injection attack being an IDS/IPS. Hence, replace all such string patterns w.r.t. TLS SAN with a byte array. Bug 7887	10 months ago
Shivani Bhardwaj	24f5b7dab2	tls/serial: use byte array instead of string Bug 7887	10 months ago
Shivani Bhardwaj	f025e07191	tls/issuerdn: use byte array instead of string TLS parsers use x509-parser crate which parses X.509 certificates that use ASN.1 DER encoding that can allow arbitrary byte sequences. An attacker could inject null byte in a certificate anywhere to stump the common language parsers terminating the string at a null byte leading to a bypass of a possibly malicious certificate. So far, the rust TLS parser for "issuerdn" used a pattern that involved: -> Get ASN.1 DER encoded raw data from the x509-parser crate -> Convert this raw data to a decoded string (Rust) -> Convert the Rust string to CString -- The problem lies here. CString only accepts proper strings/byte buffers and converts it into an owned C-compatible, null-terminated string. However, if any null byte occurs in the string passed to the CString then it panics. In the rust TLS parser, this panic is handled by returning NULL. This means that the parser will error out during the decoding of the certificate. However, Suricata must be able to detect the null byte injection attack being an IDS/IPS. Hence, replace all such string patterns w.r.t. TLS IssuerDN with a byte array. Bug 7887	10 months ago
Shivani Bhardwaj	77c21b05d2	tls/subject: use byte array instead of string TLS parsers use x509-parser crate which parses X.509 certificates that use ASN.1 DER encoding that can allow arbitrary byte sequences. An attacker could inject null byte in a certificate anywhere to stump the common language parsers terminating the string at a null byte leading to a bypass of a possibly malicious certificate. So far, the rust TLS parser for "Subject" used a pattern that involved: -> Get ASN.1 DER encoded raw data from the x509-parser crate -> Convert this raw data to a decoded string (Rust) -> Convert the Rust string to CString -- The problem lies here. CString only accepts proper strings/byte buffers and converts it into an owned C-compatible, null-terminated string. However, if any null byte occurs in the string passed to the CString then it panics. In the rust TLS parser, this panic is handled by returning NULL. This means that the parser will error out during the decoding of the certificate. However, Suricata must be able to detect the null byte injection attack being an IDS/IPS. Hence, replace all such string patterns w.r.t. TLS Subject with a byte array. Bug 7887	10 months ago
Shivani Bhardwaj	06eafb79d6	detect/flow-pkts: check for both dir The functionality of "both" can already be easily achieved by using both "toclient" and "toserver" in a rule. This just adds the ease of expression in rule. As it is added now, check the direction for the pre-existing users of direction as well.	10 months ago
Shivani Bhardwaj	77abcde9ee	rust/flow: add public wrapper for dir in order to be able to use it on the C side for elephant flow detection.	10 months ago
Jason Ish	50224f2ee5	rust: fix clippy warning for unused import While debug_validate_bug_on is still used, it does not need to be imported directly, as that macro is marked with `macro_export`, making it globally available to the crate.	11 months ago
Philippe Antoine	455b7d1b3b	rust: use snake case for applayer_register_protocol_detection	11 months ago
Philippe Antoine	b4d8aea0ae	rust: bindgen SCAppLayerRegisterProtocolDetection Ticket: 7662 Changing the struct passed to it to have the minimal number of useful fields.	11 months ago
Philippe Antoine	2349f19977	nfs: use nfsv2 procedure names with nfs_procedure keyword Ticket: 5140	11 months ago
Jhonny Sousa	257ed82dbd	nfs: Fix NFSv2 STATFS procedure parsing Ticket: #5140	11 months ago
Philippe Antoine	15b1bf4865	rust: bindgen SCHTPFileCloseHandleRange Ticket: 7762	11 months ago
Philippe Antoine	cddbd0b906	rust: bindgen more file functions Ticket: 7762	11 months ago
Victor Julien	80d5afe91b	pop3: AUTH command handling improvements Better track the state so it's known when to expect a base64 request message. Also better validate the base64. Ticket: #7994.	11 months ago
Victor Julien	2973eded56	pop3: convert to nom 8 Ticket: #8127.	11 months ago
Victor Julien	da2db65f62	pop3: rustfmt	11 months ago
Jason Ish	83d8b1d2f8	quic: update to nom 8.0 Ticket: #8140	11 months ago
Philippe Antoine	32ce3d29be	detect/krb: use flag u32 for krb5_msg_type	11 months ago
Jason Ish	ef9cd7beff	rust/smb: convert to nom 8 Ticket: #8089	12 months ago
Jason Ish	02045e1d62	rust/dcerpc: convert to nom 8 Ticket: #8093	12 months ago
Jason Ish	25c98af0e8	rust/detect: convert remaining detection rule parsers to nom 8 Ticket: #8051	12 months ago
Jason Ish	dea3f9e260	rust/detect: convert error.rs and dependent parsers to nom 8 Ticket: #8051	12 months ago

... 2 3 4 5 6 ...

2217 Commits (f57cacd3b39b4fac84100258884d4cd92f60f2d5)