Victor Julien
101452056d
detect/bytejump: don't reuse content flag
...
To avoid future problems with overlapping flag values, give bytejump
its own DETECT_BYTEJUMP_OFFSET_VAR flag.
The values are currently not overlapping, so this patch should have
no side effects.
3 years ago
Victor Julien
83c4de4cee
detect/bytejump: fix debug messages
...
Remove newlines.
3 years ago
Philippe Antoine
c272a646c5
detect: SigMatchAppendSMToList can fail
...
Ticket: #6104
And failures should be handled to say that the rule failed to load
Reverts the fix by 299ee6ed55
that was simple, but not complete (memory leak),
to have this bigger API change which simplifies code.
3 years ago
Daniel Olatunji
d4e4bdac90
detect/bytejump: convert unittests to FAIL/PASS
...
Issue: #6328
3 years ago
Jeff Lucovsky
f363b99fd7
detect/bytejump: Improve end-of-buffer handling
...
Issue: 4623
This commit addresses the issues reported in issue 4623 when the jump
value points at the last byte in the buffer.
3 years ago
Jeff Lucovsky
ffd769d178
detect/bytejump: Remove unused "Match" function
...
Issue: 4623
DetectBytejumpMatch is no longer used -- it's counterpart --
DetectByteJumpDoMatch is and will remain.
3 years ago
Jeff Lucovsky
2bf9d0fdf9
detect/bytejump: Improve negative post_offset handling.
...
Issue: 4624
Handle negative post_offset values that jump before the buffer as though
they refer to the buffer start.
3 years ago
Jeff Lucovsky
27a665546b
detect/bytejump: Change DoMatch signature to return bool
...
Issue: 4624
Change the function signature of byte-jump's domatch from an int to a
bool to avoid ambiguity handling return values.
3 years ago
Jeff Lucovsky
3286c3b912
detect/pcre: Use local match variables
...
pcre2 is not thread-safe wrt match objects so use locally scoped
objects.
Issue: 4797
3 years ago
Jeff Lucovsky
3f118188e9
detect/bytejump: Allow nbytes to be a variable
...
Issue: 6105
This commit adds the ability for nbytes to be a variable when used with
the byte_jump keyword.
3 years ago
Victor Julien
454d13837e
detect/byte_jump: use list util in tests; cleanups
3 years ago
Victor Julien
7ac623e0c5
detect/bytemath: fix newline in debug message
3 years ago
Victor Julien
b31ffde6f4
output: remove error codes from output
4 years ago
Victor Julien
39f5c7f56a
error: use SC_EINVAL for invalid input
4 years ago
Victor Julien
e250ef6402
debug: remove empty header
4 years ago
Philippe Antoine
02f2602dde
src: rework includes as per cppclean
4 years ago
Philippe Antoine
c5cf2967b3
detect: fix integer warnings
...
Ticket: #4516
4 years ago
Philippe Antoine
a6a6f6d538
bytejump: fix ubsan warning
...
Instead of checking the offset, we checked the pointer after
adding the offset ot it...
5 years ago
Philippe Antoine
3de99a214c
pcre2: migrate keywords parsing
5 years ago
Victor Julien
6ab323d323
detect: hide RegisterTests behind ifdef UNITTESTS
...
Update all callers to more aggressively use UNITTESTS guards as well.
6 years ago
Jeff Lucovsky
fb409664d2
detect: byte_math support
6 years ago
Jeff Lucovsky
39105917ce
detect/bsize: Use SCLogDebug instead of printf
...
This commit updates debug "printf" message to use SCLogDebug
6 years ago
Jeff Lucovsky
620659b5f3
detect: Increase flag size for byte_jump
6 years ago
Jeff Lucovsky
23a65b5824
general: Fix typo in detect-bytejump.c
6 years ago
Jeff Lucovsky
0701d82890
detect/bytejump: Add "from_end" support
...
This commit adds support for the byte jump "from_end" keyword and
unittests.
6 years ago
Victor Julien
26bcc97515
detect/keywords: dynamic version part of doc URL
6 years ago
Jeff Lucovsky
d3a65fe156
detect: Provide `de_ctx` to free functions
...
This commit makes sure that the `DetectEngineCtx *` is available
to each detector's "free" function.
6 years ago
Shivani Bhardwaj
0e4f261224
Use StringParse* for all parsers and configurations
7 years ago
Jeff Lucovsky
7f6af10fed
general: copyright bump
7 years ago
Jeff Lucovsky
4b0085b03c
detect: Update to take advantage of PCRE refactor
...
This commit changes the keyword detectors to use the refactored PCRE
modifications from detect-parse.[ch]
7 years ago
Shivani Bhardwaj
d801c3e588
detect: Make keyword description consistent
...
Closes redmine ticket #3137 .
7 years ago
Shivani Bhardwaj
b5b429c288
detect: Add missing keyword URLs and description
...
Add missing keyword URLs and their description. Fix the ones that
were incorrect.
Partially closes redmine ticket #2974 .
7 years ago
Victor Julien
579cc9f02b
const: constify decoder, app-layer, detect funcs
7 years ago
Shivani Bhardwaj
85b56b633e
detect: Improve rule keyword alproto registration
...
1. Set WARN_UNUSED macro on DetectSignatureSetAppProto.
2. Replace all direct 'sets' of Signature::alproto from keyword registration.
Closes redmine ticket #3006 .
7 years ago
Victor Julien
14896365ef
detect: remove Threadvars argument from API calls
...
Remove it as it's (almost) never used. If it is really needed it can
be accessed through DetectEngineThreadCtx::tv as well.
7 years ago
Philippe Antoine
a370d2a91d
signature: fix memory leak in DetectBytejumpSetup
7 years ago
Victor Julien
a496c8be0c
detect/bytejump: suppress runtime error messages
8 years ago
Victor Julien
313661451d
content inspection: support transforms
...
Make sure content is applied to the transformed version of a buffer.
Support content with its modifiers, and also isdataat, pcre, bytetest
and bytejump.
9 years ago
Victor Julien
ab1200fbd7
compiler: more strict compiler warnings
...
Set flags by default:
-Wmissing-prototypes
-Wmissing-declarations
-Wstrict-prototypes
-Wwrite-strings
-Wcast-align
-Wbad-function-cast
-Wformat-security
-Wno-format-nonliteral
-Wmissing-format-attribute
-funsigned-char
Fix minor compiler warnings for these new flags on gcc and clang.
10 years ago
Victor Julien
3626ecb474
bytejump: don't print errors when matching
...
When bytejump was told to convert some payload data to int from a
string it would print an error to the screen if the conversion
failed. This is unwanted as the payload is controlled by an attacker
and printing is expensive.
10 years ago
Victor Julien
cc4010343d
detect: add and use util func for alproto sets
10 years ago
Victor Julien
dfac5276b8
detect: remove unused SIGMATCH_PAYLOAD flag
10 years ago
Victor Julien
fe415ae518
detect: remove DMATCH list
10 years ago
Victor Julien
6bd37611ee
file_data: dynamic buffer
10 years ago
Victor Julien
779d40cedf
detect: remove hardcoded sm_list logic from setup
...
Introduce utility functions to aid this.
10 years ago
Victor Julien
f370e88135
detect: move init only Signature members to init_data
10 years ago
Victor Julien
8edc954e82
detect: get rid of Signature::sm_lists
...
Instead use the lists in init_data during setup and the SigMatchData
arrays during runtime.
10 years ago
Victor Julien
39613778cd
detect: make setup/free/match funcs static where possible
10 years ago
Victor Julien
bfd4bc8233
detect: constify Signature/SigMatch use at runtime
10 years ago
Victor Julien
e67ae0f174
detect keywords: use parse regex util func
11 years ago