Eric Leblond
281d2f27f8
Fix compilation warning
...
A goto could lead to the use de_ctx without declaring it.
12 years ago
Anoop Saldanha
0febe5a410
fix for #760 .
...
If udpv4 csum isn't calculated, udpv4-csum detection shouldn't run on the
csum.
13 years ago
Victor Julien
a55ff64a1b
Use GET_PKT_LEN and GET_PKT_DATA macro's
13 years ago
Anoop Saldanha
a30a1e5950
fix for bug 675.
...
Fix icmpv6-csum to send the right length to calculate the csum.
13 years ago
Anoop Saldanha
af92c2fa4b
Unittest to show the issue we have with 674 - csum-icmpv6 sends
...
wrong length for csum calculation)
13 years ago
Eric Leblond
e176be6fcc
Use unlikely for error treatment.
...
When handling error case on SCMallog, SCCalloc or SCStrdup
we are in an unlikely case. This patch adds the unlikely()
expression to indicate this to gcc.
This patch has been obtained via coccinelle. The transformation
is the following:
@istested@
identifier x;
statement S1;
identifier func =~ "(SCMalloc|SCStrdup|SCCalloc)";
@@
x = func(...)
... when != x
- if (x == NULL) S1
+ if (unlikely(x == NULL)) S1
13 years ago
Anoop Saldanha
98a8234e0a
csum function fixes. Improves alert accuracy. FPs on invalid-csums decoder rules fixed
14 years ago
Victor Julien
cdba2f50d1
Various fixes and improvements based on feedback by Coverity analyzer.
14 years ago
Anoop Saldanha
a4638fb0ad
code cleanup - replace SigMatchAppendPacket with SigMatchAppendSMToList
14 years ago
Anoop Saldanha
2fa55a86fa
Fix csum validation functions to not carry out csum calculation if respective headers are not present
14 years ago
Eric Leblond
8d635ddfc2
detect-csum: incomplete checksum is a valid checksum
...
This patch modify checksum match to not alert on packet with
incomplete checksum. They will be checksummed later and thus
can be considered as valid one.
14 years ago
Anoop Saldanha
420befb180
Changed my email address to anoopsaldanha at gmail dot com from my current one
14 years ago
Anoop Saldanha
54f8d56f48
Packet inspection keywords modified to not inspect pseudo packet
14 years ago
Victor Julien
e1d4e16645
Simplify packet decoding macro's.
14 years ago
Victor Julien
6aa551c558
Small optimizations to IPV4 and TCP header parsing.
15 years ago
Victor Julien
addab7b5ee
Don't test the several packet detection checks against pseudo packets as the matches would not be meaningful anyway. Prevents a segv in the csum detection.
15 years ago
Eric Leblond
a69bb94335
Checksum match: fix logic problem
...
This patch fixes a logic error in the checksum matches. In
case the protocol is not the one tested, the test must return
0 and not 1 (test matched).
Signed-off-by: Eric Leblond <eric@regit.org>
15 years ago
Victor Julien
014f62247a
Another batch of clang fixes. Nothing really serious. Includes a couple of fixes for broken fixes from yesterday.
15 years ago
Victor Julien
ac97bb7799
Fix a number of small clang issues. Clang doesn't know we exit on malloc errors during init.
15 years ago
Anoop Saldanha
82fd581b64
replace all sm lists (match, pmatch, dmatch, umatch, amatch, tmatch) with an array Signature->sm_lists[]. Replace all Signature->match instances in the engine with Signature->sm_lists[DETECT_SM_LIST_MATCH]
15 years ago
Gerardo Iglesias Galvan
9f4fae5b1a
Fix inconsistent use of dynamic memory allocation
15 years ago
William Metcalf
ce01927515
Import of GPLv2 Header 050410
16 years ago
Victor Julien
8b30226914
Detection keyword cleanup
16 years ago
Victor Julien
b259e362cd
Convert uricontent to use new scanning methods as well. Move http_method and http_cookie keywords out of pmatch list for now.
16 years ago
Pablo Rincon
25a3a5c6d8
Adding mem wrapper to debug runtime alloc()/free() functions. Fixing some memory leaks.
16 years ago
Gerardo Iglesias Galvan
ba6d807a6e
Improve information about errors on signature failure
16 years ago
Victor Julien
ecf86f9c23
Rename to Suricata.
16 years ago
Gurvinder Singh
a0f184866c
http_cookie keywork support
16 years ago
Victor Julien
0d0ffb9963
Reorganize header inclusions.
16 years ago
Anoop Saldanha
22c0ec2bc5
Added support for the csum-<protocol> rules keyword to the detection engine. Keywords added are ipv4-csum, tcpv4-csum, tcpv6-csum, udpv4-csum, udpv6-csum, icmpv4-csum and icmpv6-csum
16 years ago