Commit Graph

16993 Commits (cb997a64dc2e905bf5c4779154c7bc275efe7997)
 

Author SHA1 Message Date
Lukas Sismis cb997a64dc dpdk: replace global with per-thread mempools
It turned out that having global (interface-specific) mempool
that is shared by the threads of the interface is slower than
having individual mempools per queue for each interface.

The commit brings this change and should be user-invisible,
the config setting remains still as a number of objects of
all mempools summed (of that interface).

Ticket: 7382
5 months ago
Lukas Sismis 5e2974458d dpdk: remove mempool pointer from the thread structure 5 months ago
Lukas Sismis 2ef2a9e26f dpdk: auto configure Rx/Tx descriptors and mempool size
Ticket: 7380
Ticket: 7373
5 months ago
Philippe Antoine 3a092f3027 detect: allow rule which need both directions to match
Ticket: 5665

This is done with `alert ip any any => any any`
The => operator means that we will need both directions
5 months ago
Jason Ish 81915548de ndpi: ignore packets that have a different proto than the flow
This can happen when the flow is UDP, but an ICMP unreachable is
returned, which gets assigned to the same flow.

Reference: https://github.com/ntop/nDPI/issues/2762
5 months ago
Jason Ish 66eb29affd doc/ndpi: move ndpi docs to new plugins section
Moves the nDPI documentation to an nDPI page in the plugins
section. Remove the duplication of installation and setup
documentation.

Includes some minor cleanups.
5 months ago
Jason Ish 10ed6280ff ndpi: fix memory in keyword setup
- remove duplicate calls to ndpi_init_detection_module
- cleanup ndpi_init_detection_module when no longer needed
5 months ago
Jason Ish d3835bbb11 detect: split new keyword id from registration
Split DetectHelperKeywordRegister into 2 functions, one for acquiring
a new keyword ID, and another to perform the registration.

This makes it easier to do the traditional C keyword initialization
with a dynamic ID.
5 months ago
Jason Ish 9c522a0ac9 eve/schema: add top level ndpi object
The format is left free-form, as its controled by a plugin.
5 months ago
Jason Ish 078b7a4251 github-ci: add ndpi build to the centos-stream9 build
- Download and build nDPI
- Enable nDPI during Suricata ./configure
- Test that the plugin was built and installed
5 months ago
Alfredo Cardigliano dfd9ef5784 ndpi: initial implementation of nDPI plugin
Ticket: #7231
5 months ago
Alice Akaki ce2e7aed74 detect: add email.date keyword
email.date matches on MIME EMAIL DATE
This keyword maps to the EVE field email.date
It is a sticky buffer
Supports prefiltering

Ticket: #7591
5 months ago
Alice Akaki 7750129c65 mime/email: log date and subject fields 5 months ago
Victor Julien 834378ff88 detect: per tx detect flags to a u8 progress value
Reduce per tx space for tracking detection/prefilter progress. Instead
of a per direction u64 of flags, where each bit reflected a progress
value, use a simple u8 to track the linear progression through the
progress values. Use an offset to allow 0 to mean no value.

Add flags field as well to track "skip detect" and "inspect complete".
5 months ago
Victor Julien 1542bcdc67 app-layer: add helper for AppLayerTxData cleanup 5 months ago
Victor Julien 8c9dfafc6d doc/tls: add more detail on tls.random 5 months ago
Victor Julien 682f1aac84 detect: reorder struct 5 months ago
Lukas Sismis 4a20baa6a8 landlock: add read/write permission to MPM cache directory 5 months ago
Lukas Sismis 7dc65c2f8a hyperscan: add caching mechanism for hyperscan contexts
Cache Hyperscan serialized databases to disk to prevent compilation
of the same databases when Suricata is run again with the same
ruleset.
Hyperscan binary files are stored per rulegroup in the designated
folder, by default in the cached library folder.
Since caching is per signature group heads,
some chunk of the ruleset can change and it still can reuse part of
the unchanged signature groups.

Loading *fresh* ET Open ruleset:  19 seconds
Loading *cached* ET Open ruleset: 07 seconds

Ticket: 7170
5 months ago
Lukas Sismis 59c3b8912b util-mpm: prepare MPM codebase for ruleset caching 5 months ago
Lukas Sismis 65cfc6d926 util-mpm-hs: refactor Hyperscan Pattern DB initialization to smaller functions 5 months ago
Lukas Sismis 939e16b12c detect-engine: remove commented out code 5 months ago
Lukas Sismis a5027e41e9 util-path: remove dead code 5 months ago
Lukas Sismis 2188cfca24 util-hash: add iterator for hash function 5 months ago
Lukas Sismis bd1885c71a hashlittle: add a safe variant of hashlittle2 function
This variant of hashlittle2() ensures that it avoids
accesses beyond the last byte of the string, which will
cause warnings from tools like Valgrind or Address
Sanitizer.
5 months ago
Philippe Antoine 879a733c12 doc/http2: explicit behavior for some http keywords
HTTP/2 does not define a way to carry the version or reason phrase
that is included in an HTTP/1.1 status line.

Ticket: 6548
5 months ago
Philippe Antoine 91389a40ce ci: test cargo fmt for some subdirs
The ones that respect it as new
5 months ago
Philippe Antoine c164cfcf6b plugins: check version for all plugins 5 months ago
Philippe Antoine 5742df3783 plugins: bind constant SC_PLUGIN_API_VERSION 5 months ago
Philippe Antoine 52862e50be plugin: constify some fields
including the tx parameter to the logger function
5 months ago
Philippe Antoine 1db49487a1 rust/detect: extend visibility of SIGMATH_NOOPT
so that it can be used by plugins

Avoid export by cbindgen as this constant is also defined in C
5 months ago
Philippe Antoine 2fa3a9fe62 template: rustfmt
and use generic logger callback prototype with later cast

and do some other small modifications so that the plugin
has less diff
5 months ago
Shivani Bhardwaj a4b8c5319c stream: make counter fns static 5 months ago
Shivani Bhardwaj 6aea48e8a6 util/stream: remove duplicate nested statement 5 months ago
Shivani Bhardwaj 7f98683d45 stream: use max-region setting from suricata.yaml
1. Add key (commented) to suricata.yaml
2. Give the configured/default key preference, save a check
5 months ago
Shivani Bhardwaj 22d05c289c stream: replace explicit logic w pre-existing fn 5 months ago
Shivani Bhardwaj 6d05e603cd stream: combine statements w same outcome 5 months ago
Shivani Bhardwaj 863c96f30d stream: fix minor typos 5 months ago
Shivani Bhardwaj 32d6fb9403 stream: use bool wherever possible 5 months ago
Shivani Bhardwaj d096b989c8 stream: add defensive checks and comments 5 months ago
Shivani Bhardwaj ce027af269 stream: remove unneeded else 5 months ago
Jeff Lucovsky a654ad9c9a output/buffer: Change buffer-size default value
The buffer-size value that controls file output buffering defaults to
8k. To be consistent with previous logic, the default is being changed
to 0 (e.g., needed if there are old config files that don't specifically
enable the new value).
5 months ago
Philippe Antoine ed5aed3f52 detect/ja: use multi-protocol support
instead of hardcoding list : removes usage of ALPROTO_QUIC and
ALPROTO_TLS in generic SigValidate

Ticket: 7304
5 months ago
Philippe Antoine f97767043f detect: clean support for multi-protocol keywords
such as ja4.

Why ?

We do not want to see hard-coded protocol constants such as
ALPROTO_QUIC directly used in generic code in detect-parse.c

How ?
From the keyword point of view, this commit adds the function
DetectSignatureSetMultiAppProto which is similar to
DetectSignatureSetAppProto but takes multiple alprotos.
It restricts the signature alprotos to a set of possible alprotos
and errors out if the interstion gets empty.

The data structure SignatureInitData gets extended with
a fixed-length array, as the use case is a sparse number of protocols

Ticket: 7304
5 months ago
Philippe Antoine 4a82bb7866 app-layer: improve limits on number of probing parsers
There was an implicit limit of 32 app-layer protocols
used by probing parsers through a mask, meaning that
Suricata should not support more than 32 app-layer protocols
in total.

This limit is relaxed to each flow not being able to
run more than 32 probing parsers, meaning that for each source
and destination port combination, the sum of registered
probing parsers should not exceed 32, even if there are more
than 32 in total.

Also sets probing parsers done sooner in the case the other
side of the connection was detected first.

Ticket: 7437
5 months ago
Juliana Fajardini cd69955d7f doc/userguide: add lua flowlib docs
Task #7489
5 months ago
Juliana Fajardini 9480272509 doc: remove old lua flow methods
Task #7489
5 months ago
Juliana Fajardini 61d47da359 lua: remove old lua flow calls
Moving forward, the flowlib is to be used.

Task #7489
5 months ago
Juliana Fajardini b03d1aed81 lua: add initial suricata.flow lib
Methods:
`get` creates the flow object.
`id`  returns the flow id.
`has_alerts` returns a boolean indicating if the flow triggered alerts.
`app_layer_proto` returns various app-layer related fields as 5 strings:
  alproto, alproto_ts, alproto_tc, alproto_orig, alproto_expect.
`stats` returns cnts for bytes and packets to sever and to client, as 4
  numbers.
`tuple` -- returns various fields: srcip, dstip, proto, sp, dp.
`timestamps` returns time as 4 numbers: seconds and microseconds, for
  first and last packet of the flow.
`timestring_legacy` returns the first packet from the flow's timestring
  as a string (like fastlog).
`timestring_iso8601` returns the first packet from the flow's
  timestring as an iso8601 compat timestring (like eve).

Example:

```
name = "lua-scflowstats.log"

local flow = require("suricata.flow")

function init(args)
    local needs = {}
    needs["type"] = "flow"
    return needs
end

function setup(args)
    filename = SCLogPath() .. "/" .. name
    file = assert(io.open(filename, "a"))
    SCLogInfo("lua SCFlowStats Log Filename " .. filename)
end

function log(args)
    local f = flow.get()
    timestring = f:timestring_legacy()
    tscnt, tsbytes, tccnt, tcbytes = f:stats()

   file:write ("[**] " .. timestring .. "\nSCFlowStats is\nPacket count to server:  " .. tscnt .. "\nByte count to server: " .. tsbytes .. "\nPacket count to client: " .. tccnt .. "\nByte count to client: " .. tcbytes .. "\n[**]")
    file:flush()
end

function deinit(args)
    file:close(file)
end
```

Task #7489
5 months ago
Juliana Fajardini 5e86c662ef lua: fix typos 5 months ago