Breno Silva
67f2026279
Global Threshold config
17 years ago
Victor Julien
08600df6b1
Small uri cleanups.
17 years ago
Pablo Rincon
c7350a8ac6
Fixing some naming convention issues and incorrect error messages
17 years ago
Pablo Rincon
b708d7f65d
Adding Uricontent inspection with spm. Modifiers for uricontent are now supported
17 years ago
Victor Julien
e3552a8e3f
Add more comments to detect and flow structures.
17 years ago
Gurvinder Singh
8e444f1772
stream and application layer improvements
17 years ago
Victor Julien
3d7b882bde
Make sure all smsgs are handled every time, even in case or error. The fuzzer found an issue where unhandled messages remained in the queue leading to threading issues.
17 years ago
Victor Julien
cb8aaa5968
Make sure we only run the app layer proto detection (successfully) once per flow. Solves an issue found by the fuzzer where both flow directions were detected as different protos, messing up the app layer parser.
17 years ago
Victor Julien
68576947e2
Small SMB cleanups.
17 years ago
Victor Julien
f4ee4f5670
Properly clear list tail ptr in segment list.
17 years ago
William Metcalf
b0faeb91d7
small PF_RING update cmd line opts changed
17 years ago
Gurvinder Singh
4879045c6f
bug 102 patch
17 years ago
Victor Julien
4fd4c1331e
Fix broken unittest, improve within error messaging.
17 years ago
Anoop Saldanha
c54b91ed94
fix for bug 113
17 years ago
Victor Julien
6be0778532
Comment SigMatchSignatures a bit.
17 years ago
Kirby Kuehl
f08d3e76ee
add maximum andx chain depth
17 years ago
Jason Ish
acaee78b1c
Fix bug 125. - Always bail on parse errors. - Exit if loading the config file fails. - Display the line number where the parsing failed.
17 years ago
Victor Julien
449205cfeb
Remove wrong copyright info, cleanup headers.
17 years ago
Kirby Kuehl
afb08d388d
make sure we have input_len
17 years ago
Pablo Rincon
4a351c07a6
Bug 103, bound checks at pppoe, added macros for 4bit fields
17 years ago
root
ddf995da3b
pfring support lb type, and now uses logging subsys
17 years ago
Victor Julien
057031acce
Don't inspect more methods than necessary.
17 years ago
Pierre Chifflier
5535e083a0
Fix prelude init and cleanup sequence using OutputCtx
...
Signed-off-by: Pierre Chifflier <chifflier@edenwall.com>
17 years ago
Jason Ish
37bb733929
Looks like something happened in a previous merge: - Don't set the limit here, its already set. - Don't write the log file header here, its also been written.
17 years ago
Jason Ish
40f9653c06
Have output plugs use an OutputCtx which is a little more generic than LogFileCtx. The OutputCtx provides a place for module private data to avoi overriding the LogFileCtx.
17 years ago
Victor Julien
99d5dc3d2a
Don't scan more cookie headers than necessary.
17 years ago
Victor Julien
c1a19bcd6b
Fix compilation of new detect-filter code, fix ip-only compatibility of detect-filter code.
17 years ago
Gerardo Iglesias Galvan
ef2ae76c42
Add support for detection_filter keyword
17 years ago
Jason Ish
eab93e766a
Do policy lookup for defrag. Add unit test for a default host os policy. Update example config to use a default. Add 2 new policies to the stream to cover all the policies for stream and defrag.
17 years ago
Gurvinder Singh
7438f981da
stream memory leaks fixed and unit tests added
17 years ago
Victor Julien
90006d94a6
Fix compilation
17 years ago
Jason Ish
5c3ab2b73f
Load host OS info from the configuration.
17 years ago
Victor Julien
297001c6d9
Only process a app layer sig if it has the proper state. Make sure a sig can't have conflicting sigmatches, such as ftpbouce and uricontent.
17 years ago
Victor Julien
ec47f840f3
Remove more scan references.
17 years ago
Victor Julien
bee4e04664
More scan/search related cleanups.
17 years ago
Victor Julien
7a8cd61fdf
Cleanups.
17 years ago
Victor Julien
153d1425fe
Fix nocase searching in payload search phase.
17 years ago
Victor Julien
80dc4f1dbe
Further simplify content api: merge flags that indicate a next relative match, remove chunks as they are unnecessary now, make negated a bitflag.
17 years ago
Victor Julien
f0d68b633e
Remove nosearch flag from pattern api and add a generic bitwise flags field.
17 years ago
Victor Julien
1e01fd613c
Remove all references to the scan phase from the pattern matchers and it's api.
17 years ago
Victor Julien
dd846c9b0e
Remove all search code from the pattern matchers, cleanup mpm api, remove unused http code, more cleanups.
17 years ago
Victor Julien
6990d9c91b
Fix thresholding signature unittests. Because of the bug fix that made thresholding compatible to ip-only sigs the test sigs needed to be made non-ip-only.
17 years ago
Victor Julien
f298fec872
Make sure nocase applies to the last pattern, content or uricontent.
17 years ago
Victor Julien
24b5149adf
Remove search phase from b2g pattern matcher.
17 years ago
Victor Julien
0e7cb90212
Fix broken pmatch list handling.
17 years ago
Victor Julien
27f3382066
Fix rules with thresholding set not being able to be ip-only.
17 years ago
Victor Julien
8b30226914
Detection keyword cleanup
17 years ago
Victor Julien
6637873348
Update prev ptrs in SigMatchReplaceContent
17 years ago
Victor Julien
b259e362cd
Convert uricontent to use new scanning methods as well. Move http_method and http_cookie keywords out of pmatch list for now.
17 years ago
Victor Julien
bef70a04ce
First stage of detect engine redesign: equal patterns share id's, search phase no longer used, new match verification phase.
17 years ago
Victor Julien
50e41817a7
Share content id's between identical patterns.
17 years ago
Victor Julien
4494545d3a
Fix bogus error message.
17 years ago
Victor Julien
5e3f072fa6
Clean up flow mutexes after use.
17 years ago
Pablo Rincon
25a3a5c6d8
Adding mem wrapper to debug runtime alloc()/free() functions. Fixing some memory leaks.
17 years ago
Pablo Rincon
ebcbc859e3
Fix on IPOnly match at flows, for inline mode
17 years ago
Anoop Saldanha
505088e7bc
Fix for bug 50. Make timebased counters more accurate
17 years ago
Victor Julien
f442c1f5ec
Make sure log-http checks for a valid p->flow ptr before using it.
17 years ago
Victor Julien
51f2bc1d81
Fix compilation on Linux, add error checking to Win32 SCFmemopen and properly indent.
17 years ago
Jan Jezek
4e72ccf987
Fixed Win32 compilation, unit tests now compile.
17 years ago
Victor Julien
d6c53b68bf
Fix two separate segv's in the http logging code.
17 years ago
Victor Julien
e462364e68
Use snprintf instead sprintf
17 years ago
Gurvinder Singh
8ff242beff
bug 98 patch
17 years ago
Victor Julien
045eaec95b
Fix file permissions.
17 years ago
William Metcalf
260d0d7673
Steve Grub fixes... Thanx Steve!
17 years ago
William Metcalf
0fe4373b67
Rolled back to 0.2.x branch renamed htp to libhtp
17 years ago
Victor Julien
dc11247511
Change the way we replace contents by http_method and http_cookie, fixing #90 .
17 years ago
Victor Julien
45b85c063a
Fix segv in http log module.
17 years ago
Victor Julien
60685f8b3c
Make unittests run more quiet.
17 years ago
Jason Ish
7537013e16
Fix bug 99.
...
- Handle the case where the parent node already exists in ConfSet.
- Deal with allow_override properly when a node has already been
set with ConfSet.
17 years ago
Jan Jezek
c1cbdf6ae9
Win32 build fixed.
17 years ago
Pablo Rincon
7719216575
Setting thread priorities with nice
17 years ago
Jason Ish
73700af92b
afaik integer increments are not atomic, so put inside the lock
17 years ago
Gurvinder Singh
50f7d0a887
app layer htp logging and better htp request handling. removed recent_in_tx.
17 years ago
Victor Julien
aa1564791d
Disable thread priority code until we understand it better.
17 years ago
William Metcalf
f7111f3847
import of integrated htp lib and small libnet fixes
17 years ago
Gurvinder Singh
4768e42159
bug 95 patch
17 years ago
Jason Ish
ea277a0b36
Cleanup of configuration internals. Use an n-ary type tree for everything instead of a first level hash branching off into n-ary type trees.
...
Reduces the code and uses a uniform internal data structure.
17 years ago
Pablo Rincon
38dc7ffebc
Adding settings for detect engine group config
17 years ago
Jason Ish
fbdf1baf1c
- rebase
...
Provide limits to the unified outputs.
17 years ago
Victor Julien
16b6f536a0
Fixup Linux compilation after applying win32 patches.
17 years ago
Jan Jezek
bff652d2f3
Added missing win32 files.
17 years ago
Jan Jezek
fe6a72befc
Code is now compilable on the Win32 platform
17 years ago
Victor Julien
f0b9ad3f1f
Update version to 0.8.1
17 years ago
Victor Julien
b28488508b
Cleanup threading cpu affinity and prio output.
17 years ago
Victor Julien
c1e2e53809
Mhz->MHz
17 years ago
Anoop Saldanha
903b24667b
Some more formating changes for cuda startup device info logs
17 years ago
Anoop Saldanha
07034d0d85
Updated cuda device information logs with some minor formatting changes
17 years ago
Anoop Saldanha
1a5ee37bd3
Added cuda logs for the engine, which shows device info and memory usage
17 years ago
Anoop Saldanha
30940c9a94
pack all the packet pattern scan and search packet setup for cuda into a function inside util-cuda-handlers.[ch]
17 years ago
Victor Julien
963691387a
Disable unused uri scanning code.
17 years ago
Anoop Saldanha
8cf60d6645
Changed the way cuda dispatcher passes back results. Now each detection thread has it's own queue to which the dispatcher can pump packets back to the detect thread. Also, with cuda enabled and a non-cuda mpm being used, we won't create a dispatcher and instead call the b2g scan/search funtions directly instead of using the dispatcher.
17 years ago
Anoop Saldanha
c26e92733d
handle the cuda cleanup at shutdown. should get rid of any errors from the call to SigGroupCleanup
17 years ago
Victor Julien
d281a6b8ac
CUDA build system support & compile fixes
...
- add configure support for CUDA
- make sure all code compiles if CUDA is disabled
- fix compiler warnings
17 years ago
Anoop Saldanha
a2948fc25c
valgrind fixes for b2g cuda mpm
17 years ago
Anoop Saldanha
41e6735b92
mpm b2g cuda support added
17 years ago
Anoop Saldanha
84df26d3fd
cuda interface
17 years ago
Pablo Rincon
985d565cfd
Change priorities only if we are EUID == 0
17 years ago
Pablo Rincon
80f5008728
Adding default priority for all the threads
17 years ago
Pablo Rincon
b482471a7d
Adding auto runmodes based on available core/cpu's. Setting thread priorities
17 years ago
Pablo Rincon
34216fd3e2
bug87 Fix IPOnly veredicts on flows
17 years ago
Victor Julien
d3244e51eb
Fix big endian iponly handling.
17 years ago
Victor Julien
59ccef9a11
Handle ip only matching correctly on big endian systems. Thanks to Yao-Min Chen for figuring this out.
17 years ago
Pablo Rincon
cef12d30b5
Unified output fixes: alert count per module (not per thread), fix timestamps on pcap mode, write *all* the alerts of a packet, write the log header once also on unified alert
17 years ago
Breno Silva
b02bb6b6b4
VLAN Support
17 years ago
Pablo Rincon
29d51a6182
Using the loggin API in source-pcap and source-pcap-file
17 years ago
Gurvinder Singh
5293681860
b86
17 years ago
Victor Julien
4f3a04a410
Disable htp cleanup code as I'm not yet convinced it does what it should.
17 years ago
Gurvinder Singh
bf236e4567
better htp memory handling & flow valgrind error fixed
17 years ago
Jason Ish
763fb4a583
Fix threading issues with unified-log. - Only write the header once, on opening, not per thread init. - Track the size in the log file ctx, not per thread.
17 years ago
Victor Julien
defc6595c6
Make pcre P have it's own sm type.
17 years ago
Pablo Rincon
0165b3f0d8
pcre P modifier support (pcre match over http body requests)
17 years ago
Gerardo Iglesias Galvan
ba6d807a6e
Improve information about errors on signature failure
17 years ago
Jason Ish
cc28284598
Set the ethernet header pointer. Without this, alert-unified-log will add an extra ethernet header to every alert logged.
17 years ago
Kirby Kuehl
565eab1f54
fix bug88
17 years ago
Kirby Kuehl
a334a87109
smb safety checks
17 years ago
Kirby Kuehl
bea30a6db6
bug 88 validate dcerpc header
17 years ago
Jason Ish
9e4da4f8e7
supply pcre_get_substring with the proper start of the string.
17 years ago
Kirby Kuehl
a8c3718b56
signed unsigned comparision fix for 64 bit
17 years ago
William Metcalf
7099da431b
small fix for source-pfring.c after stat err rename
17 years ago
Jason Ish
e87d4f8a28
Split the defrag counters into ipv4 and ipv6.
17 years ago
Victor Julien
2cb2989ad8
Apply configurable max pending packets to nfq and ipfw
17 years ago
Jason Ish
7142fdb780
quick way to make max_pending configurable.
17 years ago
Victor Julien
187949b9ad
Make urilen inspect the normalized uri, cleanup uri (error) handling.
17 years ago
Jason Ish
6b562f7aa6
Issue 82 - fragment counters. - number of fragments - number reassembled - number of timeouts
17 years ago
Victor Julien
3d0355bae8
Compile fix.
17 years ago
William Metcalf
c3e70accd2
pcap and pfring exit stats
17 years ago
Victor Julien
b99e10236c
Fix a endless loop condition in the smb parser and make dcerpc parser more quiet.
17 years ago
Victor Julien
16aebe5add
Fixup smb tests.
17 years ago
Kirby Kuehl
957b43b3d6
signed unsigned comparision cleanup
17 years ago
Kirby Kuehl
40a0fd5e97
fix warning
17 years ago
Kirby Kuehl
4b05bc281d
fix padding bug
17 years ago
Kirby Kuehl
6aac8d55a6
reset smb bytesprocessed when complete
17 years ago
Kirby Kuehl
4dd2f621ac
smb writeandx dcerpc over smb
17 years ago
Pablo Rincon
583c686170
Allowing no case options for flow keyword. Adding unittests for this
17 years ago
Victor Julien
194015c6cf
Fix reject code to not send resets for all alerts.
17 years ago
William Metcalf
f925ac9351
printf to logging subsys conversion for src/detect-bytejump.c
17 years ago
Gurvinder Singh
999a200bc9
pattern matcher options support
17 years ago
Pablo Rincon
d0404d8447
Renaming errors with naming conventions
17 years ago
Pablo Rincon
ad2c136e8f
Renaming errors (naming conventions)
17 years ago
Jason Ish
8f618b2121
- actually re-inject ipv6 re-assembled packets. - set the next header.
17 years ago
Jason Ish
8570976ee0
Fix for lists that are children of another list. Fix memory leak by only setting the sequence index value to the first item found.
17 years ago
Victor Julien
501c8814b6
fix crash in urilen
17 years ago
Victor Julien
ed7762e843
Disable unused jabber proto detection as it made the proto detection code look way more into the stream than without it.
17 years ago
Jason Ish
6f73aca1e8
I know Snort defaults to syslog in daemon mode, but should we?
...
Stick to the logging configuration defined in the config file
in daemon mode.
17 years ago
Jason Ish
c72d6be58b
Making logging configurable. If no logging outputs are defined the default will be used. - Currently per output log formatting is not available.
17 years ago
Breno Silva
a857fa7170
FragOffset Rule Keyword
17 years ago
Breno Silva
7e299834d2
FragOffset Rule Keyword
17 years ago
Victor Julien
f96511a8b1
Check reassembly limits against correct stream direction. Set proper direction flag in stream msgs.
17 years ago
Gurvinder Singh
ed99e73622
bug 78
17 years ago
Kirby Kuehl
58c8103a4b
fix unittest
17 years ago
Victor Julien
53c9276d51
Cleanup pcap output.
17 years ago
Victor Julien
e0aacac4c6
Move bpf string retrieval to it's own function. Clean up pcap sourcres a bit.
17 years ago
William Metcalf
ba46c16aac
bpf support for pcap modes
17 years ago
Pierre Chifflier
4515ae13e4
Add Prelude output plugin
...
Add support for reporting alerts to the Prelude SIEM system, using
libprelude to send IDMEF (RFC4765) messages.
Each message contains the alert description and reference (using
the SID/GID), and a normalized description (assessment, impact,
sources etc.)
libprelude handles the connection with the manager (collecting component),
spooling and sending the event asynchronously. It also offers transport
security (using TLS and trusted certificates) and reliability (events
are retransmitted if not sent successfully).
This modules requires a Prelude profile to work (see man prelude-admin
and the Prelude Handbook for help).
Signed-off-by: Pierre Chifflier <chifflier@edenwall.com>
17 years ago
Gurvinder Singh
cf5266094d
bug 66 patch
17 years ago
Victor Julien
148883cedf
Work around for unsupported CONNECT support handling.
17 years ago
Victor Julien
7deb4e9f09
Cleanup AppLayerDetectGetProto a bit.
17 years ago
Victor Julien
fd409049cb
First step for proper HTTP CONNECT handling.
17 years ago
Victor Julien
9f3f9e9ba1
Fix ipfw verdict.
17 years ago
Gurvinder Singh
3cad20946d
bug 64 patch
17 years ago
Victor Julien
53977fded6
Small compilation fixes when debugging is disabled.
17 years ago
Victor Julien
6a53ab9c5a
Stream engine memory handling update
...
The stream engine memory handling needed updating as it didn't scale. Changes:
- pools can now be initialized to size 0, meaning unlimited
- stream engine uses a memcap setting. Sessions, segments and aldata is part
of this, app layer state isn't.
- memory is accounted using a global int that is spinlocked.
- a counter for sessions that have not been picked up because of memcap was
added.
- all reassembly errors are converted to debug msgs.
17 years ago
Victor Julien
df4c642c70
Fix weird compile error
17 years ago
Victor Julien
b1531f7244
Manually merge Pablo's IPFW action patch.
17 years ago
Pablo Rincon
51dc773eec
Changing the veredict actions to flags to allow simultaneous veredict
17 years ago
Nick Rogness
2b7b78f1bf
Intial IPFW support FreeBSD and OSX
17 years ago
Jason Ish
fbf03a927d
Fix issue 71. The insert and re-assemble need to be done under the same tracker lock.
17 years ago
Victor Julien
f7f33ec889
Fix the flow manager sleeping for way too long in some situations.
17 years ago
Kirby Kuehl
298bf4cc88
dcerpc over smb for transact
17 years ago
Victor Julien
bbfe1d293e
Fix merge artifact.
17 years ago
Victor Julien
f08d01a8e8
Set sensible tcp timeout defaults and no longer set the timeouts from the stream engine.
17 years ago
Pablo Rincon
7f250a814a
Fixing redeclaration of run_mode
17 years ago
Pablo Rincon
5592189c04
Loading flow settings from config
17 years ago
Kirby Kuehl
8efbe491a1
dcerpc refactoring
17 years ago
Kirby Kuehl
008de4321b
refactor dcerpc in prep for dcerpc over smb
17 years ago
Anoop Saldanha
546e9b5f28
AddressCutNot fix for address engine ipv6
17 years ago
Anoop Saldanha
e25696afce
engine address ipv6 refactored
17 years ago
Gurvinder Singh
d9677c7e2a
bug 76 patch
17 years ago
Jason Ish
0a5bc2d600
Fix issue 74. separate initialization of run modes from adding them to a thread. - fixes issues with multiple output threads.
17 years ago
Pablo Rincon
260e581929
First version of the reputation API
17 years ago
Kirby Kuehl
f15ca04889
fix padding calculation and stubdata parser for dcerpc
17 years ago
William Metcalf
811f2f605d
small fix for ! inside of content match
17 years ago
Pablo Rincon
9ec2057a21
Small fix, renaming
17 years ago
Victor Julien
2481f2102b
Add missing return value evaluation in port parsing and fix broken unittest.
17 years ago
Victor Julien
b3bcba077f
Only inspect http flows against uri sigs, clean up uri scanning code.
17 years ago
Gurvinder Singh
0cb43d27e9
uricontent new design
17 years ago
Gurvinder Singh
356a8bf385
applayer uri match and modified http handling
17 years ago
Victor Julien
fcb03099a3
Fix reassembly updating the wrong stream on ACK
...
The stream reassembly updated the wrong stream on received ACK packets. Instead
of the opposing stream it updated the stream in packet direction. This caused
issues in the app layer handling.
Updated the unittests as well.
17 years ago
Pablo Rincon
256d745b39
Including header file for cpu detection
17 years ago
Pablo Rincon
17cd010b0c
Detect the number of CPUs configured and online. Printing a small summary at the startup
17 years ago
Victor Julien
0d3da34f64
remove unused variables
17 years ago
Victor Julien
c352bff6fb
Remove unused conditional locking code from the app layer parsing code.
17 years ago
Breno Silva
5461c60ada
Allow threshold options in any order
17 years ago
Victor Julien
d446b85237
Remove obsolete files.
17 years ago
Steve Grubb
f853da7940
Get make distcheck working
...
Hello,
Below is a patch that gets "make distcheck" working. Its against the
current code in git. The project version was set to 0.1 in configure,
I changed that to 0.8.1 just so its actually relevant. You might want
to set that to something else.
After checking this patch, I find that there are several source code
files in src/ that are not getting compiled:
-app-layer-detect.c
-app-layer-detect.h
-app-layer-http.c
-reputation.h
Are these new or abandoned? Anyways...here's the patch.
-Steve
17 years ago
root
b5529f7131
add stubdata pointer
17 years ago
Kirby Kuehl
08915649f3
fix double free
17 years ago
Victor Julien
f4a23f2325
Fixup noisy debug statement.
17 years ago
Victor Julien
0d34990d7f
Add OpenBSD's strlcpy and strlcat and replace all strcat/strcpy/strncat/strncpy by those calls.
17 years ago
Jason Ish
7d920a1254
Fix issue 65.
...
- Update unit test to trigger the failure found in the issue 65 pcap.
- Increase pkt buffer to account for the IPv6 header, as a maximum
size IPv6 datagram is 40 + 0xffff.
- Account for IPv4 header when checking where end of fragment lies.
- Second sanity check during re-assembly to check for writing past
the end of the pkt buffer.
17 years ago
Victor Julien
1b8f391607
Fixup flowbits signature keyword parsing memory handling.
17 years ago
Steve Grubb
c95cd2e80a
memory leak cleanups in misc places
...
Hello,
This is all the rest of the memory leaks I found.
*In src/source-pcap-file.c at line 152, ptv is not being freed.
*In src/util-unittest-helper.c at line 152, p was not being freed.
*In src/log-httplog.c at line 195, aft was not being freed
*In src/counters.c at line 51, log_filename was not being freed. At line 1188
pctx is being tested to see if its NULL. However, at 1173 it exits the
function if it were NULL. This test is not needed and should be deleted.
*In src/defrag.c at line 351, tracker was not being freed. At line 390, dc is
being checked for NULL but this was already done at line 384. Probably what
was meant was checking the value of dc->frag_table which was just assigned.
The patch below makes the above described changes.
-Steve
17 years ago
Steve Grubb
60ad9d29c5
Memory leak cleanup in detectors
...
Hello,
I ran the code through an analysis program and found several leaks that
should be cleaned up.
*In src/detect-engine-address-ipv4.c at line 472, the test for ag == NULL
will never be true since that is the loop entry test.
*In src/detect-engine-port.c at line 1133, the test for p == NULL will
never be true since that is the loop entry test.
*In src/detect-engine-mpm.c at line 263 is a return without freeing
fast_pattern
*In src/detect-ack.c at line 80 and 85, data catches the return from malloc.
One of them should be deleted.
*In src/detect-seq.c at line 81 and 86, data catches the return from malloc.
One of them should be deleted.
*In src/detect-content.c at line 749, many of the paths that lead to the error
exit still has temp pointing to allocated memory. To clean this up, temp
should be set to NULL if not immediately assigning and new value.
*In src/detect-uricontent.c at line 319, both cd and str needto be freed. At
lines 344, str needs to be freed. And at line 347 str and temp need to be
freed.
*In src/detect-flowbits.c at line 231 and 235, str was not being freed. cd was
not being freed at line 235.
*In src/detect-flowvar.c at line 127, str was not being freed. At line 194, cd
and str were not being freed.
*In src/detect-flowint.c at line 277, sfd was not being freed. At line 315, str
was not being freed.
*In src/detect-pktvar.c at line 121, str was not being freed. At line 188, str
and cd was not being freed.
*In src/detect-pcre.c at line 389, there is an extra free of "re" that should
be deleted.
*In src/detect-depth.c at line 42 & 48, str has not been freed.
*In src/detect-distance.c at line 49 and 55, str has not been freed
*In src/detect-offset.c at line 45, str has not been freed.
The patch below fixes these issues.
-Steve
17 years ago
Steve Grubb
f6653752c5
memory leak cleanup in alerts
...
Hello,
I ran the code through an analysis program and found several memory leaks
in the alert code.
*In src/alert-fastlog.c at line 178, aft was not being freed
*In src/alert-debuglog.c at line 205, aftwas not being freed
*In src/alert-unified-log.c at lines 234 and 243, aun was not being freed
*In src/alert-unified-alert.c at lines 219 and 230, aun was not being freed
*In src/alert-unified2-alert.c at line 505, aun was not being freed
The patch below fixes this.
-Steve
17 years ago
Victor Julien
5f5a44b365
PPPoE fixes.
17 years ago
William Metcalf
82978f9f27
new pfring runmode for quad core, other small pfring fixes
17 years ago
Victor Julien
434da6b965
Set no reassembly flags on sessions we don't recognize the protocol for.
17 years ago
Gurvinder Singh
f6b0c481b0
urilen support for engine
17 years ago
Victor Julien
9b4f3f918b
Fix broken debug code in stream reassembly
17 years ago
Pablo Rincon
c1e6aabb0a
Small fix
17 years ago
Pablo Rincon
705471e4ee
Adding single pattern matcher algorithms. If you cannot store a context for the patterns, use SpmSearch() macro. Adding unittests and stats
17 years ago
Victor Julien
cae8e06cb9
Properly lock app layer result pool and add some debugging code for memory tracking.
17 years ago
Victor Julien
4284276b11
Merge applayer detect function into normal match function. Should speed up detection.
17 years ago
Victor Julien
bcd0682150
Make engine startup a little less verbose.
17 years ago
Jason Ish
5076452707
Potential fix for issue 60.
...
- Increase the packet buffer so it can hold the link header when we
have maximum size IP datagrams.
- Fix ip header length and pkt length calculation for re-assembled
packets.
17 years ago
Victor Julien
9d3a9273dd
Rename fmem_t to SCFmem and make sure it's not exported.
17 years ago
Pablo Rincon
673afeb4d3
fmemopen wrapper added (fix compilation problems on macosx and freebsd)
17 years ago
Victor Julien
42e8a01221
Make sure pcre PCRE_EXTRA_MATCH_LIMIT_RECURSION check works with strict compiler settings.
17 years ago
William Metcalf
5bde121754
--enable-gccprofile sets -pg flag detect presence of pcre recursion
17 years ago
Eric Leblond
db2d483d11
convert action_type to enum
...
This patch converts packet action type to an enum. This will
provide some facilities and ease bad value detection by gcc.
17 years ago
Gerardo Iglesias Galvan
f5743afed5
Fix logging messages related to icmp_id parsing
17 years ago
Gerardo Iglesias Galvan
4b39ddaf95
Fix logging messages related to icmp_id parsing
17 years ago
Breno Silva
1d055b0e09
ICMP Seq Rule Keyword
17 years ago
Victor Julien
34e11e4784
Fixup unused variable compiler warning in the dce code.
17 years ago
root
ddf5995049
endianness handling update
17 years ago
Kirby Kuehl
3d59f40640
style patch
17 years ago
root
706bb95209
fix bug 61
17 years ago
Jason Ish
7aac64f262
unit test for issue 59.
17 years ago
Jason Ish
a7b37afc4e
Fix issue 59. Drop a fragment that extends past the maximum IP packet size.
17 years ago
Gurvinder Singh
fea277b2aa
memory leak fixes
17 years ago
Gurvinder Singh
5c8d90afc8
memory leak fixes
17 years ago
Gurvinder Singh
66cc392177
init b46
17 years ago
Kirby Kuehl
90b42232fa
dcerpc request smb transact and fix for dcerpc bindack
17 years ago
Gurvinder Singh
8f00718b0d
bug 57
17 years ago
Eric Leblond
51be576a30
nfq: modify queue length computation logic
...
This patch modifies max queue length computation logic. The max queue
length was set to MAX_PENDING which is the total number of packet
processed simultaneously in suricata.
This value is correct but this will not permit to take all burst
effects into account (read sudden quantity of packet that arrives
faster than suricata is enable to parse). Furthermore there is a
delaying system when suricata gets overloaded which make necessary
to have packet storable into kernel for some time.
To improve this situation the patch increases the maximum queue
length to NFQ_BURST_FACTOR (4) time the MAX_PENDING packet and
it also increase the nfnetlink buffer size to be able to store
all packets waiting for suricata in the netlink receive buffer.
17 years ago
Eric Leblond
775ac9ad9d
fix code file permission
...
detect-http-method.c was executable.
17 years ago
Eric Leblond
84dfc0172a
gcc warning fixes.
...
This patch fixes gcc warning:
warning: suggest braces around empty body in an ‘if’ statement
This was the case in when the macro SCLogDebug was used:
if (ssn != NULL)
SCLogDebug("ssn->alproto %"PRIu16"", ssn->alproto);
It also fixes a signed-unsigned comparison.
17 years ago
Eric Leblond
72d48f6658
nfq: add sanity checking
...
This patch adds sanity checking to payload handling. It set length
of packet to zero if an error occurs.
17 years ago
Eric Leblond
56cccdfa62
nfq: use switch instead of 'else if'
...
This patch convert a 'else if' serie to a switch to increase
the readability of the decision related code.
Please enter the commit message for your changes. Lines starting
17 years ago
Eric Leblond
c96586446b
ethernet: use switch instead of 'else if'
...
This patch uses a switch instead of a 'else if' series. It also
adds a debug message for unsupported ethernet type.
17 years ago
Eric Leblond
6cf00d6204
Fix typo in Makefile.am
...
This patch fixes a typo in Makefile.am which was preventing
'make tags' from working.
17 years ago
Victor Julien
9295193968
Fixup unittest error output for RAW decoder.
17 years ago
William Metcalf
c5d0b492d3
small unittest fixes to decode-raw.c
17 years ago
William Metcalf
8a64321340
raw pcap support additionl ipv4/6 validation
17 years ago
Pablo Rincon
0c9f51498a
Small fixes at unittest helper functions and TestBidirec03
17 years ago
Pablo Rincon
c80160b96d
More examples of unittest helper functions usage reference
17 years ago
Pablo Rincon
b6a3395c08
Adding unittest helper functions for building generic packets, checking arrays of expected match results, perform generic tests, etc. Look at util-unittest-helper.c and detect-ipproto.c for references
17 years ago
Jason Ish
095f2cf6ef
Consistency fix.. Xxxlog -> XxxLog.
17 years ago
Jason Ish
e204d07717
Have output modules register themselves so run mode configurator becomes aware of them for purposes of being configured from the config file.
17 years ago
Victor Julien
9b90c553b5
Clean ip fields from packet as well when the packet is reused. Prevents issues with malformed packets that are rejected by the decoders before ipaddresses are set.
17 years ago