112 Commits (c4cf062a6f35bdfc34f4b6534cbf4dacaf31705d)

Author	SHA1	Message	Date
Jason Ish	3044565cf4	rust/clippy: fix lint: needless_range_loop	4 years ago
Jason Ish	359d5fcb7e	rust/clippy: fix lint: needless_lifetimes	4 years ago
Jason Ish	f15ffbc869	rust/clippy: fix lint: single_match ... Allow this lint in some cases where a match statement adds clarity.	4 years ago
Jason Ish	35f99d1af7	rust/http2: fix clippy lint for is_empty() ... This snuck through as "cargo clippy" check wasn't finding lints that were fixed by the previous test for fixable lints.	4 years ago
Philippe Antoine	086b28da3d	http2: fix decompression buffering ... It was not enough to set Cursor position to 0, also its inner Vec should be cleared. This way, a new input gets written at the beginning of the Cursor and its inner Vec... Ticket: #5691	4 years ago
Philippe Antoine	c6349d3cfc	http2: support padded data frames ... Ticket: #5691	4 years ago
Philippe Antoine	bc287018e5	rust: cargo clippy --all-features --fix --allow-no-vcs	4 years ago
Gabriel Lima Luz	4e90d17fd9	rust: fix lint warnings about if same then else ... Ticket: 4609	4 years ago
Jason Ish	04f0ee0151	rust: fix clippy lints for clippy::unnecessary_cast	4 years ago
Jason Ish	b6cc0e25b1	rust: fix clippy lints for clippy::redundant_static_lifetimes	4 years ago
Jason Ish	119e02cf81	rust: fix clippy lints for clippy::collapsible_if	4 years ago
Jason Ish	572505870a	rust: fix clippy lints for clippy::collapsible_else_if	4 years ago
Jason Ish	565da0d0af	rust: fix clippy lints for clippy::redundant_field_names	4 years ago
Jason Ish	f342d4aacd	rust: fix clippy lints for clippy::len_zero	4 years ago
Jason Ish	5e5401d3e9	rust: fix clippy lints for clippy::char_lit_as_u8	4 years ago
Jason Ish	29a4a7fddc	rust: fix clippy lints for clippy::assign_op_pattern	4 years ago
Jason Ish	c4034dafa1	rust: fix clippy lints for clippy::derive_partial_eq_without_eq	4 years ago
Jason Ish	74b7522b6a	rust/http2: box decompressor variants ... These variants, in particular the Brotli one can be large at over 2500 bytes which is allocated no matter which decompressor is being used. Gzip comes in at over 500 bytes. Box deflate for consistency.	4 years ago
Haleema Khan	6c922e0b98	rust: fix lint warning for clippy::enum's name ... Ticket: #4597	4 years ago
Jason Ish	7d623f0854	rust: fix clippy lint for explicit_auto_deref ... This adds unnecessary complexity to code.	4 years ago
Jason Ish	c5b26e2043	rust: fix clippy ling for needless borrows ... Cleanup needless borrows found by clippy. This fix done automatically by `cargo clippy --fix`.	4 years ago
Victor Julien	db0f9ddc69	files/tx: inspection, logging and loop optimizations ... Introduce AppLayerTxData::file_tx as direction(s) indicator for transactions. When set to 0, its not a file tx and it will not be considered for file inspection, logging and housekeeping tasks. Various tx loop optimizations in housekeeping and output. Update the "file capable" app-layers to set the fields based on their directional file support as well as on the traffic.	4 years ago
Victor Julien	79499e4769	app-layer: move files into transactions ... Update APIs to store files in transactions instead of the per flow state. Goal is to avoid the overhead of matching up files and transactions in cases where there are many of both. Update all protocol implementations to support this. Update file logging logic to account for having files in transactions. Instead of it acting separately on file containers, it is now tied into the transaction logging. Update the filestore keyword to consider a match if filestore output not enabled.	4 years ago
Victor Julien	c27df6304d	app-layer: introduce common AppLayerStateData API ... Add per state structure for storing flags and other variables.	4 years ago
Jeff Lucovsky	484c34bc60	detect/uint: Move uint logic into a separate module ... This commit moves the uint logic into its own module.	4 years ago
Jeff Lucovsky	8bfe427a74	rust/detect: Create detect module for rule parsing ... This commit creates a module named "detect" for rule parsing logic. As part of this commit, detect.rs is moved from its toplevel position into the new module. Thus, use crate::detect::detect to refer to items within detect.rs (instead of create::detect). Ticket: 5077	4 years ago
Philippe Antoine	9b4a133777	http2: remove to_vec for comparisons ... Ticket: #5454	4 years ago
Philippe Antoine	d011b468da	http2: fix clippy warning about &Vec<u8> ... Using &[u8] instead in function prototype	4 years ago
Philippe Antoine	f29b43defd	detect: rust generic functions for integers ... Move it away from http2 to generic core crate. And use it for DCERPC (and SMB) And remove the C version. Main change in API is the free function is not free itself, but a rust wrapper around unbox. Ticket: #4112	4 years ago
Juliana Fajardini	6ccc01a79c	rust: fix doc comments that trigger rust warnings ... Rust generates warnings that are treated as errors for documentation blocks before `extern` blocks.	4 years ago
Jason Ish	2db84726ad	http2: convert transaction list to vecdeque ... Allows for more efficient removal from front of the list. Ticket: #5296	4 years ago
Jason Ish	7b11b4d3a1	app-layer: more generic state trait ... Instead of a method that is required to return a slice of transactions, use 2 methods, one to return the number of transactions in the collection, and another to get a transaction by its index in the collection. This allows for the transaction collection to not be a contiguous array and instead can be a VecDeque, or possibly another collection type that supports retrieval by index. Ticket #5278	4 years ago
Victor Julien	6d30f4442c	http2: fix file accounting for ranged files ... Increment files_opened for tx that 'gets' reassembled ranged file	4 years ago
Philippe Antoine	bfcd6cb46a	range: validity check when end is bigger than size ... Ticket: 5132 Down the line, HttpRangeOpenFileAux assumes the range has a valid value when doing buflen = end - start + 1;	4 years ago
Philippe Antoine	4f90d4254e	http2: makes some settings configurable ... max-streams and max-table-size Allows users to find balance between completeness of decoding and increases resource consumption, which can DOS suricata.	5 years ago
Philippe Antoine	5475212f21	http2: limits the number of active transactions per flow ... Ticket: 4530 So, that we do not get DOS by quadratic complexity, while looking for a new stream id over the ever growing list of active streams	5 years ago
Philippe Antoine	df2cbd6517	http2: event for variable-length integer overflow ... http2_parse_var_uint can overflow the variable-length integer it is decoding. In this case, it now returns an error of kind LengthValue. The new function http2_parse_headers_blocks, which factorizes the code loop for headers, push promise, and continuation, will check for this specific error, and instead of erroring itself, will return the list of so far parsed headers, plus another one with HTTP2HeaderDecodeStatus::HTTP2HeaderDecodeIntegerOverflow This status is then checked by process_headers to create an app-layer event.	5 years ago
Philippe Antoine	b86beb9b68	http2: check overflow before it happens ... instead of checking afterwards if value got smaller	5 years ago
Pierre Chifflier	c61cbd9b35	rust: simplify bits parser annotations	5 years ago
Victor Julien	e6f49e5a05	app/frames: implement name to id API for frames	5 years ago
Pierre Chifflier	3e19ccdc0c	rust/http2: convert parser to nom7 functions (HTTP2 ranges)	5 years ago
Pierre Chifflier	f8647b0ffb	rust/http2: convert parser to nom7 functions (HTTP2 core functions)	5 years ago
Jason Ish	50fdcd098c	rust/http2: use base64 crate for base64 decode	5 years ago
Victor Julien	c073d5cfbf	app-layer: use StreamSlice as input to parsers ... Remove input, input_len and flags in favor of stream slice.	5 years ago
Victor Julien	6466296b32	app-layer: add StreamSlice to pass data to parsers ... Since object to contain relevant pointer, length, offset, flags to make it easy to pass these to the parsers.	5 years ago
Jason Ish	7732efbec2	app-layer: include decoder events in app-layer tx data ... As most parsers use an events structure we can include it in the tx_data structure to reduce some boilerplate/housekeeping code in app-layer parsers.	5 years ago
Philippe Antoine	0caaf6bd23	range: prevents memory leak of file from HTTP2 ... Ticket: 4811 Completes commit c023116857 state.free should also close files with ranges as state.free_tx did already And file_range field should be reset so that there is no use after free.	5 years ago
Philippe Antoine	c023116857	range: prevents memory leak of file from HTTP2 ... If a HTTP2 transaction gets freed before the end of the range request, we need to have the files container which is in the state, to transfer owernship of this file to the files container. Ticket: 4811	5 years ago
Jason Ish	9c67c634c1	app-layer: include DetectEngineState in AppLayerTxData ... Every transaction has an existing mandatory field, tx_data. As DetectEngineState is also mandatory, include it in tx_data. This allows us to remove the boilerplate every app-layer has for managing detect engine state.	5 years ago
Jason Ish	54e62ddf71	http2: use generic tx iterator	5 years ago