217 Commits (b42eea67d5effe5bc6194877d23c9fdf060214eb)

Author	SHA1	Message	Date
Victor Julien	add7d3fcf5	app-layer: API for mapping progress name vs id	5 months ago
Philippe Antoine	857efdde62	rust: fix clippy warnings doc_overindented_list_items ... warning: doc list item overindented --> src/nfs/rpc_records.rs:284:5 | 284 | /// type: bool | ^^^^^^^^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items = note: `#[warn(clippy::doc_overindented_list_items)]` on by default	5 months ago
Jason Ish	77b94b8713	rust: fixes for breaking change on deranged crate ... Deranged v0.4.1 (a dependency of the time crate) has implemented PartialOrd for some integer types that conflict with the implementation in the standard library creating an ambiguity as such implementation are global. For more info see https://github.com/jhpratt/deranged/issues/18. To fix, use "::from" directly, instead of using .into() which is where we run into amgibuity.	5 months ago
Jason Ish	4554c4778d	rust: use AppProto from generated bindings instead of duplicating ... Have bindgen generate bindings for app-layer-protos.h, then use the generated definitions of AppProto/AppProtoEnum instead if defining them ourselves. This header was chosen as its used by Rust, and its a simple header with no circular dependencies. Ticket: #7341	7 months ago
Jason Ish	f62be374ea	rust/direction: move direction to own file (cleanup) ... Move the implementation of Direction to its own file, direction.rs.	8 months ago
Jason Ish	7ef4caf90e	rust/flow: move flow support to its own file (cleanup) ... Move the Rust Flow support from core.rs to flow.rs.	8 months ago
Philippe Antoine	af4e1e8888	rust: remove unneeded mut for tx in loggers ... Loggers do not change transactions, they read only.	8 months ago
Philippe Antoine	b02557ac7d	app-layer: track modified/processed txs ... To optimize detection, and logging, to avoid going through all the live transactions when only a few were modified. Two boolean fields are added to the tx data: updated_tc and ts The app-layer parsers are now responsible to set these when needed, and the logging and detection uses them to skip transactions that were not updated. There may some more optimization remaining by when we set both updated_tc and updated_ts in functions returning a mutable transaction, by checking if all the callers are called in one direction only (request or response) Ticket: 7087	9 months ago
Shivani Bhardwaj	f2de3e01cb	src: remove truncate fn and glue code ... truncate fn is only active and used by dcerpc and smb parsers. In case stream depth is reached for any side, truncate fn is supposed to set the tx entity (request/response) in the same direction as complete so the other side is not forever waiting for data. However, whether the stream depth is reached is already checked by AppLayerParserGetStateProgress fn which is called by: - DetectTx - DetectEngineInspectBufferGeneric - AppLayerParserSetTransactionInspectId - OutputTxLog - AppLayerParserTransactionsCleanup and, in such a case, StateGetProgressCompletionStatus is returned for the respective direction. This fn following efc9a7a, always returns 1 as long as the direction is valid meaning that the progress for the current direction is marked complete. So, there is no need for the additional callback to mark the entities as done in case of depth or a gap. Remove all such glue code and callbacks for truncate fns. Bug 7044	1 year ago
Philippe Antoine	0d267e29a5	files: remove the need for state in callbacks ... As files now belong to transactions	1 year ago
Jason Ish	2e440169d6	lua: remove lua as a compile time feature ... Its always built-in. However, can be disabled at runtime.	1 year ago
Philippe Antoine	37a9003736	rust/probing: safety check for null input ... Ticket: 7013 Done consistently for all protocols This may change some protocols behaviors which failed early if they found there was not enough data...	1 year ago
Philippe Antoine	715bf048ee	frames: rust API makes tx_id explicit ... And set it right for SIP and websocket, so that relevant tx app-layer metadata gets logged. Ticket: 6973	1 year ago
Philippe Antoine	68b0052018	rust: fix clippy ptr_arg warnings ... error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/dns/log.rs:371:29 | 371 | pub fn dns_print_addr(addr: &Vec<u8>) -> std::string::String { | ^^^^^^^^ help: change this to: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg	2 years ago
Philippe Antoine	38db51b878	rust: make cargo clippy clean ... Fixing single_match and manual_find intertwined with SCLogDebug	2 years ago
Philippe Antoine	259cdf169e	rust: fix single_binding ... error: this match could be written as a `let` statement --> src/nfs/nfs3_records.rs:747:9 | 747 | / match result { 748 | | (r, request) => { 749 | | assert_eq!(r.len(), 0); 750 | | assert_eq!(request.handle, expected_handle); 751 | | assert_eq!(request.name_vec, br#"bln"#); 752 | | } 753 | | } | |_________^	2 years ago
Daniel Olatunji	5c0af0b203	rust/doc: add docstring to rust module files. ... Issue: #4584	2 years ago
Victor Julien	389f166d78	file: remove FILE_USE_DETECT flag ... All implementations were converted to use the logic, so the flag itself can be removed.	2 years ago
Philippe Antoine	668501c225	rust: remove unused	2 years ago
Jason Ish	13fe957b7e	rust/doc: wrap some code examples in backticks	2 years ago
Victor Julien	ee7ed99b6f	rust: spelling	2 years ago
Jason Ish	d2fb958e28	rust: fix clippy lint for assert ... Fix done automatically by clippy --fix	2 years ago
Victor Julien	0bbc411743	nfs: fix newline in debug messages	2 years ago
Eric Leblond	8b0d56c414	nfs: TX are not unidirectional ... NFS transactions are not unidirectional so we should not declare them as such.	2 years ago
Jason Ish	64cb687a65	rust: suppress specific manual_flatten list ... In this case of debug code, the explicit iterator seems to make more sense.	3 years ago
Jason Ish	7080ecbb76	rust: remove explicit lifetimes where not needed	3 years ago
Jason Ish	e7f5bd047d	rust: fix needless borrows of references ... Fixed automatically by cargo clippy --fix.	3 years ago
Victor Julien	6cc9811edd	files: move FileContainer into FileTransferTracker ... Update SMB, NFS, HTTP2.	3 years ago
Victor Julien	e3e55406a7	files: update API and callers to take stream config ... This is to allow not storing the stream buffer config in each file.	3 years ago
Victor Julien	71bc9e75f5	app-layer: get sbconfg with files	3 years ago
Victor Julien	3a24cce289	nfs: explicity free files ... In preparation of adding an argument to the free functions which means the drop trait can't be used anymore.	3 years ago
Victor Julien	4bfeac6591	nfs: file handling cleanups	3 years ago
Jason Ish	da12b77f18	rust/clippy: fix lint: new_without_default	3 years ago
Jason Ish	c4cf062a6f	rust/clippy: fix lint: redundant_pattern_matching	3 years ago
Jason Ish	f250b92180	rust/clippy: fix lint: extra_unused_lifetimes	3 years ago
Jason Ish	c026d8531b	rust/clippy: fix lint: match_ref_pats	3 years ago
Jason Ish	359d5fcb7e	rust/clippy: fix lint: needless_lifetimes	3 years ago
Jason Ish	f15ffbc869	rust/clippy: fix lint: single_match ... Allow this lint in some cases where a match statement adds clarity.	3 years ago
Philippe Antoine	bc287018e5	rust: cargo clippy --all-features --fix --allow-no-vcs	3 years ago
Gabriel Lima Luz	4e90d17fd9	rust: fix lint warnings about if same then else ... Ticket: 4609	3 years ago
Kristina Jefferson	9cd00424c3	rust: fix lint warnings about ptr_arg ... Ticket: #4599	3 years ago
Jason Ish	f0952aef0d	rust: fix clippy lints for unneeded reference in debug code	3 years ago
Jason Ish	6a7439a26b	rust: fix clippy lints for is_empty in debug code	3 years ago
Jason Ish	6db85d6f89	rust: clippy fix for bitwise or with 0	3 years ago
Jason Ish	04f0ee0151	rust: fix clippy lints for clippy::unnecessary_cast	3 years ago
Jason Ish	b6cc0e25b1	rust: fix clippy lints for clippy::redundant_static_lifetimes	3 years ago
Jason Ish	6b71d69356	rust: fix clippy lints for clippy::bool_comparison	3 years ago
Jason Ish	5f7ba03e63	rust: fix clippy lints for clippy::needless_bool	3 years ago
Jason Ish	f342d4aacd	rust: fix clippy lints for clippy::len_zero	3 years ago
Jason Ish	c4034dafa1	rust: fix clippy lints for clippy::derive_partial_eq_without_eq	3 years ago