Victor Julien
							
						 
						
							 
							
							
							
								
							
								6ee818cb3e 
								
							
								 
							
						 
						
							
							
								
								stream/reassembly: ignore min_inspect_depth on TCP state CLOSED  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								55202f826a 
								
							
								 
							
						 
						
							
							
								
								detect/http: don't set min-inspect-depth higher than setting  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								27dd0c6b3d 
								
							
								 
							
						 
						
							
							
								
								eve/ftp-data: log alert metadata in ftp-data object  
							
							 
							
							... 
							
							
							
							Ticket: 4860
instead of directly in root 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								87d9c44ec5 
								
							
								 
							
						 
						
							
							
								
								rust: export constants via cbindgen  
							
							 
							
							... 
							
							
							
							so that constants are not defined twice in Rust anc C
So that we are sure they have the same value 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								784558df2e 
								
							
								 
							
						 
						
							
							
								
								mime: handles multiple sections for a parameter  
							
							 
							
							... 
							
							
							
							Ticket: 4386
as per RFC2231.
For instance filename can be split between filename*0,
filename*1, etc... 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								8feb9c35ae 
								
							
								 
							
						 
						
							
							
								
								mime: move FindMimeHeaderTokenRestrict to rust  
							
							 
							
							... 
							
							
							
							Also fixes the case where the token name is present
in a value 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Modupe Falodun
							
						 
						
							 
							
							
							
								
							
								76131c8cff 
								
							
								 
							
						 
						
							
							
								
								detect-ipopts: convert unittests to FAIL/PASS APIs  
							
							 
							
							... 
							
							
							
							Bug: 4047 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								1b10848d84 
								
							
								 
							
						 
						
							
							
								
								mqtt: fix transaction completion  
							
							 
							
							... 
							
							
							
							Ticket: 4862
A transaction to client is always considered
complete in the direction to server and vice versa.
Otherwise, transactions are never complete for
AppLayerParserTransactionsCleanup 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								ecce116117 
								
							
								 
							
						 
						
							
							
								
								detect/fast_pattern: allow for rule time registration  
							
							 
							
							... 
							
							
							
							In preparation of more dynamic logic in rule loading also doing
some registration, allow for buffers to be registered as fast_patterns
during rule parsing.
Leaves the register time registrations mostly as-is, but copies the
resulting list into the DetectEngineCtx and works with that onwards.
This list can then be extended. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								db27244379 
								
							
								 
							
						 
						
							
							
								
								detect: add buffer helper functions  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								707b75ccda 
								
							
								 
							
						 
						
							
							
								
								detect: split register time and detect load time buffer funcs  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								5bcaae0a01 
								
							
								 
							
						 
						
							
							
								
								detect: use hashes for all buffer to id  
							
							 
							
							... 
							
							
							
							Instead of a map that is constantly realloc'd, use 2 hash tables for
DetectBufferType entries: one by name (+transforms), the other by
id. Use these everywhere. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								51dcf3d76a 
								
							
								 
							
						 
						
							
							
								
								detect: increase SigMatch type from u8 to u16  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								bb3d49d5bf 
								
							
								 
							
						 
						
							
							
								
								detect: use bool for uint16_t used as bool  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								6d7c1519ed 
								
							
								 
							
						 
						
							
							
								
								common: fix missing ; in header  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								c9d222a483 
								
							
								 
							
						 
						
							
							
								
								detect: allows <> syntax for uint ranges  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								5af4ef4532 
								
							
								 
							
						 
						
							
							
								
								detect: use prefilter values for modes  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								3f15b2492c 
								
							
								 
							
						 
						
							
							
								
								detect: errors for rule with impossible conditions  
							
							 
							
							... 
							
							
							
							Such as >255 for an uint8 field 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Juliana Fajardini
							
						 
						
							 
							
							
							
								
							
								7c636d25c7 
								
							
								 
							
						 
						
							
							
								
								userguide: (nit) fix typo in lua-output page  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Juliana Fajardini
							
						 
						
							 
							
							
							
								
							
								4256c1ccd5 
								
							
								 
							
						 
						
							
							
								
								userguide: rename pg Lua Scripting->Lua Detection  
							
							 
							
							... 
							
							
							
							Since we can have scripts for output _or_ detection, it seems more
clear to rename this page to add more meaning 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Juliana Fajardini
							
						 
						
							 
							
							
							
								
							
								59e5a21fca 
								
							
								 
							
						 
						
							
							
								
								userguide: update buffers list for lua-scripting  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Juliana Fajardini
							
						 
						
							 
							
							
							
								
							
								e7f1736f3a 
								
							
								 
							
						 
						
							
							
								
								userguide/lua: add explanation about `need` diffs  
							
							 
							
							... 
							
							
							
							The differences on how the `need` key works, depending on script
usage (output or detection) confuses users, sometimes (cf doc#4725).
While we don't fix that, just explain this behavior. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								f4449d3fb3 
								
							
								 
							
						 
						
							
							
								
								fuzz: restrict flags passed to AppLayerProtoDetectGetProto  
							
							 
							
							... 
							
							
							
							Completes commit 05f9b3ffc6 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								7732efbec2 
								
							
								 
							
						 
						
							
							
								
								app-layer: include decoder events in app-layer tx data  
							
							 
							
							... 
							
							
							
							As most parsers use an events structure we can include it in the
tx_data structure to reduce some boilerplate/housekeeping code
in app-layer parsers. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								0caaf6bd23 
								
							
								 
							
						 
						
							
							
								
								range: prevents memory leak of file from HTTP2  
							
							 
							
							... 
							
							
							
							Ticket: 4811
Completes commit c023116857 
state.free should also close files with ranges
as state.free_tx did already
And file_range field should be reset so that there is no
use after free. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								86f5d33f75 
								
							
								 
							
						 
						
							
							
								
								enip: fix int warnings  
							
							 
							
							... 
							
							
							
							There seems to fix a real bug when an ENIP connection
has more than 65k transactions 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								86b5c81ea2 
								
							
								 
							
						 
						
							
							
								
								dnp3: fix int warnings  
							
							 
							
							... 
							
							
							
							There is a hack to know the type of an integer
and do an explicit cast in the python script
generating the C file
Also extends some bounds check against negative values 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								53fc70a9a7 
								
							
								 
							
						 
						
							
							
								
								protodetect: fix int warnings  
							
							 
							
							... 
							
							
							
							There is actually a real evasion with AppLayerProtoDetectPMGetProto
using u16 instead of u32 for buflen 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								743fb12aa8 
								
							
								 
							
						 
						
							
							
								
								ci: adds default warning flag about float conversions  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								46981ccd98 
								
							
								 
							
						 
						
							
							
								
								warning: explicit casts to double  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								b88f015bfb 
								
							
								 
							
						 
						
							
							
								
								source/pcap: remove unused code  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Philippe Antoine
							
						 
						
							 
							
							
							
								
							
								05f9b3ffc6 
								
							
								 
							
						 
						
							
							
								
								fuzz: restrict flags passed to AppLayerProtoDetectGetProto  
							
							 
							
							... 
							
							
							
							So that rust does not panic with an unhandled value 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								39bf623fdd 
								
							
								 
							
						 
						
							
							
								
								af-packet: add send error counter  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								373278438d 
								
							
								 
							
						 
						
							
							
								
								packetpool: ReleasePacket callback check on getter  
							
							 
							
							... 
							
							
							
							Any packet coming from the pool should have `PacketPoolReturnPacket`
as its callback. Check that this is the case. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								8a5b945c7b 
								
							
								 
							
						 
						
							
							
								
								af-packet: only ref mpeer if needed in tpacket v2  
							
							 
							
							... 
							
							
							
							We only use it in autofp mode, for reference counting purposes.
Removes 2 atomic operations per packet in the more common workers
runmode. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								d272075da0 
								
							
								 
							
						 
						
							
							
								
								af-packet: minor output updates  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								e9c6ad19b3 
								
							
								 
							
						 
						
							
							
								
								af-packet: optimize packet setup  
							
							 
							
							... 
							
							
							
							Don't set fields we don't use in V3. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								cad0ff9ebb 
								
							
								 
							
						 
						
							
							
								
								af-packet: add counters on how poll() works  
							
							 
							
							... 
							
							
							
							Use `capture.afpacket.*` counter name space. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								c7ad3f8d30 
								
							
								 
							
						 
						
							
							
								
								af-packet: don't check ifstate per send call in IPS  
							
							 
							
							... 
							
							
							
							Instead just accept that the socket state leads to `sendto` errors.
So print at most one error per socket. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								dab036727f 
								
							
								 
							
						 
						
							
							
								
								af-packet: simplify AFPWritePacket  
							
							 
							
							... 
							
							
							
							Since return code was ignored by all callers, we can just turn it into a
void function and slightly simplify the logic. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								3f79f452ad 
								
							
								 
							
						 
						
							
							
								
								af-packet: use BUG_ON for 'impossible' condition  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								2fab3ff0e8 
								
							
								 
							
						 
						
							
							
								
								af-packet: refactor VLAN hdr handling  
							
							 
							
							... 
							
							
							
							Update the packet payload after decode, instead of during IPS send.
This means the updates happen in the capture thread, and the VLAN header
is available to logging as well.
Ticket: #4805 . 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Victor Julien
							
						 
						
							 
							
							
							
								
							
								b9189946f9 
								
							
								 
							
						 
						
							
							
								
								af-packet: remove tpacket-v1 support  
							
							 
							
							... 
							
							
							
							Ticket: #4796 .
V2 (for IDS and IPS) and V3 (for IDS) are widely supported. V2 was introduced
in 2008, so we can safely assume that all systems can run V2+. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Jason Ish
							
						 
						
							 
							
							
							
								
							
								1f6a15cdf3 
								
							
								 
							
						 
						
							
							
								
								app-layer/template: don't always enable if unittests built  
							
							 
							
							... 
							
							
							
							314ec77f88  had the unintended side affect
of enabling the template parser and detection buffer if unittests were
enabled.
Fix this by using the new `Default` method for registering parsers.
However, the buffer still needs an explicit configuration check.
Also convert Notice debug messages to Debug to reduce output when in
unittest mode.  If we feel stronly this should still be Notice in the
template, that is a conversion we can make in the generation script when
generating a new parser. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Jeff Lucovsky
							
						 
						
							 
							
							
							
								
							
								6a470a84e7 
								
							
								 
							
						 
						
							
							
								
								tftp: Change references to echo  
							
							 
							
							... 
							
							
							
							This commit changes the references to the "echo" protocol to tftp. The
references to echo are part of the template parser code. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Jeff Lucovsky
							
						 
						
							 
							
							
							
								
							
								23faeaea5c 
								
							
								 
							
						 
						
							
							
								
								ftp: Remove diagnostic print  
							
							 
							
							... 
							
							
							
							This commit removes a diagnostic message displayed during extraction of
the EPSV port. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Jeff Lucovsky
							
						 
						
							 
							
							
							
								
							
								ca7d097225 
								
							
								 
							
						 
						
							
							
								
								netmap: V14 API changes  
							
							 
							
							... 
							
							
							
							This commit modifies the Netmap packet handling to use API version 14.
@bmeeks8 contributed many changes instrumental to this effort. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Jeff Lucovsky
							
						 
						
							 
							
							
							
								
							
								3496e543af 
								
							
								 
							
						 
						
							
							
								
								util: Add sys/ioctl.h to common include  
							
							 
							
							... 
							
							
							
							This commit adds another system include file based on autoconf to the
common Suricata include file for convenience. 
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Jeff Lucovsky
							
						 
						
							 
							
							
							
								
							
								84ee01dbe9 
								
							
								 
							
						 
						
							
							
								
								util/log: Include device name with thread count  
							
							 
							
							
							
						 
						
							4 years ago  
						
					 
				
					
						
							
							
								 
								Jeff Lucovsky
							
						 
						
							 
							
							
							
								
							
								1c1c21be9e 
								
							
								 
							
						 
						
							
							
								
								config/netmap: Check for latest API version  
							
							 
							
							... 
							
							
							
							This commit checks for the latest Netmap API version. 
							
						 
						
							4 years ago