Victor Julien
e9b067c1eb
counters: make increment call take threadvars
...
This hides the implementation from the caller.
10 years ago
Victor Julien
9a8bff7d96
counters: threadvars s/sc_perf_pca/perf_private_ctx/g
10 years ago
Victor Julien
50bb995458
counters: rename threadvars public counters
10 years ago
Victor Julien
6ffbc3a362
counters: s/SCPerfContext/SCPerfPublicContext/g
10 years ago
Victor Julien
0a5ae1b403
counters: s/SCPerfCounterArray/SCPerfPrivateContext/g
...
Goal is to make it's purpose clear.
10 years ago
Victor Julien
9f584483be
counters: minor cleanups
10 years ago
Victor Julien
fb479902e4
threading: explain purpose of threadvars mucond
10 years ago
Victor Julien
bc2c7f462e
stats api: call thread deinit API functions
...
Thread deinit funcs weren't called. This meant the lua scripts 'deinit'
functions weren't called either.
11 years ago
Victor Julien
8b2dd81628
stats: stats threads don't need packet pools
11 years ago
Victor Julien
51a540c27e
stats: disable stats if no loggers are enabled
11 years ago
Victor Julien
a95c95f74c
stats: introduce global config
...
As the stats api calls the loggers at a global interval, the global
interval should be configured globally.
# global stats configuration
stats:
enabled: yes
# The interval field (in seconds) controls at what interval
# the loggers are invoked.
interval: 8
If this config isn't found, the old config will be supported.
11 years ago
Victor Julien
e98346b555
Introduce stats log API, convert existing output
...
Convert regular 'stats.log' output to this new API.
In addition to the current stats value, also give the last value. This
makes it easy to display the difference.
11 years ago
Ken Steele
28ccea51d3
Add error checking for pthread_setspecific() and pthread_key_create().
11 years ago
Jason Ish
fc2014ab40
Unregister for file rotation notification when a context is
...
de-initialized. Required for unix-socket mode where
contexts come and go.
11 years ago
Jason Ish
e1b97fed70
Add signal based file rotation for:
...
- alert debug log
- fast log
- stats log
- dns log
- drop log
- file log
- http log
- tls log
- eve/json log
11 years ago
Victor Julien
399246881d
counters: fix 2 scan-build warnings
...
counters.c:1069:13: warning: Potential leak of memory pointed to by 'temp'
SCMutexUnlock(&sc_perf_op_ctx->pctmi_lock);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./threads.h:121:28: note: expanded from macro 'SCMutexUnlock'
^~~~~~~~~~~~~~~~~~~~
counters.c:1156:16: warning: Potential leak of memory pointed to by 'pca'
return NULL;
^~~~
/usr/include/clang/3.3/include/stddef.h:77:24: note: expanded from macro 'NULL'
^
2 warnings generated.
12 years ago
Eric Leblond
1f07d1521e
Fix realloc error handling
...
This patch is fixing realloc error handling. In case of a realloc
failure, it free the initial memory and continue existing error
handling.
The patch has been obtained via the following semantic patch and
a bit oh hand editing:
@@
expression x, E;
identifier f;
@@
f(...)
{
+ void *ptmp;
<+...
- x = SCRealloc(x, E);
+ ptmp = SCRealloc(x, E);
... when != x
- if (x == NULL)
+ if (ptmp == NULL)
{
+ SCFree(x);
+ x = NULL;
...
- }
+ } else {
+ x = ptmp;
+ }
...+>
}
@@
expression x, E;
identifier f;
statement ES;
@@
f(...) {
+ void *ptmp;
<+...
- x = SCRealloc(x, E);
+ ptmp = SCRealloc(x, E);
... when != x
- if (x == NULL) ES
+ if (ptmp == NULL) {
+ SCFree(x);
+ x = NULL;
+ ES
+ } else {
+ x = ptmp;
+ }
...+>
}
@@
expression x, E;
identifier f;
@@
f(...)
{
+ void *ptmp;
<+...
- x = SCRealloc(x, E);
+ ptmp = SCRealloc(x, E);
... when != x
- if (unlikely(x == NULL))
+ if (unlikely(ptmp == NULL))
{
+ SCFree(x);
+ x = NULL;
...
- }
+ } else {
+ x = ptmp;
+ }
...+>
}
@@
expression x, E;
identifier f;
statement ES;
@@
f(...) {
+ void *ptmp;
<+...
- x = SCRealloc(x, E);
+ ptmp = SCRealloc(x, E);
... when != x
- if (unlikely(x == NULL)) ES
+ if (unlikely(ptmp == NULL)) {
+ SCFree(x);
+ x = NULL;
+ ES
+ } else {
+ x = ptmp;
+ }
...+>
}
12 years ago
Eric Leblond
28c5c68192
error checking: add missing alloc error treatment
...
The return of some malloc like functions was not treated in some
places of the code.
12 years ago
Victor Julien
ed03196a20
Counter: fix accidental logic change
12 years ago
Victor Julien
45dfecafd4
Counters: remove unused updated field
12 years ago
Victor Julien
64f5129f12
Counters: remove unused tm_name comparison loops
12 years ago
Victor Julien
76c305c128
Counters: fix unix socket
12 years ago
Victor Julien
25aeeebdf7
Counters: merge SCPerfCounterName into SCPerfCounter as there was a 1 on 1 mapping
12 years ago
Victor Julien
3445d17ae5
Counters: remove SCPerfCounterValue struct as we no longer support multiple data types
12 years ago
Victor Julien
677cd03e52
Counters: more unused code removal
12 years ago
Victor Julien
8d4a61a789
Counters: remove unused code
12 years ago
Victor Julien
698ff4e4aa
Counters: remove all unused parts of the API
12 years ago
Ken Steele
592d48aab7
Use Spin locks on Tile
...
On Tile, replace pthread_mutex_locks with queued spin locks (ticket
locks) for dataplane processing code. This is safe when running on
dataplane cores with one thread per core. The condition variables are
no-ops when the thread is spinning anyway.
For control plane threads, unix-manager, stats-logs, thread startup,
use pthread_mutex_locks. For these locks replaced SCMutex with SCCtrlMutex
and SCCond with SCCtrlCond.
12 years ago
Victor Julien
3470b07ea5
Fix several compile and runtime warnings found by clang 3.2 with the -fsanitize=address option.
12 years ago
Ken Steele
d4dd18eb85
Clean up SCLocalTime() usage
...
Remove cast of return type from SCLocalTime() as it is not needed.
Replace last use of localtime_r() with SCLocalTime().
12 years ago
Eric Leblond
34abd818dd
Prefix util-conf function with Config
12 years ago
Eric Leblond
54006de40c
Use new function GetLogDirectory()
12 years ago
Eric Leblond
7ec820d3ab
Fix potential Null deref.
13 years ago
Eric Leblond
31c03d38b9
unix socket: add 'dump-counters' command
...
This patch adds a 'dump-counters' command which answer an output of
all performance counter.
13 years ago
Anoop Saldanha
34a9c047fc
updated to fix unix shutdown sequence
...
Should fix crashes occuring from unix mode shutdown/cleanup phase.
13 years ago
Eric Leblond
7b1d346c22
counters: management cpu set was set twice
...
Setting the management CPU set on perf threads is already done in
the TmThreadCreateMgmtThread() function used to create the threads.
13 years ago
Eric Leblond
1b26660ac4
counter: defensive set to NULL in free.
13 years ago
Eric Leblond
d1569337a7
affinity: add call to setup function in threads
...
Threads created through TMThreadSpawn need to call the affinity
function by themselves.
13 years ago
Eric Leblond
0eeccb4b17
affinity: tag management threads as such
...
The management threads were not tagged for CPU affinity and thus
the setting was not applied.
13 years ago
Eric Leblond
0227a87fcb
cleaning: fix warning when building with clang.
...
clang was issuing some warnings related to unused return in function.
This patch adds some needed error treatment and ignore the rest of the
warnings by adding a cast to void.
13 years ago
Anoop Saldanha
31eb5fa2f6
Introduce util-signal.[ch]. Move our signal setup functions here
13 years ago
Anoop Saldanha
ecad4a24fa
live rule support added
...
To reload ruleset during engine runtime, send the USR2 signal to the engine, and the ruleset would be reloaded from the same yaml file supplied at engine startup
13 years ago
Eric Leblond
a0e57f58e5
OpenBSD: introduce SCLocalTime function.
...
This function is a wrapper to localtime_r. It is needed to avoid
a compilation warning on OpenBSD. I'm forced to type the function
to a non pointer first parameter. If not we will have to use two
differents functions in OpenBSD where tv->tv_sec is a long
(different from time_t).
13 years ago
Anoop Saldanha
bff2866aed
more coverity fixes
13 years ago
Anoop Saldanha
081b0e05a2
restructure disabling receive threads. Introduce new flag to indicate that threads have finised running
14 years ago
Victor Julien
8448333bdd
Remove trailing zero's from some counters output.
14 years ago
Anoop Saldanha
420befb180
Changed my email address to anoopsaldanha at gmail dot com from my current one
14 years ago
Victor Julien
1df3304655
Clean up for unittests code: only compile unittest api code when unittests are enabled. Fix unittest code that wasn't wrapped in the proper UNITTESTS ifdefs.
14 years ago
Victor Julien
8186565240
Fix a number of potential issues found by CLANG and cppcheck.
14 years ago
Victor Julien
b39acddf28
Add flow counters: memuse, pruning stats, emergency mode. Bug #348 .
14 years ago