suricata

Commit Graph

Author	SHA1	Message	Date
Jason Ish	81692dd2c1	rust/lua: add method for pushing bytes Much like pushstring, but accepts an &[u8] as an argument instead of an &str. In support of ticket #8533.	6 months ago
Jason Ish	cdb02a2779	rust/dns: rustfmt	6 months ago
Philippe Antoine	7d66eb5f04	rust: remove unused function rust_string_to_c was used when a buffer should be used as it could contain nul-byte	6 months ago
Philippe Antoine	9b12fd9f09	rust/ffi: move helper trait state_get_tx_iterator to ffi Ticket: 7666	6 months ago
Philippe Antoine	07f37676b6	rust/ffi: move Flags for AppLayerParserState to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	fb20c69d8d	rust/ffi: move APP_LAYER_PARSER_OPT_X const to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	d81a10126e	detect/doc: remove unexisting links Ticket: 8257 And add TODO comments if rules doc should be written	6 months ago
Philippe Antoine	8e39539161	detect/doc: fix broken anchor links Ticket: 8257	6 months ago
Philippe Antoine	bd6a436893	detect/doc: fix broken files links Ticket: 8257	6 months ago
Philippe Antoine	b0e63a2c95	detect/dcerpc: move stub_data keyword to rust Ticket: 8391	6 months ago
Jeff Lucovsky	746f471382	transform/subslice: Add subslice transform Issue: 7672 The subslice transform creates a slice of the input buffer. Specify the subslice desired -- nbytes and truncate are optional: subslice: offset <,nbytes> <,truncate> offset: Specifies the starting offset for the new subslice. When negative, expresses how far from the end of the input buffer to begin. nbytes: Specifies the size of the subslice. When negative, specifies that the subslice will end that many bytes from the end of the input buffer. Nbytes must be non-zero. When nbytes is not specified, the size of the subslice will be the size of the input buffer - offset. truncate: Specify behavior when offset + nbytes exceeds buffer length. When present, trims nbytes such that offset + nbytes equals buffer length. When not present, an empty buffer is produced. Examples: subslice: 1; - The subslice will be a copy of the input buffer but omits the input buffer's first byte "This is Suricata" -> "his is Suricata" subslice: 0, 13; - The slice is created from the first 13 bytes of the input buffer "This is Suricata" -> "This is Suric" subslice: 10, -5; - The subslice is created starting at offset 10 and continues to 5 bytes before the end of the input buffer "This is Suricata" -> "r" subslice: -3; - The subslice will be the last 3 bytes of the input buffer. "This is Suricata" -> "ata"	6 months ago
Philippe Antoine	4fc6ca5d6c	detect/dcerpc: move iface keyword to rust Ticket: 8391 Use same buffer dce_generic as for dcerpc.opnum (name dce_generic is enforced by a SV test currently)	6 months ago
Philippe Antoine	9677851637	rust/ffi: move app-layer traits to ffi crate Ticket: 7666 Traits around structures defined in C and bindgened to rust	6 months ago
Philippe Antoine	f803c25f24	rust/ffi: move export_X_data_get macros to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	54b6885166	rust/ffi: move conf_get_bool helper to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	5f9e436c3f	detect/dcerpc: support generic integer for opnum keyword Ticket: 8179	6 months ago
Philippe Antoine	67379b009a	detect/dcerpc: move opnum keyword to rust Ticket: 8391	6 months ago
Jason Ish	fd31e50954	ntp: enable keywords for firewall mode Ticket: #8394	6 months ago
Jason Ish	713e4eb900	ntp: convert reference_id to buffer and add keyword Store the NTP reference ID as raw network-order bytes so it can be exposed as a sticky buffer and matched with payload keywords. The reference ID is often a 4 character string, or an IP address and not just an integer identifier. Updates the log reference ID to be a string of colon separated hex digits as this matches what tshark does. Ticket: #8488	6 months ago
Jason Ish	991e7f3b1d	ntp: add ntp.mode keyword This keyword also accepts strings for known mode names. Ticket: #8429	6 months ago
Jason Ish	c10c482290	ntp: add ntp.stratum keyword Ticket: #8431	6 months ago
Jason Ish	ec344fe68d	ntp: add ntp.version keyword SNMP was used as a template. Ticket: #8430	6 months ago
Jason Ish	74bb525401	ntp: create tx for all modes; log version, mode and stratum Add logging for version, mode and stratum as these will be the first keywords we will add. Ticket: #8425	6 months ago
Jason Ish	879846e153	ntp: remove unused event types NotRequest and NotResponse event type have never been used. Unsolicited is also unused, however there is a rule for it so removing support would be a breaking change at this time.	6 months ago
Jason Ish	31b967b089	ntp: add transaction logging Adds basic NTP transaction logging for the current supported message types. Includes small cleanups around reference ID. Ticket: #8425	6 months ago
Victor Julien	c7cd3b17c3	snmp: minor snmp.pdu_type type cleanup	7 months ago
Victor Julien	2cef1404bc	detect/snmp: let generic keyword share the same list	7 months ago
Victor Julien	670fdabd32	detect/snmp: add snmp.trap_type keyword Implemented as a U8 integer keyword. Ticket: #8482.	7 months ago
Philippe Antoine	8ac9a62ec4	detect: enable snmp keywords for firewall mode Ticket: #8395	7 months ago
Philippe Antoine	63603fe14a	detect/snmp: sticky buffers at progress 1 Since snmp txs are created at progress 1 which is the completion, this does not change detection, except allowing firewall mode to use these keywords with generic hook like snmp:request_complete Ticket: 8395	7 months ago
Philippe Antoine	8f824458c2	detect: helper for buffer register requires progress Ticket: 8395 For protocols where tx are complete at start, that is the `tx_get_progress` function returns 1 inconditionnally, we can use the progress 1, not losing time on detection in ips mode, and getting ready for firewall mode For the other protocols (where a tx needs both a request and response for instance), keep progress 0 as was the case before	7 months ago
Philippe Antoine	58a71d94b0	rust/ffi: move conf_get helper to ffi crate Ticket: 7666	7 months ago
Philippe Antoine	8d254f5630	dhcp/output: log app-layer metadata in alerts Ticket: 6091 log as extended	7 months ago
Philippe Antoine	db980daf5f	dhcp: standardize output code To prepare to add metadata in alerts Ticket: 6091	7 months ago
Philippe Antoine	d14af54b3b	detect/transforms: constify some callbacks arguments Ticket: 8298	7 months ago
Philippe Antoine	0a24f0afe2	smb: parse smb1 session setup with word count 13 Ticket: 5845	7 months ago
Philippe Antoine	c53b9df5a2	rust/ffi: move detection helpers to ffi crate Ticket: 7666	7 months ago
Philippe Antoine	4f4912c042	rust: bindgen SIGMATCH_ constants	7 months ago
Philippe Antoine	2fa10052cf	websocket: check pdu opcode for reassembly Ticket: 8413 RFC 6455 Section 5.4 states Control frames (see Section 5.5) MAY be injected in the middle of a fragmented message. Control frames are identified by opcodes where the most significant bit of the opcode is 1.	7 months ago
Philippe Antoine	7b0528d85f	http2: set response_frame_size Ticket: 8410 Do not set only request_frame_size whatever the direction	7 months ago
Philippe Antoine	267c3baff7	rust/ffi: move STREAM_ constants to ffi crate Ticket: 7666 reexport them in suricata crate cbindgen them to C	7 months ago
Philippe Antoine	34ed8958a6	dcerpc: only log the tx interfaces Not all the state ones Ticket: 8378	7 months ago
Philippe Antoine	05a11e2897	dcerpc: store persistently contexts So that we can log and detect on interface uuids, even if AlterContext packets change one of the contexts, but other contexts are still used after it in request/responses Ticket: 8378	7 months ago
Jeff Lucovsky	14ebba6382	gen/unused: Remove unused function Remove unused function is_alphanumeric_or_slash	7 months ago
Jeff Lucovsky	98070a7ace	misc/cleanup: remove rust if <cond> .... Cleanup the few instances of rust where if cond return true else false exist rg = ripgrep rg -n -U '^\sif . \{\s\n\sreturn true;\s\n\s\}\s\n\sreturn false;' rust/src/ --glob '.rs' rg -n -U '^\sif .* \{\s\n\sreturn false;\s\n\s\}\s\n\sreturn true;' rust/src/ --glob '*.rs'	7 months ago
Philippe Antoine	6587e363a3	dcerpc: use bind context_id in SMB Ticket: 8375 logger already read this variable but it was never set, and the rust compiler did not warn about this Allows to log the interface uuid when ctx_id > 0 Wireshark filter for related pcaps dcerpc.cn_ctx_id > 0 && dcerpc.pkt_type == 0	7 months ago
Philippe Antoine	2c2a3c800f	dcerpc: support multiple PDU in one parser call Ticket: 7254 With TCP, we receive a stream of data, which may contain multiple PDUs in one call	7 months ago
Philippe Antoine	db51314478	rust: rustfmt dcerpc.rs	7 months ago
Philippe Antoine	55ad2953bf	dcerpc: do not error the whole flow on unhandled packet type Ticket: 5133	7 months ago
Philippe Antoine	76d2925bdf	ldap: abandon request does not wait for a response Ticket: 8356 As such, abandon request is a complete tx	8 months ago
Philippe Antoine	784e173278	http2: bound number of http2 frames per tx Ticket: 8289 If stream.reassembly.depth is unlimited, an attacker controlling the 2 sides of a communication going through Suricata can send a transition with an infinite number of headers, until suricata OOMs Solution is to offer a configuration option to bound the number of HTTP2 frames we store in a HTTP2 transaction, and produce an anomaly if this bound is crossed	8 months ago
Philippe Antoine	49fd7001ff	smtp/mime: fix urls finding in buffering case We used to look for a full line, but as we look fot the last eol we need to use the right index in the not-reversed list	8 months ago
Philippe Antoine	8bba47aa09	smtp/mime: avoid quadratic complexity in mime_smtp_find_url_strings Ticket: 8292 When we have buffered something in ctx.decoded_line, we already looked for '\n' in it, so we do not need to run it again Otherwise, callers that supply mime_smtp_find_url_strings with a few bytes at a time without "\n", have a quadratic complexity	8 months ago
Philippe Antoine	062f56ddde	detect/http2: use ThreadCtx for all headers keywords Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	4e538dfa3b	detect/http2: use ThreadCtx for http.request_header And also for http.response_header Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	0933e944df	detect/http2: use ThreadCtx for http.header.raw Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	711de8a5ea	detect/http2: use ThreadCtx for http.header Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	52a2f2dd19	detect/http2: use ThreadCtx for http.header_names Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	8e886a8ecd	krb5: use app-layer incomplete support Ticket: 3540 Ticket: 8305	8 months ago
Philippe Antoine	d77c43c79b	rust/ffi: move build_slice macro to ffi crate Ticket: 7666	8 months ago
Philippe Antoine	4a0143c8d4	rust/ffi: move cast_pointer macro to ffi crate Ticket: 7666	8 months ago
Shivani Bhardwaj	d241237c0f	Revert "dcerpc: fix consumed bytes post gap handling" This reverts commit `fc9da1c7a1`. That commit incorrectly used consumed as index of the slice passed to the Frame API. Found by oss-fuzz.	8 months ago
Jeff Lucovsky	ed882ede68	output/ipv6: Utility function to compress IPv6 addrs Issue: 7399 Utility function to compress IPv6 addresses per RFC-5952	8 months ago
Giuseppe Longo	de46f4ba9d	ldap: set invalid_data event Currently in parse_request function LdapEvent::InvalidData is not set when a request is not parsed correctly. Ticket #8258	8 months ago
Victor Julien	b55be5a44f	detect/transforms: update gunzip / zlib_deflate syntax Use standard space separated syntax.	8 months ago
Philippe Antoine	71b59f6dbe	rust/ffi: move IPPROTO_TCP to ffi and reexport in suricata Allows to reduce dependencies to full suricata crate Ticket: 7666	8 months ago
Philippe Antoine	d5ea973791	detect/ike: move ike.ike.chosen_sa_attribute keyword to rust Ticket: 8310 And increases expressivity on the way by supporting other modes than equality	8 months ago
Philippe Antoine	55333a6ca0	detect/ike: move ike.vendor keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	14edd66494	detect/ike: move ike.nonce_payload keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	d1213e4440	detect/ike: move ike.key_exchange_payload keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	f23169c924	detect/ike: move ike.nonce_payload_length keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	e85bf5be4d	detect/ike: move ike.key_exchange_payload_length keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	841fe44f34	detect/ike: move ike.exchtype keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	23032ebc65	detect/ike: move ike spi keywords to rust Ticket: 8310	8 months ago
Philippe Antoine	539e4ee665	detect/transforms: add zlib_deflate transform Ticket: 7846	8 months ago
Philippe Antoine	dbea660729	detect/transforms: add gunzip transform Ticket: 7846	8 months ago
Victor Julien	336a9d05ca	krb5: fix TCP record parsing A logic error in multi-record parsing meant only the first record was parsed. Bug: #8278.	8 months ago
Jason Ish	f951477461	rust/debug: use functions from ffi crate where possible It's not possible to use all the functions and macros from the ffi crate in the main Suricata crate, as there are conditionals around when running in test mode, and "cargo test" doesn't propagate the "cfg(test)" to test crates. Which for now means duplicating the macros and some functions.	9 months ago
Philippe Antoine	536242341b	detect/smb: move smb.version keyword to rust Ticket: 8267	9 months ago
Philippe Antoine	697c641400	detect/smb: move smb share and named_pipe keywords to rust Ticket: 8267	9 months ago
Philippe Antoine	667f8b2eb7	detect/smb: move smb ntlmssp keywords to rust Ticket: 8267	9 months ago
Victor Julien	a2e9ac21f8	flow: turn flags field into uint64_t Entire space is used.	9 months ago
Jason Ish	b0c912588c	mqtt/detect: fix mqtt_parse_bool return type Previously we were boxing a u8 and returning it as a pointer to a boolean. While this is probably not an issue itself, the value 2 was allowed to be converted to a boolean, which is undefined behavior in Rust.	9 months ago
Jason Ish	b9e0f9cc8b	rfb/detect: fix rfb_parse_sec_result return type The data parsed is a u32, but returned as DetectUintData<u8>, then later free'd as a DetectUintData<u32>.	9 months ago
Jason Ish	8b2a7ac47c	nfs/detect: fix nfs_procedure_parse return type Was returning DetectNfsProcedureData as a pointer to DetectUintData<u32>, and free'ing it as such.	9 months ago
Jason Ish	e474e45429	dns/detect: fix rcode return type The parsed DNS rcode was being returned as a DetectUintData<u8>, but is parsed, and free'd as a u16. So return a DetectUintData<u16>.	9 months ago
Philippe Antoine	364d2c077d	rust: bindgen SCAppLayerRegisterParser Ticket: 7662	9 months ago
Philippe Antoine	8857b78f6a	rust: move AppLayerTxData definition to C and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerTxData Move also the free function to C SCAppLayerTxDataCleanup As suricata-sys crate defines AppLayerTxData for rust, It must itself implement the Drop trait, and thus, We need to define a feature surest	9 months ago
Philippe Antoine	8eaced3c1e	rust: move AppLayerResult definition to C and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerResult Keep From<> impl in sys crate that defines it	9 months ago
Philippe Antoine	06f78b2a22	rust: move StreamSlice definition to C and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses StreamSlice	9 months ago
Philippe Antoine	41f543ca35	rust: move AppLayerGetTxIterTuple definition to C and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerGetTxIterTuple	9 months ago
Philippe Antoine	64d29fcd1c	rust: move AppLayerStateData definition to C and bindgen it to rust, and use default trait instead of new Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerStateData	9 months ago
Philippe Antoine	76efb8af4d	rust: move AppLayerGetFileState definition to C and bindgen it to rust. Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerGetFileState	9 months ago
Shivani Bhardwaj	d4008a6508	dcerpc: remove bad tests Unittests test_parse_bind_pdu_infinite_loop and test_parse_bindack_pdu_infinite_loop seem to have artificially made up header which does not hold up to the strict calculations enforced by the parser now. Their headers mark the fraglens as 64 and 72 respectively which are not enough to hold the kind of bind(ack) items that are expected. It worked so far as the parser passed the entire input slice around but with the bugfix for issue 7546, the input passed around is strictly restricted to the fraglen parsed in the header. Bug 7546	9 months ago
Shivani Bhardwaj	ed1bd8624e	dcerpc: use fraglen from header So far, the fraglen defined in the header was used inconsistently in certain places to define bounds on input length. Make it consistent by making sure that only a slice up until fraglen is passed around as that is the maximum length the fragment should have. With the help of Applayer::incomplete API, the case when the stream_slice passed to the parser is smaller than the header defined fraglen is already handled. Bug 7546	9 months ago
Shivani Bhardwaj	fc9da1c7a1	dcerpc: fix consumed bytes post gap handling The parser could receive an input that consists of arbitrary data post gap. This is handled in the beginning of the fn handle_input_data. However, the rest of the calculation does not take into account the bytes that were consumed at this stage. Fix the indices and calculations to consider a new DCERPC fragment beginning post these consumed bytes.	9 months ago
Philippe Antoine	9a52bbcbe9	detect/quic: move quic.cyu.hash to rust Ticket: 8255	9 months ago
Philippe Antoine	01610aabe7	detect/quic: move quic.cyu.string to rust Ticket: 8255	9 months ago
Philippe Antoine	ee4d4a14d5	detect/quic: move quic.ua to rust Ticket: 8255	9 months ago
Philippe Antoine	9ba9fdcb87	detect/quic: move quic.sni to rust Ticket: 8255	9 months ago
Philippe Antoine	907e71a984	detect/quic: move quic.version to rust Ticket: 8255	9 months ago
Philippe Antoine	2cf9a327d5	detect/ssh: move ssh.hassh to rust Introduces helper SCDetectRegisterBufferLowerMd5Callbacks	9 months ago
Philippe Antoine	83360cfce0	detect/ssh: move ssh.hassh string to rust bindgen needed SCSigMatchSilentErrorEnabled on the way	9 months ago
Philippe Antoine	02cb0f2ac2	rust: fix unnecessary_unwrap warnings warning: called `unwrap` on `rd.pipe` after checking its variant with `is_some` --> src/smb/smb1.rs:858:28 \| 857 \| if rd.pipe.is_some() { \| -------------------- help: try: `if let Some(<item>) = rd.pipe` 858 \| let pipe = rd.pipe.unwrap(); \| ^^^^^^^^^^^^^^^^ \| = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_unwrap = note: `#[warn(clippy::unnecessary_unwrap)]` on by default	9 months ago
Philippe Antoine	cafc398355	dcerpc: consume bytes after gap resync Ticket: 7567 Re-applies commit `8c3bd3e8a0` which was reverted in `f64aec9d11`	9 months ago
Philippe Antoine	54cc752cf9	ssh: hassh can be truly disabled Rules will not re-enable it Ticket: 8223	9 months ago
Philippe Antoine	458211dcf2	detect/ssh: move ssh.proto to rust	9 months ago
Philippe Antoine	9cfc1cc557	detect/ssh: move obsolete keywords to rust	9 months ago
Philippe Antoine	ea8ac2a02a	detect/ssh: move ssh.software to rust Adds helper function SCDetectHelperBufferProgressMpmRegister on the way	9 months ago
Philippe Antoine	c0d6747e82	app-layer: GetTxIteratorFn uses a AppLayerGetTxIterState Even if every current rust parser uses the u64 variant of the C union	9 months ago
Philippe Antoine	4b541b39f2	rust: move AppLayerEventType definition to C and bindgen it to rust. Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerEventType	9 months ago
Philippe Antoine	c960b7d7c1	app-layer: AppLayerParserFPtr uses a mut pointer to local storage So, fix the fn prototype in rust ParseFn	9 months ago
Philippe Antoine	f470ee448b	quic: use standard tx iterator code Will make bindgen life easier As the fn prototype should not have istate: &mut u64 but a *mut AppLayerGetTxIterState which is an union with a u64	9 months ago
Philippe Antoine	076fcd61cd	bittorrent: use standard tx iterator code Will make bindgen life easier As the fn prototype should not have istate: &mut u64 but a *mut AppLayerGetTxIterState which is an union with a u64	9 months ago
Philippe Antoine	1a546936c7	rust: AppLayerTxConfig uses Default impl	9 months ago
Philippe Antoine	4e64de3b3b	rust: remove wrapper LoggerFlags struct definition just use an u32 out of the box. Will make bindgen like easier	9 months ago
Philippe Antoine	f663be5983	rust: define every RustParser fn pointer unsafe That is what bindgen will do	9 months ago
Lukas Sismis	3e4fdb2118	misc: time unit parsing function	10 months ago
Philippe Antoine	5bb9a0c3af	dcerpc/tcp: fix fragmentation handling Really count the fragments, and set it done when last was received	10 months ago
Philippe Antoine	f64aec9d11	dcerpc: use different header for different directions Header handling is wrong in the case packet A to server is fragmented (return AppLayerResult::incomplete) packet B is to client, but uses the header of the to_server packet Bug 7547	10 months ago
Philippe Antoine	1832b50506	nfs: log read/write/rename whatever the nfs version These were previously logged correctly only for nfs v3 Now, the correct opcodes are used for v2 and v4 as well Ticket: 8222	10 months ago
Philippe Antoine	b0850efd67	rust: from_str implementation for EncryptionHandling To move non-specific quic code to the right place	10 months ago
Philippe Antoine	89b6ab6730	rust: rename EncryptionHandling as it is no longer specific to SSH	10 months ago
Philippe Antoine	7acfea57a9	rust: move EncryptionHandling definition to its own file as it is not specific to ssh anymore	10 months ago
Philippe Antoine	7422c97bf2	quic: encryption-handling config parameters Ticket: 8116	10 months ago
Philippe Antoine	a48200b9e5	dcerpc: use saturating_add to count fragments And do not overflow if we have traffic with more than 65K fragments	10 months ago
Shivani Bhardwaj	e412215af9	dcerpc: add upper limit on stub data DCERPC parsers had no upper bounds when it came to extending the stub data buffer. Traffic can be crafted to bypass some internal parser conditions to create an indefinite buffering in the stub_data array that can make Suricata crash. Add a default limit of 1MiB and make it configurable for the user. Security 8182 Co-authored-by: Philippe Antoine <pantoine@oisf.net>	10 months ago
Shivani Bhardwaj	1d7b0d9b7a	tls/subjectaltname: use byte arr instead of string TLS parsers use x509-parser crate which parses X.509 certificates that use ASN.1 DER encoding that can allow arbitrary byte sequences. An attacker could inject null byte in a certificate anywhere to stump the common language parsers terminating the string at a null byte leading to a bypass of a possibly malicious certificate. So far, the rust TLS parser for "subjectaltname" used a pattern that involved: -> Get ASN.1 DER encoded raw data from the x509-parser crate -> Convert this raw data to a decoded string (Rust) -> Convert the Rust string to CString -- The problem lies here. CString only accepts proper strings/byte buffers and converts it into an owned C-compatible, null-terminated string. However, if any null byte occurs in the string passed to the CString then it panics. In the rust TLS parser, this panic is handled by returning NULL. This means that the parser will error out during the decoding of the certificate. However, Suricata must be able to detect the null byte injection attack being an IDS/IPS. Hence, replace all such string patterns w.r.t. TLS SAN with a byte array. Bug 7887	10 months ago
Shivani Bhardwaj	24f5b7dab2	tls/serial: use byte array instead of string Bug 7887	10 months ago
Shivani Bhardwaj	f025e07191	tls/issuerdn: use byte array instead of string TLS parsers use x509-parser crate which parses X.509 certificates that use ASN.1 DER encoding that can allow arbitrary byte sequences. An attacker could inject null byte in a certificate anywhere to stump the common language parsers terminating the string at a null byte leading to a bypass of a possibly malicious certificate. So far, the rust TLS parser for "issuerdn" used a pattern that involved: -> Get ASN.1 DER encoded raw data from the x509-parser crate -> Convert this raw data to a decoded string (Rust) -> Convert the Rust string to CString -- The problem lies here. CString only accepts proper strings/byte buffers and converts it into an owned C-compatible, null-terminated string. However, if any null byte occurs in the string passed to the CString then it panics. In the rust TLS parser, this panic is handled by returning NULL. This means that the parser will error out during the decoding of the certificate. However, Suricata must be able to detect the null byte injection attack being an IDS/IPS. Hence, replace all such string patterns w.r.t. TLS IssuerDN with a byte array. Bug 7887	10 months ago
Shivani Bhardwaj	77c21b05d2	tls/subject: use byte array instead of string TLS parsers use x509-parser crate which parses X.509 certificates that use ASN.1 DER encoding that can allow arbitrary byte sequences. An attacker could inject null byte in a certificate anywhere to stump the common language parsers terminating the string at a null byte leading to a bypass of a possibly malicious certificate. So far, the rust TLS parser for "Subject" used a pattern that involved: -> Get ASN.1 DER encoded raw data from the x509-parser crate -> Convert this raw data to a decoded string (Rust) -> Convert the Rust string to CString -- The problem lies here. CString only accepts proper strings/byte buffers and converts it into an owned C-compatible, null-terminated string. However, if any null byte occurs in the string passed to the CString then it panics. In the rust TLS parser, this panic is handled by returning NULL. This means that the parser will error out during the decoding of the certificate. However, Suricata must be able to detect the null byte injection attack being an IDS/IPS. Hence, replace all such string patterns w.r.t. TLS Subject with a byte array. Bug 7887	10 months ago
Shivani Bhardwaj	06eafb79d6	detect/flow-pkts: check for both dir The functionality of "both" can already be easily achieved by using both "toclient" and "toserver" in a rule. This just adds the ease of expression in rule. As it is added now, check the direction for the pre-existing users of direction as well.	10 months ago
Shivani Bhardwaj	77abcde9ee	rust/flow: add public wrapper for dir in order to be able to use it on the C side for elephant flow detection.	10 months ago
Jason Ish	50224f2ee5	rust: fix clippy warning for unused import While debug_validate_bug_on is still used, it does not need to be imported directly, as that macro is marked with `macro_export`, making it globally available to the crate.	11 months ago
Philippe Antoine	455b7d1b3b	rust: use snake case for applayer_register_protocol_detection	11 months ago
Philippe Antoine	b4d8aea0ae	rust: bindgen SCAppLayerRegisterProtocolDetection Ticket: 7662 Changing the struct passed to it to have the minimal number of useful fields.	11 months ago
Philippe Antoine	2349f19977	nfs: use nfsv2 procedure names with nfs_procedure keyword Ticket: 5140	11 months ago
Jhonny Sousa	257ed82dbd	nfs: Fix NFSv2 STATFS procedure parsing Ticket: #5140	11 months ago
Philippe Antoine	15b1bf4865	rust: bindgen SCHTPFileCloseHandleRange Ticket: 7762	11 months ago
Philippe Antoine	cddbd0b906	rust: bindgen more file functions Ticket: 7762	11 months ago
Victor Julien	80d5afe91b	pop3: AUTH command handling improvements Better track the state so it's known when to expect a base64 request message. Also better validate the base64. Ticket: #7994.	11 months ago
Victor Julien	2973eded56	pop3: convert to nom 8 Ticket: #8127.	11 months ago
Victor Julien	da2db65f62	pop3: rustfmt	11 months ago
Jason Ish	83d8b1d2f8	quic: update to nom 8.0 Ticket: #8140	11 months ago
Philippe Antoine	32ce3d29be	detect/krb: use flag u32 for krb5_msg_type	11 months ago
Jason Ish	ef9cd7beff	rust/smb: convert to nom 8 Ticket: #8089	12 months ago
Jason Ish	02045e1d62	rust/dcerpc: convert to nom 8 Ticket: #8093	12 months ago
Jason Ish	25c98af0e8	rust/detect: convert remaining detection rule parsers to nom 8 Ticket: #8051	12 months ago
Jason Ish	dea3f9e260	rust/detect: convert error.rs and dependent parsers to nom 8 Ticket: #8051	12 months ago
Jason Ish	efc32dea41	rust/detect: convert uint nom 8 And users of uint directly impacted by this change. Ticket: #8051	12 months ago
Jason Ish	cf604751de	rust/util: convert to nom 8 Ticket: #8088	12 months ago
Jason Ish	1e01d5adca	rust/conf: convert to nom 8 Ticket: #8087	12 months ago
Jason Ish	c6e8932740	rust/asn1: convert to nom 8 Ticket: #8086	12 months ago
Jason Ish	59f8fb30a8	rust/ftp: fix clippy warning error: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` --> src/ftp/response.rs:107:31	12 months ago
Philippe Antoine	cba13ed9b1	rust: bindgen functions needed for datasets Ticket: 7762	12 months ago
Philippe Antoine	12892ba010	rust: bindgen functions neede for features Ticket: 7762	12 months ago
Jeff Lucovsky	e1bf5cb1f3	nfs: Support EXCLUSIVE4_1 flag Issue: 8006 Support the EXCLUSIVE4_1 create mode added to NFS 4.1	12 months ago
Philippe Antoine	79e66f76e6	detect: icmp_id is now a generic integer Ticket: 7889	12 months ago
Philippe Antoine	85fa894425	detect: dnp3.func is now a generic integer Ticket: 7889	12 months ago
Philippe Antoine	c61f1cb6d0	detect/integers: rename index all1 to all And all to all_or_absent Ticket: 7929	12 months ago
Philippe Antoine	eb5a2d646b	detect/vlan: move vlan.id keyword to generic integer Ticket: 7929	12 months ago
Philippe Antoine	439f96dea7	rust: bindgen frames functions Ticket: 7667	12 months ago
Philippe Antoine	92c7be1cb6	rust: bindgen SCSRepCatGetByShortname Ticket: 7667	12 months ago
Philippe Antoine	7447651fa0	output/jsonbuilder: helper function SCJbSetPrintAsciiString To replace C PrintStringsToBuffer and avoid a stack alloc + copy Ticket: 8004	1 year ago
Li Heng	1106323ae1	rust/sip: delete redundant computing codes Delete call of is_alphanumeric where is_alphanumeric and is_token_char are called together. Four places are modified. Ticket: 8003	1 year ago
Jason Ish	1efe70a234	rust/ike: convert to nom 8 Ticket: #8050	1 year ago
Jason Ish	f368324e87	rust/mime: convert to nom 8 Ticket: #8048	1 year ago
Jason Ish	c5ef615953	rust/mqtt: convert to nom 8 Ticket: #8047	1 year ago
Jason Ish	2289069f74	rust/websocket: convert to nom 8 Ticket: #8046	1 year ago
Jason Ish	9eeefd0684	rust/bt-dht: convert to nom 8 Ticket: #8045	1 year ago
Jason Ish	399f96b07d	rust/rdp: convert to nom 8 Ticket: #8044	1 year ago
Jason Ish	7c70f74942	rust/telnet: convert to nom 8 Ticket: #8043	1 year ago
Jason Ish	2ff2eb1325	rust/ssh: convert to nom 8 Ticket: #8042	1 year ago
Jason Ish	baa22287b8	rust/rfb: convert to nom 8 Ticket: #8041	1 year ago
Jason Ish	dcfe247467	rust/pgsql: convert to nom 8 Ticket: #8039	1 year ago
Jason Ish	d25286e77a	rust/enip: convert to nom 8 Ticket: #8038	1 year ago
Jason Ish	d74f8522ee	rust/tftp: convert to nom 8 Ticket: #8037	1 year ago
Jason Ish	4b09622ebc	rust/dhcp: convert to nom 8 Ticket: #8036	1 year ago
Philippe Antoine	772bd9ca53	rust: reduce visibility of detect_parse_uint_notending It is meant as an internal function Also document the function	1 year ago
Philippe Antoine	b636dffd5b	detect: urilen keyword fails on trailing junk Fails especailly on 1<>2 which looks like a range, but is invalid as too small, and ended up being accepted as =1 Ticket: 8028	1 year ago
Jason Ish	16d313cb8b	rust/applayertemplate: convert to nom 8 Ticket: #8027	1 year ago
Jason Ish	f0f4d88119	rust/sip+sdp: update to nom 8 Done together as there is a dependence of SDP by SIP. Ticket: #8025	1 year ago
Jason Ish	58564a4b0e	rust/ftp: update to nom 8 Ticket: #8026	1 year ago
Jason Ish	54cc97b78e	rust/dns: convert to nom 8.0 Ticket: #8024	1 year ago
Philippe Antoine	dc7874b2ac	rust: bindgen more http range functions used in http2 Ticket: 7667	1 year ago
Philippe Antoine	842352c190	rust: bindgen SCHttpRangeFreeBlock Ticket: 7667	1 year ago
Philippe Antoine	93785ae357	rust: bindgen SCHTTP2MimicHttp1Request Ticket: 7667	1 year ago
Philippe Antoine	a1613fecb4	detect: tcp.flags rejects non-sensical values ignored flags are only meaningful for equal mode	1 year ago
Philippe Antoine	d8cb00e795	detect/tcp: make tcp.flags a generic integer with bitflags Ticket: 6724 Allows to use numerical values for example Also fixes some unit tests that were returning 1 after goto error FlagsTestParse05 especially took this path as de->ignored_flags != (TH_SYN\|TH_RST) was false we had de->ignored_flags == 0xff ^ (TH_SYN\|TH_RST) And then, we had a match, instead of what the not-run code was supposing.	1 year ago
Philippe Antoine	1f9236a6d8	detect/ipv4: make fragbits a generic uint16 bitflags keyword Ticket: 6724 Allows to use numerical values	1 year ago
Philippe Antoine	633180c93f	detect/integers: generalize support for bitflags modifier Ticket: 6724 Allows sugar syntax for bitflags keywords. While the expressivity does not increase, because we could already use numerial values with all generic integer modes, this modifier prefix is used with the strings, and follows the syntax that is already used for fragbits and tcp.flags keyword.	1 year ago
Jason Ish	bc33bd49eb	quic/crypto: remove use of GenericArray Its not needed, and gets rid of the deprecation warnings.	1 year ago
Jason Ish	bdfdf7ff33	rust: update deps with cargo-update Suppress deprecation warnings in quick/crypto.rs about GenericArray.	1 year ago
Jason Ish	6fdf0d736b	rust: update aes-gcm to 0.10.3	1 year ago
Jason Ish	b9517de86e	rust: update aes to 0.8.4	1 year ago
Philippe Antoine	4b69a31dc3	detect/integers: count argument for multi-integers Ticket: 7211 Allows to count the number of elements, without matching on individual elements	1 year ago
Philippe Antoine	3babd68af4	pop3: count retr_data into consumed for later AppLayerResult::incomplete Fixes: `acef961645` ("pop3: improve parsing") https://issues.oss-fuzz.com/u/1/issues/451112373 Ticket: 7994	1 year ago
Philippe Antoine	9a4a29e218	http2: fix parsing of goaway frames There was a last stream id before the error code As per section 6.8 of RFC 7540 Ticket: 7991	1 year ago
Philippe Antoine	7f0087f19a	rust/detect: fix correct pointer type in SCDetectU32ArrayFree	1 year ago
Philippe Antoine	969739d067	detect: http2.errorcode is now a generic integer Ticket: 7889	1 year ago
Philippe Antoine	401b2fcae6	detect: http2.frametype is now a generic integer Ticket: 7889	1 year ago
Philippe Antoine	454f73b445	rust: EnumString derive accepts a enum_string_style parameter So that http2.frametype and http2.errorcode can use EnumString without changing the format, as they used UPPERCASE instead of the default EnumString snake_case	1 year ago
Victor Julien	acef961645	pop3: improve parsing Improve multiline commands and SASL auth. Work around missing support in crate for empty server challenge and SASL base64 data. Ticket: #7709.	1 year ago
Jason Ish	5e2dc9ace3	ike: don't log empty server objects	1 year ago
Jason Ish	2d86412f46	ike: log attributes as objects IKE attributes are an array of TLV style objects, this means there can be duplicate types seen on the wire. However, Suricata logs these as a mapping with the type as the key. This can result in the JSON containing duplicate keys. To address this, log the attributes as an array of objects, allow duplicates to exist, for example: "client": { "proposals": [ { "sa_life_duration": "Unknown", "sa_life_duration_raw": 86400, } } } is now logged as: "client": { "proposals": [ {"key": "sa_life_duration", "value": "Unknown", "raw": 86400} ] } Also adds `"version": 2` to each IKE record to note the change of format from previous versions. Ticket: #7902	1 year ago
Jason Ish	b543e28402	ike/detect: info log message should be debug	1 year ago
Philippe Antoine	a393147415	rust: restrict visibility of reexported suricata_sys structs	1 year ago
Philippe Antoine	958344787f	rust: bindgen FileAppendData Ticket: 7667	1 year ago
Philippe Antoine	811d28cc6b	rust: bindgen util-spm-bs.h for SCBasicSearchNocaseIndex Ticket: 7667	1 year ago
Jeff Lucovsky	0e547b9519	rust/conf: Accept xiB unit suffixes Update the memval to recognize - kb and kib - mb and mib - gb and gib as equivalent.	1 year ago
Philippe Antoine	56e08c9134	mime: retain some stateful data for quoted-printable In case a sequence like =3D is split over 2 calls to SCSmtpMimeParseLine Ticket: 7950	1 year ago
Philippe Antoine	096ba42ce9	detect/integers: add some meaningful error messages To help rule writers	1 year ago
Philippe Antoine	4f7fc25a1a	detect/dnp3: make dnp3.ind a generic uint16 bitflags keyword Ticket: 6724 Allows operations such as negation	1 year ago
Philippe Antoine	c1917dec21	detect/integers: make mqtt use generic detect_parse_uint_bitflags Ticket: 6724	1 year ago
Philippe Antoine	867f5bfa21	detect/integers: generic detect_parse_uint_bitflags Ticket: 6724 This will ease other keywords with bitflags, by having a generic function + an association between flag string and bit value.	1 year ago
Philippe Antoine	3641b4eda1	detect/nfs: move nfs_procedure to rust Make it able to use strings on the way Ticket: 6723	1 year ago
Philippe Antoine	9869fb776b	detect/snmp: pdu_type keyword now accepts strings Ticket: 6723	1 year ago
Philippe Antoine	0553dfa814	detect/krb5: move krb5_msg_type to rust Makes it a generic u32 on the way Unit tests are covered by SV tests Ticket: 6723	1 year ago
Philippe Antoine	24503b0ead	rust: move file functions out of SuricataContext Ticket: 7667	1 year ago
Philippe Antoine	1f084f8cb7	rust: move HttpRangeFreeBlock out of SuricataContext Ticket: 7667	1 year ago
Philippe Antoine	828a6bdbf8	rust: bindgen SCLogMessage Ticket: 7667	1 year ago
Philippe Antoine	cc845dccdb	rust: bindgen GenericVarFree Ticket: 7667	1 year ago
Philippe Antoine	b00788af8b	rust: bindgen SCAppLayerParserTriggerRawStreamInspection Ticket: 7667	1 year ago
Philippe Antoine	c52121586a	rust: move AppLayerEvents funcs out of RustContext Ticket: 7667 just use it directly, with bindgen, and cfg not test	1 year ago
Philippe Antoine	bf6b8510fe	rust: move DetectEngineStateFree out of RustContext Ticket: 7667 just use it directly, with bindgen, and cfg not test	1 year ago
Philippe Antoine	573dd2367e	rust: bindgen SCFileFlowFlagsToFlags Ticket: 7667	1 year ago
Philippe Antoine	6fa85d18f0	rust: reenable lint unused_doc_comment With just local exceptions	1 year ago
Philippe Antoine	b59086210f	rust: bindgen flow ffi API Ticket: 7667	1 year ago
Philippe Antoine	bbf1424371	rust: bindgen MpmAddPatternCI Ticket: 7667	1 year ago
Philippe Antoine	c391451f19	rust: begin to bindgen app-layer-register.h Ticket: 7667	1 year ago
Philippe Antoine	95483228d2	detect: list-keywords cli shows integers with bitflags Ticket: 7875	1 year ago
Philippe Antoine	53d9569dfb	detect: list-keywords cli shows integers with enums Ticket: 7875	1 year ago
Philippe Antoine	da486af881	detect: list-keywords cli shows integers Ticket: 7875	1 year ago
Philippe Antoine	68017d3fe1	detect: grow SigTableElmt flags to u32 to be later able to store information about keywords being about integers	1 year ago
Philippe Antoine	b298bce0e7	detect: list-keywords cli shows multi-buffers Ticket: 7571	1 year ago
Philippe Antoine	cb9ab951b9	detect/integers: subslice for multi-integers	1 year ago
Philippe Antoine	82f0e725a2	detect/integers: index or_absent and or_oob To match if array is empty, or index is out of bounds	1 year ago
Philippe Antoine	1480cf47ab	detect/integers: nb index to match a specific number of times For example dns.rrtype: !A,nb>3 will match if we have more than 3 dns records which are not A	1 year ago
Philippe Antoine	6f848eeaaf	detect/integers: all1 index to match only on non-empty arrays	1 year ago
Philippe Antoine	dd81cfa733	detect/uint: wait for end of progress to match on all As is done for absent keyword for instance	1 year ago
Philippe Antoine	5add185f22	http2/detect: http2.window can now use index Ticket: 7480	1 year ago
Philippe Antoine	83868778b9	http2/detect: http2.priority can now use index Ticket: 7480	1 year ago
Philippe Antoine	9fc407fd75	mqtt/detect: mqtt.type can now use index Ticket: 7480	1 year ago
Philippe Antoine	c0988252ba	dns/detect: rrtype can now use index Ticket: 7480	1 year ago
Philippe Antoine	d8c1f8e7be	rust/detect: generic detect_uint_match_at_index and make ldap use it Ticket: 7480 No behavior change, just code restyling	1 year ago
Philippe Antoine	7effcb7835	rust/ldap: use Vec instead of Vecdeque as we do not pop Ticket: 7480 May have a behavior change, but only in terms of performance	1 year ago
Philippe Antoine	f555f02ed4	rust/detect: generic detect_parse_array_uint_enum And make ldap use it Ticket: 7480 No behavior change, just code restyling	1 year ago
Philippe Antoine	c6d3857793	rust/detect: create generic DetectUintArrayData And make ldap use them Ticket: 7480 No behavior change, just code restyling	1 year ago
Philippe Antoine	e01d19889e	rust/detect: move DetectUintIndex definition to generic file Ticket: 7480 No behavior change, just code restyling	1 year ago
Philippe Antoine	ef6ce7d701	detect: rename LdapIndex to something generic to be able to use it outside of ldap Ticket: 7480 No behavior change, just code restyling	1 year ago

... 3 4 5 6 7 ...

2216 Commits (912c5450757edbcc62c95cfe887cd0cadaab4668)