suricata

Commit Graph

Author	SHA1	Message	Date
Victor Julien	6ebd0c3cc2	http2: check for HTTP1 protocol during upgrade path Ticket: 8492	6 months ago
Philippe Antoine	10bde66586	nfs: bound file_additional_procs to 1 Ticket: 8418 As we only need to know we saw at least one NFSPROC3_COMMIT	6 months ago
Philippe Antoine	aea7ee21b8	nfs: bound namemap by using lru Ticket: 8418	6 months ago
Philippe Antoine	a50f494ef6	nfs: bound requestmap and use lru Ticket: 8418	6 months ago
Juliana Fajardini	d442c3544c	detect: opt-in keywords for firewall mode - tls.cert_chain_len - datarep - dataset - dns.opcode Part of Ticket #8387	6 months ago
Philippe Antoine	f0e246de34	detect/mqtt: reason_code keyword is now a multi-integer Ticket: 7929 Builds a vector of the reason code in a tx to do so, except if we use the default "any", where we do not append to the vector, but just run detection while iterating	6 months ago
Philippe Antoine	614c48d3c3	ikev2: remove unused field Ticket: 8415	6 months ago
Jeff Lucovsky	9ea2e29581	ftp: raise too_many_transactions event on overflow Other parsers (SMB, POP3, ENIP) already raise a too_many_transactions event when a flow exceeds its per-flow transaction limit. FTP had the limit wired up through app-layer.protocols.ftp.max-tx but just dropped the excess transaction on the floor with a "FTP does not set events yet..." TODO, so no event was raised when the limit was reached. Add the FtpEventTooManyTransactions variant, a stock rule at sid 2232002, and raise the event from FTPTransactionCreate when the live-tx count goes past ftp_config_maxtx. Issue: 8489	6 months ago
Philippe Antoine	e38888810d	detect/dcerpc: avoids FP on dcerpc.iface keyword When we got a bind without the first fragment flag, and did not set any_frag in the signature, the signature always matched, whatever the uuid value Ticket: 8457	6 months ago
Philippe Antoine	5ed394b26b	rust/ffi: move AppLayerEvent to ffi Ticket: 7666	6 months ago
Philippe Antoine	59b6de8239	rust: fix last collapsible_match warnings The ones where we need to remove a debug log	6 months ago
Philippe Antoine	1cdff9de8e	rust: fix collapsible_match warnings warning: this `if` can be collapsed into the outer `match` help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_match	6 months ago
Jason Ish	899e9f045e	ntp: expose logged fields to lua This includes: - version - mode - stratum - reference_id Ticket: #8533	6 months ago
Jason Ish	81692dd2c1	rust/lua: add method for pushing bytes Much like pushstring, but accepts an &[u8] as an argument instead of an &str. In support of ticket #8533.	6 months ago
Jason Ish	cdb02a2779	rust/dns: rustfmt	6 months ago
Philippe Antoine	7d66eb5f04	rust: remove unused function rust_string_to_c was used when a buffer should be used as it could contain nul-byte	6 months ago
Philippe Antoine	9b12fd9f09	rust/ffi: move helper trait state_get_tx_iterator to ffi Ticket: 7666	6 months ago
Philippe Antoine	07f37676b6	rust/ffi: move Flags for AppLayerParserState to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	fb20c69d8d	rust/ffi: move APP_LAYER_PARSER_OPT_X const to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	d81a10126e	detect/doc: remove unexisting links Ticket: 8257 And add TODO comments if rules doc should be written	6 months ago
Philippe Antoine	8e39539161	detect/doc: fix broken anchor links Ticket: 8257	6 months ago
Philippe Antoine	bd6a436893	detect/doc: fix broken files links Ticket: 8257	6 months ago
Philippe Antoine	b0e63a2c95	detect/dcerpc: move stub_data keyword to rust Ticket: 8391	6 months ago
Jeff Lucovsky	746f471382	transform/subslice: Add subslice transform Issue: 7672 The subslice transform creates a slice of the input buffer. Specify the subslice desired -- nbytes and truncate are optional: subslice: offset <,nbytes> <,truncate> offset: Specifies the starting offset for the new subslice. When negative, expresses how far from the end of the input buffer to begin. nbytes: Specifies the size of the subslice. When negative, specifies that the subslice will end that many bytes from the end of the input buffer. Nbytes must be non-zero. When nbytes is not specified, the size of the subslice will be the size of the input buffer - offset. truncate: Specify behavior when offset + nbytes exceeds buffer length. When present, trims nbytes such that offset + nbytes equals buffer length. When not present, an empty buffer is produced. Examples: subslice: 1; - The subslice will be a copy of the input buffer but omits the input buffer's first byte "This is Suricata" -> "his is Suricata" subslice: 0, 13; - The slice is created from the first 13 bytes of the input buffer "This is Suricata" -> "This is Suric" subslice: 10, -5; - The subslice is created starting at offset 10 and continues to 5 bytes before the end of the input buffer "This is Suricata" -> "r" subslice: -3; - The subslice will be the last 3 bytes of the input buffer. "This is Suricata" -> "ata"	6 months ago
Philippe Antoine	4fc6ca5d6c	detect/dcerpc: move iface keyword to rust Ticket: 8391 Use same buffer dce_generic as for dcerpc.opnum (name dce_generic is enforced by a SV test currently)	6 months ago
Philippe Antoine	9677851637	rust/ffi: move app-layer traits to ffi crate Ticket: 7666 Traits around structures defined in C and bindgened to rust	6 months ago
Philippe Antoine	f803c25f24	rust/ffi: move export_X_data_get macros to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	54b6885166	rust/ffi: move conf_get_bool helper to ffi crate Ticket: 7666	6 months ago
Philippe Antoine	5f9e436c3f	detect/dcerpc: support generic integer for opnum keyword Ticket: 8179	6 months ago
Philippe Antoine	67379b009a	detect/dcerpc: move opnum keyword to rust Ticket: 8391	6 months ago
Jason Ish	fd31e50954	ntp: enable keywords for firewall mode Ticket: #8394	6 months ago
Jason Ish	713e4eb900	ntp: convert reference_id to buffer and add keyword Store the NTP reference ID as raw network-order bytes so it can be exposed as a sticky buffer and matched with payload keywords. The reference ID is often a 4 character string, or an IP address and not just an integer identifier. Updates the log reference ID to be a string of colon separated hex digits as this matches what tshark does. Ticket: #8488	6 months ago
Jason Ish	991e7f3b1d	ntp: add ntp.mode keyword This keyword also accepts strings for known mode names. Ticket: #8429	6 months ago
Jason Ish	c10c482290	ntp: add ntp.stratum keyword Ticket: #8431	6 months ago
Jason Ish	ec344fe68d	ntp: add ntp.version keyword SNMP was used as a template. Ticket: #8430	6 months ago
Jason Ish	74bb525401	ntp: create tx for all modes; log version, mode and stratum Add logging for version, mode and stratum as these will be the first keywords we will add. Ticket: #8425	6 months ago
Jason Ish	879846e153	ntp: remove unused event types NotRequest and NotResponse event type have never been used. Unsolicited is also unused, however there is a rule for it so removing support would be a breaking change at this time.	6 months ago
Jason Ish	31b967b089	ntp: add transaction logging Adds basic NTP transaction logging for the current supported message types. Includes small cleanups around reference ID. Ticket: #8425	6 months ago
Victor Julien	c7cd3b17c3	snmp: minor snmp.pdu_type type cleanup	7 months ago
Victor Julien	2cef1404bc	detect/snmp: let generic keyword share the same list	7 months ago
Victor Julien	670fdabd32	detect/snmp: add snmp.trap_type keyword Implemented as a U8 integer keyword. Ticket: #8482.	7 months ago
Philippe Antoine	8ac9a62ec4	detect: enable snmp keywords for firewall mode Ticket: #8395	7 months ago
Philippe Antoine	63603fe14a	detect/snmp: sticky buffers at progress 1 Since snmp txs are created at progress 1 which is the completion, this does not change detection, except allowing firewall mode to use these keywords with generic hook like snmp:request_complete Ticket: 8395	7 months ago
Philippe Antoine	8f824458c2	detect: helper for buffer register requires progress Ticket: 8395 For protocols where tx are complete at start, that is the `tx_get_progress` function returns 1 inconditionnally, we can use the progress 1, not losing time on detection in ips mode, and getting ready for firewall mode For the other protocols (where a tx needs both a request and response for instance), keep progress 0 as was the case before	7 months ago
Philippe Antoine	58a71d94b0	rust/ffi: move conf_get helper to ffi crate Ticket: 7666	7 months ago
Philippe Antoine	8d254f5630	dhcp/output: log app-layer metadata in alerts Ticket: 6091 log as extended	7 months ago
Philippe Antoine	db980daf5f	dhcp: standardize output code To prepare to add metadata in alerts Ticket: 6091	7 months ago
Philippe Antoine	d14af54b3b	detect/transforms: constify some callbacks arguments Ticket: 8298	7 months ago
Philippe Antoine	0a24f0afe2	smb: parse smb1 session setup with word count 13 Ticket: 5845	7 months ago
Philippe Antoine	c53b9df5a2	rust/ffi: move detection helpers to ffi crate Ticket: 7666	7 months ago
Philippe Antoine	4f4912c042	rust: bindgen SIGMATCH_ constants	7 months ago
Philippe Antoine	2fa10052cf	websocket: check pdu opcode for reassembly Ticket: 8413 RFC 6455 Section 5.4 states Control frames (see Section 5.5) MAY be injected in the middle of a fragmented message. Control frames are identified by opcodes where the most significant bit of the opcode is 1.	7 months ago
Philippe Antoine	7b0528d85f	http2: set response_frame_size Ticket: 8410 Do not set only request_frame_size whatever the direction	7 months ago
Philippe Antoine	267c3baff7	rust/ffi: move STREAM_ constants to ffi crate Ticket: 7666 reexport them in suricata crate cbindgen them to C	7 months ago
Philippe Antoine	34ed8958a6	dcerpc: only log the tx interfaces Not all the state ones Ticket: 8378	7 months ago
Philippe Antoine	05a11e2897	dcerpc: store persistently contexts So that we can log and detect on interface uuids, even if AlterContext packets change one of the contexts, but other contexts are still used after it in request/responses Ticket: 8378	7 months ago
Jeff Lucovsky	14ebba6382	gen/unused: Remove unused function Remove unused function is_alphanumeric_or_slash	7 months ago
Jeff Lucovsky	98070a7ace	misc/cleanup: remove rust if <cond> .... Cleanup the few instances of rust where if cond return true else false exist rg = ripgrep rg -n -U '^\sif . \{\s\n\sreturn true;\s\n\s\}\s\n\sreturn false;' rust/src/ --glob '.rs' rg -n -U '^\sif .* \{\s\n\sreturn false;\s\n\s\}\s\n\sreturn true;' rust/src/ --glob '*.rs'	7 months ago
Philippe Antoine	6587e363a3	dcerpc: use bind context_id in SMB Ticket: 8375 logger already read this variable but it was never set, and the rust compiler did not warn about this Allows to log the interface uuid when ctx_id > 0 Wireshark filter for related pcaps dcerpc.cn_ctx_id > 0 && dcerpc.pkt_type == 0	8 months ago
Philippe Antoine	2c2a3c800f	dcerpc: support multiple PDU in one parser call Ticket: 7254 With TCP, we receive a stream of data, which may contain multiple PDUs in one call	8 months ago
Philippe Antoine	db51314478	rust: rustfmt dcerpc.rs	8 months ago
Philippe Antoine	55ad2953bf	dcerpc: do not error the whole flow on unhandled packet type Ticket: 5133	8 months ago
Philippe Antoine	76d2925bdf	ldap: abandon request does not wait for a response Ticket: 8356 As such, abandon request is a complete tx	8 months ago
Philippe Antoine	784e173278	http2: bound number of http2 frames per tx Ticket: 8289 If stream.reassembly.depth is unlimited, an attacker controlling the 2 sides of a communication going through Suricata can send a transition with an infinite number of headers, until suricata OOMs Solution is to offer a configuration option to bound the number of HTTP2 frames we store in a HTTP2 transaction, and produce an anomaly if this bound is crossed	8 months ago
Philippe Antoine	49fd7001ff	smtp/mime: fix urls finding in buffering case We used to look for a full line, but as we look fot the last eol we need to use the right index in the not-reversed list	8 months ago
Philippe Antoine	8bba47aa09	smtp/mime: avoid quadratic complexity in mime_smtp_find_url_strings Ticket: 8292 When we have buffered something in ctx.decoded_line, we already looked for '\n' in it, so we do not need to run it again Otherwise, callers that supply mime_smtp_find_url_strings with a few bytes at a time without "\n", have a quadratic complexity	8 months ago
Philippe Antoine	062f56ddde	detect/http2: use ThreadCtx for all headers keywords Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	4e538dfa3b	detect/http2: use ThreadCtx for http.request_header And also for http.response_header Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	0933e944df	detect/http2: use ThreadCtx for http.header.raw Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	711de8a5ea	detect/http2: use ThreadCtx for http.header Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	52a2f2dd19	detect/http2: use ThreadCtx for http.header_names Instead of custom inefficient "escaped" Vec Ticket: 8291	8 months ago
Philippe Antoine	8e886a8ecd	krb5: use app-layer incomplete support Ticket: 3540 Ticket: 8305	8 months ago
Philippe Antoine	d77c43c79b	rust/ffi: move build_slice macro to ffi crate Ticket: 7666	8 months ago
Philippe Antoine	4a0143c8d4	rust/ffi: move cast_pointer macro to ffi crate Ticket: 7666	8 months ago
Shivani Bhardwaj	d241237c0f	Revert "dcerpc: fix consumed bytes post gap handling" This reverts commit `fc9da1c7a1`. That commit incorrectly used consumed as index of the slice passed to the Frame API. Found by oss-fuzz.	8 months ago
Jeff Lucovsky	ed882ede68	output/ipv6: Utility function to compress IPv6 addrs Issue: 7399 Utility function to compress IPv6 addresses per RFC-5952	8 months ago
Giuseppe Longo	de46f4ba9d	ldap: set invalid_data event Currently in parse_request function LdapEvent::InvalidData is not set when a request is not parsed correctly. Ticket #8258	8 months ago
Victor Julien	b55be5a44f	detect/transforms: update gunzip / zlib_deflate syntax Use standard space separated syntax.	8 months ago
Philippe Antoine	71b59f6dbe	rust/ffi: move IPPROTO_TCP to ffi and reexport in suricata Allows to reduce dependencies to full suricata crate Ticket: 7666	8 months ago
Philippe Antoine	d5ea973791	detect/ike: move ike.ike.chosen_sa_attribute keyword to rust Ticket: 8310 And increases expressivity on the way by supporting other modes than equality	8 months ago
Philippe Antoine	55333a6ca0	detect/ike: move ike.vendor keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	14edd66494	detect/ike: move ike.nonce_payload keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	d1213e4440	detect/ike: move ike.key_exchange_payload keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	f23169c924	detect/ike: move ike.nonce_payload_length keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	e85bf5be4d	detect/ike: move ike.key_exchange_payload_length keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	841fe44f34	detect/ike: move ike.exchtype keyword to rust Ticket: 8310	8 months ago
Philippe Antoine	23032ebc65	detect/ike: move ike spi keywords to rust Ticket: 8310	8 months ago
Philippe Antoine	539e4ee665	detect/transforms: add zlib_deflate transform Ticket: 7846	8 months ago
Philippe Antoine	dbea660729	detect/transforms: add gunzip transform Ticket: 7846	8 months ago
Victor Julien	336a9d05ca	krb5: fix TCP record parsing A logic error in multi-record parsing meant only the first record was parsed. Bug: #8278.	8 months ago
Jason Ish	f951477461	rust/debug: use functions from ffi crate where possible It's not possible to use all the functions and macros from the ffi crate in the main Suricata crate, as there are conditionals around when running in test mode, and "cargo test" doesn't propagate the "cfg(test)" to test crates. Which for now means duplicating the macros and some functions.	9 months ago
Philippe Antoine	536242341b	detect/smb: move smb.version keyword to rust Ticket: 8267	9 months ago
Philippe Antoine	697c641400	detect/smb: move smb share and named_pipe keywords to rust Ticket: 8267	9 months ago
Philippe Antoine	667f8b2eb7	detect/smb: move smb ntlmssp keywords to rust Ticket: 8267	9 months ago
Victor Julien	a2e9ac21f8	flow: turn flags field into uint64_t Entire space is used.	9 months ago
Jason Ish	b0c912588c	mqtt/detect: fix mqtt_parse_bool return type Previously we were boxing a u8 and returning it as a pointer to a boolean. While this is probably not an issue itself, the value 2 was allowed to be converted to a boolean, which is undefined behavior in Rust.	9 months ago
Jason Ish	b9e0f9cc8b	rfb/detect: fix rfb_parse_sec_result return type The data parsed is a u32, but returned as DetectUintData<u8>, then later free'd as a DetectUintData<u32>.	9 months ago
Jason Ish	8b2a7ac47c	nfs/detect: fix nfs_procedure_parse return type Was returning DetectNfsProcedureData as a pointer to DetectUintData<u32>, and free'ing it as such.	9 months ago
Jason Ish	e474e45429	dns/detect: fix rcode return type The parsed DNS rcode was being returned as a DetectUintData<u8>, but is parsed, and free'd as a u16. So return a DetectUintData<u16>.	9 months ago
Philippe Antoine	364d2c077d	rust: bindgen SCAppLayerRegisterParser Ticket: 7662	9 months ago

1 2 3 4 5 ...

2079 Commits (79ef58be12a3be48ab6312f4468d8597ec2fa578)