2001 Commits (5f9e436c3f96e0ddef612c9dc96bccdc90165abf)

Author	SHA1	Message	Date
Philippe Antoine	5f9e436c3f	detect/dcerpc: support generic integer for opnum keyword ... Ticket: 8179	5 months ago
Philippe Antoine	67379b009a	detect/dcerpc: move opnum keyword to rust ... Ticket: 8391	5 months ago
Jason Ish	fd31e50954	ntp: enable keywords for firewall mode ... Ticket: #8394	5 months ago
Jason Ish	713e4eb900	ntp: convert reference_id to buffer and add keyword ... Store the NTP reference ID as raw network-order bytes so it can be exposed as a sticky buffer and matched with payload keywords. The reference ID is often a 4 character string, or an IP address and not just an integer identifier. Updates the log reference ID to be a string of colon separated hex digits as this matches what tshark does. Ticket: #8488	5 months ago
Jason Ish	991e7f3b1d	ntp: add ntp.mode keyword ... This keyword also accepts strings for known mode names. Ticket: #8429	5 months ago
Jason Ish	c10c482290	ntp: add ntp.stratum keyword ... Ticket: #8431	5 months ago
Jason Ish	ec344fe68d	ntp: add ntp.version keyword ... SNMP was used as a template. Ticket: #8430	5 months ago
Jason Ish	74bb525401	ntp: create tx for all modes; log version, mode and stratum ... Add logging for version, mode and stratum as these will be the first keywords we will add. Ticket: #8425	5 months ago
Jason Ish	879846e153	ntp: remove unused event types ... NotRequest and NotResponse event type have never been used. Unsolicited is also unused, however there is a rule for it so removing support would be a breaking change at this time.	5 months ago
Jason Ish	31b967b089	ntp: add transaction logging ... Adds basic NTP transaction logging for the current supported message types. Includes small cleanups around reference ID. Ticket: #8425	5 months ago
Victor Julien	c7cd3b17c3	snmp: minor snmp.pdu_type type cleanup	5 months ago
Victor Julien	2cef1404bc	detect/snmp: let generic keyword share the same list	5 months ago
Victor Julien	670fdabd32	detect/snmp: add snmp.trap_type keyword ... Implemented as a U8 integer keyword. Ticket: #8482.	5 months ago
Philippe Antoine	8ac9a62ec4	detect: enable snmp keywords for firewall mode ... Ticket: #8395	5 months ago
Philippe Antoine	63603fe14a	detect/snmp: sticky buffers at progress 1 ... Since snmp txs are created at progress 1 which is the completion, this does not change detection, except allowing firewall mode to use these keywords with generic hook like snmp:request_complete Ticket: 8395	5 months ago
Philippe Antoine	8f824458c2	detect: helper for buffer register requires progress ... Ticket: 8395 For protocols where tx are complete at start, that is the `tx_get_progress` function returns 1 inconditionnally, we can use the progress 1, not losing time on detection in ips mode, and getting ready for firewall mode For the other protocols (where a tx needs both a request and response for instance), keep progress 0 as was the case before	5 months ago
Philippe Antoine	58a71d94b0	rust/ffi: move conf_get helper to ffi crate ... Ticket: 7666	5 months ago
Philippe Antoine	8d254f5630	dhcp/output: log app-layer metadata in alerts ... Ticket: 6091 log as extended	5 months ago
Philippe Antoine	db980daf5f	dhcp: standardize output code ... To prepare to add metadata in alerts Ticket: 6091	5 months ago
Philippe Antoine	d14af54b3b	detect/transforms: constify some callbacks arguments ... Ticket: 8298	5 months ago
Philippe Antoine	0a24f0afe2	smb: parse smb1 session setup with word count 13 ... Ticket: 5845	5 months ago
Philippe Antoine	c53b9df5a2	rust/ffi: move detection helpers to ffi crate ... Ticket: 7666	5 months ago
Philippe Antoine	4f4912c042	rust: bindgen SIGMATCH_ constants	5 months ago
Philippe Antoine	2fa10052cf	websocket: check pdu opcode for reassembly ... Ticket: 8413 RFC 6455 Section 5.4 states Control frames (see Section 5.5) MAY be injected in the middle of a fragmented message. Control frames are identified by opcodes where the most significant bit of the opcode is 1.	5 months ago
Philippe Antoine	7b0528d85f	http2: set response_frame_size ... Ticket: 8410 Do not set only request_frame_size whatever the direction	5 months ago
Philippe Antoine	267c3baff7	rust/ffi: move STREAM_ constants to ffi crate ... Ticket: 7666 reexport them in suricata crate cbindgen them to C	6 months ago
Philippe Antoine	34ed8958a6	dcerpc: only log the tx interfaces ... Not all the state ones Ticket: 8378	6 months ago
Philippe Antoine	05a11e2897	dcerpc: store persistently contexts ... So that we can log and detect on interface uuids, even if AlterContext packets change one of the contexts, but other contexts are still used after it in request/responses Ticket: 8378	6 months ago
Jeff Lucovsky	14ebba6382	gen/unused: Remove unused function ... Remove unused function is_alphanumeric_or_slash	6 months ago
Jeff Lucovsky	98070a7ace	misc/cleanup: remove rust if <cond> .... ... Cleanup the few instances of rust where if cond return true else false exist rg = ripgrep rg -n -U '^\s*if .* \{\s*\n\s*return true;\s*\n\s*\}\s*\n\s*return false;' rust/src/ --glob '*.rs' rg -n -U '^\s*if .* \{\s*\n\s*return false;\s*\n\s*\}\s*\n\s*return true;' rust/src/ --glob '*.rs'	6 months ago
Philippe Antoine	6587e363a3	dcerpc: use bind context_id in SMB ... Ticket: 8375 logger already read this variable but it was never set, and the rust compiler did not warn about this Allows to log the interface uuid when ctx_id > 0 Wireshark filter for related pcaps dcerpc.cn_ctx_id > 0 && dcerpc.pkt_type == 0	6 months ago
Philippe Antoine	2c2a3c800f	dcerpc: support multiple PDU in one parser call ... Ticket: 7254 With TCP, we receive a stream of data, which may contain multiple PDUs in one call	6 months ago
Philippe Antoine	db51314478	rust: rustfmt dcerpc.rs	6 months ago
Philippe Antoine	55ad2953bf	dcerpc: do not error the whole flow on unhandled packet type ... Ticket: 5133	6 months ago
Philippe Antoine	76d2925bdf	ldap: abandon request does not wait for a response ... Ticket: 8356 As such, abandon request is a complete tx	6 months ago
Philippe Antoine	784e173278	http2: bound number of http2 frames per tx ... Ticket: 8289 If stream.reassembly.depth is unlimited, an attacker controlling the 2 sides of a communication going through Suricata can send a transition with an infinite number of headers, until suricata OOMs Solution is to offer a configuration option to bound the number of HTTP2 frames we store in a HTTP2 transaction, and produce an anomaly if this bound is crossed	6 months ago
Philippe Antoine	49fd7001ff	smtp/mime: fix urls finding in buffering case ... We used to look for a full line, but as we look fot the last eol we need to use the right index in the not-reversed list	6 months ago
Philippe Antoine	8bba47aa09	smtp/mime: avoid quadratic complexity in mime_smtp_find_url_strings ... Ticket: 8292 When we have buffered something in ctx.decoded_line, we already looked for '\n' in it, so we do not need to run it again Otherwise, callers that supply mime_smtp_find_url_strings with a few bytes at a time without "\n", have a quadratic complexity	6 months ago
Philippe Antoine	062f56ddde	detect/http2: use ThreadCtx for all headers keywords ... Instead of custom inefficient "escaped" Vec Ticket: 8291	6 months ago
Philippe Antoine	4e538dfa3b	detect/http2: use ThreadCtx for http.request_header ... And also for http.response_header Instead of custom inefficient "escaped" Vec Ticket: 8291	6 months ago
Philippe Antoine	0933e944df	detect/http2: use ThreadCtx for http.header.raw ... Instead of custom inefficient "escaped" Vec Ticket: 8291	6 months ago
Philippe Antoine	711de8a5ea	detect/http2: use ThreadCtx for http.header ... Instead of custom inefficient "escaped" Vec Ticket: 8291	6 months ago
Philippe Antoine	52a2f2dd19	detect/http2: use ThreadCtx for http.header_names ... Instead of custom inefficient "escaped" Vec Ticket: 8291	6 months ago
Philippe Antoine	8e886a8ecd	krb5: use app-layer incomplete support ... Ticket: 3540 Ticket: 8305	6 months ago
Philippe Antoine	d77c43c79b	rust/ffi: move build_slice macro to ffi crate ... Ticket: 7666	6 months ago
Philippe Antoine	4a0143c8d4	rust/ffi: move cast_pointer macro to ffi crate ... Ticket: 7666	6 months ago
Shivani Bhardwaj	d241237c0f	Revert "dcerpc: fix consumed bytes post gap handling" ... This reverts commit fc9da1c7a1. That commit incorrectly used consumed as index of the slice passed to the Frame API. Found by oss-fuzz.	6 months ago
Jeff Lucovsky	ed882ede68	output/ipv6: Utility function to compress IPv6 addrs ... Issue: 7399 Utility function to compress IPv6 addresses per RFC-5952	6 months ago
Giuseppe Longo	de46f4ba9d	ldap: set invalid_data event ... Currently in parse_request function LdapEvent::InvalidData is not set when a request is not parsed correctly. Ticket #8258	6 months ago
Victor Julien	b55be5a44f	detect/transforms: update gunzip / zlib_deflate syntax ... Use standard space separated syntax.	6 months ago