599d33c5bf
ldap: return empty buffer in ldap_tx_get_responses_dn
...
Funciton ldap_tx_get_responses_dn returns empty buffer in case
the response doesn't contain the distinguished name field
Fixes: 73ae6e997f
2 years ago
82ca3e667b
ldap: fix LDAPDN nits
...
Change variable name 'req' to 'resp' in function ldap_tx_get_responses_dn and documentation nits
Fixes:
73ae6e997f16dcee46fc
2 years ago
3b6106e8f4
ldap: apply rustfmt
...
Fixes: 4554c4778d
2 years ago
544469780a
ci: fix clusterfuzzlite build
2 years ago
93bd1935bb
github-actions: bump actions/upload-artifact from 4.6.0 to 4.6.1
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65c4c4a1dd...4cec3d8aa0
2 years ago
2d7937b3ce
github-actions: bump codecov/codecov-action from 5.3.1 to 5.4.0
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.3.1 to 5.4.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](13ce06bfc6...0565863a31
2 years ago
5d38c4de19
github-actions: bump github/codeql-action from 3.28.8 to 3.28.10
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.8 to 3.28.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Commits](https://github.com/github/codeql-action/compare/v3.28.8...v3.28.10 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
47e08ee48e
github-actions: bump actions/download-artifact from 4.1.8 to 4.1.9
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.8 to 4.1.9.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](fa0a91b85d...cc20338598
2 years ago
03b113f7e3
github-actions: bump ossf/scorecard-action from 2.4.0 to 2.4.1
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](62b2cac7ed...f49aabe0b5
2 years ago
2e52e9501f
mqtt: naming and visibility cleanups
...
- remove rs_prefix, replace with SC if needed
- remove pub and no_mangle where not needed
- remove some unused functions and fields
Related to ticket: #7498
2 years ago
0fe11cdfe5
enip: remove rs_ prefix
...
Related to ticket: #7498
2 years ago
c726d67bb0
dcerpc: visibility and naming cleanups
...
- replace rs_ prefixed names with SC
- remove no_mangle and pub where not needed
- remove some unused functions
Related to ticket: #7498
2 years ago
f0116c3a6b
bittorrent: no_mangle, pub and naming cleanups
...
- Remove rs_prefix
- Remove no_mangle and pub when not needed
Related to ticket: #7498
2 years ago
05dd607f34
rust: use CBINDGEN variable and not "cbindgen"
...
This uses the cbindgen found during ./configure, and not the one
found on the path during "make", which while often the same, aren't
always the same.
Ticket: #6384
2 years ago
1b27febdd8
github-ci: re-enable RPM builds
...
The RPM has been updated to handle the conversion of suricatasc and
suricatactl to Rust.
Also fixes the "if" expression to prevent one job running both upload
sections.
2 years ago
9b088ed018
applayer/ftp: Misc cleanup
...
Issue: 4082
Small fixups.
2 years ago
b7d240fb14
applayer/ftp: Move MPM declaration
...
This commit moves the MPM fn declaration into core.rs making it
available for other Rust modules.
Issue: 4082
2 years ago
4d0cf8a8fa
app-layer/ftp: Fixup state values
...
Issue: 4082
Fixup the incorrect state values -- they should be the default enum
values to match the pre-Rust implementation.
2 years ago
0dc5b72c89
github-ci: skip rpm builds for now
...
RPMs will need to be fixed after merge.
2 years ago
1dcb1e3f29
github-ci: add var to disable rpm builds
...
There will be changes in our development branch that the RPMs need to
adapt to, but that can't be done until the changes have been merged to
master, then the RPM can catchup.
This gives us a single variable to turn off RPM building.
2 years ago
f1d305b373
doc: add upgrade note about suricatasc and suricatactl
2 years ago
1aa47649ca
dist: include generate-evedoc.sh
...
Without this script `make distcheck` fails on a system with
documentation tooling installed, as its required to build the EVE
appendix.
2 years ago
357822c68c
github-ci: add check for update to date Cargo.lock.in
...
After a build, check if Cargo.lock.in and Cargo.lock differ, if so,
Cargo.lock.in needs an update as part of a depedency update.
2 years ago
11a589f633
doc: remove python references related to suricatasc
...
These should probably be removed even without the rewrite, and
suricatasc has been installed as a proper program for many releases.
2 years ago
fc2824a9f7
qa: fix suricatasc path
2 years ago
a0089190df
python: remove python implementation of suricatasc/suricatactl
2 years ago
8fa347410e
suricatactl: rust version of suricatactl
2 years ago
7e4de3d1b9
github-ci: do one Windows build from dist archive
...
As we have 2 Windows builds, do one using the release-style
distribution file.
2 years ago
8115669602
suricatasc: a Rust implementation of suricatasc
...
This is a re-implementation of suricatasc program in Rust that
attempts to be a 100% drop-in replacement.
2 years ago
c33bebd630
rust: remove allow of static mutables
...
As references to static mutables are highly discouraged, remove the
global suppressing of the compiler warning. Each use case can be
suppressed as needed.
Ticket: #7417
2 years ago
4a2f10d235
smb: wrap read access to static mutables in function
...
Simply wrapping in a function removes static_mut_refs compiler
warning.
Ticket: #7417
2 years ago
d8c080b268
smtp: suppress static_mut_refs where needed
...
Allows us to get rid of the global supression.
Ticket: #7417
2 years ago
9ed5b4c002
smtp: remove SCMimeSmtpConfigExtractUrlsSchemeReset
...
It doesn't appear to be needed. The vec being cleared is only set once
per run, so never needs to be cleared.
Removes one point where we have to supress the static_mut_refs compiler
warning.
Ticket: #7417
2 years ago
97ee95c1a2
dns: move unit tests to suricata-verify
...
Ticket: 3725
Ticket: 7529
2 years ago
49d4686144
main/flush: Support periodic flush logs
...
Issue: 3449
2 years ago
36111450ac
detect/flag: Pseudo pkt "flush log" flag
...
Issue: 3449
Add a flush directive to the packet that is distinct from the existing
"log flush" flag as the new flag is to distinguish between the 2 use
cases.
2 years ago
b18622554d
output/log: Add flushing infrastructure
...
Issue: 3449
Add flushing functions and infrastructure. This includes:
- Flushing functions for packet loggers
- Log file flushing support
2 years ago
04767f69fc
output: Support buffer-size value
...
Issue: 3449
2 years ago
a3a3ad8968
doc/output: EVE output buffering related settings
2 years ago
92b2aebe75
conf/output: Buffering related config settings
...
This commit adds 2 EVE output buffering settings
- buffer-size value which specifies the amount of buffering, if any,
for regular/file output types.
- flush-interval Specifies the cadence at which Suricata will direct
detect threads to flush EVE output.
Issue: 3449
2 years ago
7621029507
output/log: Add flush function, collapse params
...
Issue: 3449
Add a flush function to packet logger registration and collapse the
parameter count for registration functions.
2 years ago
80dbaac206
flow: remove unused definition
...
Fixes: 3f3964555e
2 years ago
e1446c30fa
detect/alert: optimize no-alert path
...
Skip qsort call if no alerts are queued. Move logic into inline helper func.
2 years ago
98423a0009
detect: constify arguments
2 years ago
39b030b791
detect/tx: improve branch prediction
2 years ago
1000b0cf33
app-layer: optimize pstate check
...
To assist branch prediction, which showed a 100% miss rate, assume pstate
is non-NULL. Code review suggests all paths leading to the function actually
check pstate first, or alstate which can only be non-NULL if pstate was first
initialized. For now add a debug check.
2 years ago
99eda1504a
threads/flow: assist branch prediction
2 years ago
f876baab6b
detect/pmq: assist branch prediction
2 years ago
dd344bd07c
ftp: Move config file handling to Rust
...
Issue: 4082
Move the configuration file handling to Rust.
These changes will no longer terminate Suricata when there's an invalid
value for ftp.memcap. Like earlier Suricata releases, an error message
is logged "Invalid value <value> for ftp.memcap" but Suricata will no
longer terminate execution. It will use a default value of "0" instead.
2 years ago
f0410c93d0
ftp: convert enumerations to Rust
...
As part of the effort to convert the FTP/FTPDATA parser to rust, move
the enums from C to rust.
Issue: 4082
2 years ago
Alice Akaki
Philippe Antoine
dependabot[bot]
Jason Ish
Jeff Lucovsky
Victor Julien