41 Commits (50bb995458d49d01c0a13c0947edeb6b9d82c818)

Author	SHA1	Message	Date
Ken Steele	8f1d75039a	Enforce function coding standard ... Functions should be defined as: int foo(void) { } Rather than: int food(void) { } All functions where changed by a script to match this standard.	11 years ago
Victor Julien	82ae41d320	pool: on Init() error, properly clean up ... In the stream engine, Init() can fail if the memcap is reached. In this case the segment was not freed by PoolGet: ==8600== Thread 1: ==8600== 70,480 bytes in 1,762 blocks are definitely lost in loss record 611 of 612 ==8600== at 0x4C2A2DB: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==8600== by 0x914CC8: TcpSegmentPoolAlloc (stream-tcp-reassemble.c:166) ==8600== by 0xA0D315: PoolGet (util-pool.c:297) ==8600== by 0x9302CD: StreamTcpGetSegment (stream-tcp-reassemble.c:3768) ==8600== by 0x921FE8: StreamTcpReassembleHandleSegmentHandleData (stream-tcp-reassemble.c:1873) ==8600== by 0x92EEDA: StreamTcpReassembleHandleSegment (stream-tcp-reassemble.c:3584) ==8600== by 0x8D3BB1: HandleEstablishedPacketToServer (stream-tcp.c:1969) ==8600== by 0x8D7F98: StreamTcpPacketStateEstablished (stream-tcp.c:2323) ==8600== by 0x8F13B8: StreamTcpPacket (stream-tcp.c:4243) ==8600== by 0x8F2537: StreamTcp (stream-tcp.c:4485) ==8600== by 0x95DFBB: TmThreadsSlotVarRun (tm-threads.c:559) ==8600== by 0x8BE60D: TmThreadsSlotProcessPkt (tm-threads.h:142) tcp.segment_memcap_drop | PcapFile | 1762 This patch fixes PoolGet to both Cleanup and Free the Alloc'd data in case Init fails.	12 years ago
Victor Julien	7a0649f9c4	pool: rename data structure fields to stack ... Rename the following fields: - uint32_t alloc_list_size; + uint32_t alloc_stack_size; - PoolBucket *alloc_list; + PoolBucket *alloc_stack; - PoolBucket *empty_list; - uint32_t empty_list_size; + PoolBucket *empty_stack; + uint32_t empty_stack_size; To reflect that these are in fact, stacks.	12 years ago
Victor Julien	ee83809d8e	pool: remove tail tracking in alloc list ... The list fully acts like a stack now.	12 years ago
Victor Julien	4c9f9db770	pool: update internal counters at the proper time ... Only update Pool::outstanding and Pool::allocated in PoolGet when we are sure both Alloc and Init were successful.	12 years ago
Victor Julien	5b9ef94f34	pool: add api for per thread pools ... This API is a wrapper around the regular pools where the thread pools are arrays of locks+pools.	12 years ago
Victor Julien	016d03bdaf	pool: add error msgs and improve memory layout	12 years ago
Anoop Saldanha	d2063d98ad	pool now uses a queue kinda behaviour when getting/inserting data through poolbuckets.	12 years ago
Eric Leblond	e176be6fcc	Use unlikely for error treatment. ... When handling error case on SCMallog, SCCalloc or SCStrdup we are in an unlikely case. This patch adds the unlikely() expression to indicate this to gcc. This patch has been obtained via coccinelle. The transformation is the following: @istested@ identifier x; statement S1; identifier func =~ "(SCMalloc|SCStrdup|SCCalloc)"; @@ x = func(...) ... when != x - if (x == NULL) S1 + if (unlikely(x == NULL)) S1	13 years ago
Eric Leblond	655577cbbc	Add some missing checks of SCMalloc return.	13 years ago
Victor Julien	20d2db085e	reintroduce pool free func for cases where block alloc is not used.	13 years ago
Victor Julien	f962e3de29	pool: only alloc one large block if it will actually be used.	13 years ago
Eric Leblond	619014a280	pool: rename Free function to Cleanup ... This patch renames Free functions to Cleanup as the free is made by the pool system.	13 years ago
Eric Leblond	cd8d215724	pool: improve error handling ... Error handling during Pool creation was not perfect as a PoolBucket could leak.	13 years ago
Eric Leblond	bfd6dea38f	pool: update doxygen documentation.	13 years ago
Eric Leblond	fa079c1da0	pool: realize a block allocation for preallocated item. ... This patch required a evolution of Pool API as it is needed to proceed to alloc or init separetely. The PoolInit has been changed with a new Init function parameter.	13 years ago
Eric Leblond	cd76c7e5fb	pool: alloc a single area for all PoolBuckets ... As we know the number and the size of PoolBucket, we can simply allocate a single memory zone.	13 years ago
Victor Julien	8186565240	Fix a number of potential issues found by CLANG and cppcheck.	14 years ago
Gerardo Iglesias Galvan	a3e0325075	Don't loose memory if PoolInit fails	14 years ago
William Metcalf	2eef905c07	GPL and Copyright header updates.	15 years ago
Gerardo Iglesias Galvan	9f4fae5b1a	Fix inconsistent use of dynamic memory allocation	15 years ago
William Metcalf	ce01927515	Import of GPLv2 Header 050410	15 years ago
Pablo Rincon	25a3a5c6d8	Adding mem wrapper to debug runtime alloc()/free() functions. Fixing some memory leaks.	16 years ago
Victor Julien	6a53ab9c5a	Stream engine memory handling update ... The stream engine memory handling needed updating as it didn't scale. Changes: - pools can now be initialized to size 0, meaning unlimited - stream engine uses a memcap setting. Sessions, segments and aldata is part of this, app layer state isn't. - memory is accounted using a global int that is spinlocked. - a counter for sessions that have not been picked up because of memcap was added. - all reassembly errors are converted to debug msgs.	16 years ago
Victor Julien	0d34990d7f	Add OpenBSD's strlcpy and strlcat and replace all strcat/strcpy/strncat/strncpy by those calls.	16 years ago
Victor Julien	ecf86f9c23	Rename to Suricata.	16 years ago
Breno Silva	c43319c337	Regular expression for UnitTests ... Signed-off-by: Brian Rectanus <brectanu@gmail.com>	16 years ago
Victor Julien	91bc83e5c6	More logging API usage changes.	16 years ago
Victor Julien	0d0ffb9963	Reorganize header inclusions.	16 years ago
Victor Julien	edfddcb282	Clean up stream tests memory handling. Remove counters in the address handling that were thread unsafe.	16 years ago
Victor Julien	b102ea2123	Big update: ... - Implement "closing" state in flow. - Add protocol specific timeouts. - Lots of stream tracking updates, fixing a lot of out of window issues. - Stream reassembly fixes. - Implement a new IDS runmode with 4 stream and detect threads. - Added a BUG_ON macro that aborts the engine if the expression is true. - Better balance the flow queue handler for traffic that doesn't have flow (like icmp currently). - Simplify application level protocol in the Tcp Session. - Add some debugging memory counters.	16 years ago
Victor Julien	6eaff4be12	Fixes for issues found by static code analyzer.	16 years ago
Brian Rectanus	fa5939ca91	64 bit cleanup part2	16 years ago
Victor Julien	c5b2b8c082	valgrind memcheck: fix small pool memory leaks in the unittests.	16 years ago
Victor Julien	462a346bf6	Fix printf formatting error in a pool unittest.	16 years ago
Victor Julien	416bdd543a	Add unit test to pool for the bug from yesterday.	16 years ago
Victor Julien	77b19f6d82	Fix pool bug.	16 years ago
Victor Julien	de1639e263	Enforce max pool size.	16 years ago
Victor Julien	8bc0a2e465	Add tests for pool.	16 years ago
Victor Julien	668e9514d7	Pool update. Stream reassembly start.	16 years ago
Victor Julien	9c7f5afa79	Large update: pcap support, threading fixes, initial stream tracking, time handling, pool support, runmodes, decoders added, autojunk update.	16 years ago