272 Commits (4e1945415273bf58876c5da43c506af71ff5b6bc)

Author	SHA1	Message	Date
Victor Julien	389f166d78	file: remove FILE_USE_DETECT flag ... All implementations were converted to use the logic, so the flag itself can be removed.	2 years ago
Shivani Bhardwaj	d4e674b390	rust: fix clippy warnings	2 years ago
Philippe Antoine	668501c225	rust: remove unused	2 years ago
Lancer Cheng	abc76e27de	smb: fix data padding logic in writeAndX parser ... Bug: #6008	2 years ago
Lancer Cheng	000eb91078	smb: fix wrong data offset when wct = 12 ... Bug: #6008	2 years ago
Victor Julien	f9276fdf00	rust: spelling fixes ... Thanks to Josh Soref.	2 years ago
Victor Julien	ee7ed99b6f	rust: spelling	2 years ago
Victor Julien	d630f0fa34	rust: rustfmt files with recent new tests	2 years ago
Victor Julien	77f1658c2a	rust: fix new clippy warnings	2 years ago
Lancer Cheng	0cf742a9ca	smb: add unit tests ... Issue: 4865	2 years ago
tianjinshan	2c0c6cb0a5	smb/ntlmssp: fix parsing of negotiate flags ... Ticket: #5783	2 years ago
Jason Ish	b4f0d3c741	rust: update der-parser to 8.2.0 ... Minimal modifications required on the Suricata side, mainly for fields becoming private and needing an accessor instead. Note: As the kerberos parser still depends on der-parser 6.0, we still have to depend on that so it is depended on, but renamed to der-parser6. There is not an udpated kerberos-parser yet that uses der-parser 8.2.0. Ticket: #5991	2 years ago
Jason Ish	d2fb958e28	rust: fix clippy lint for assert ... Fix done automatically by clippy --fix	2 years ago
Lancer Cheng	9207012e4b	smb: fix parser of ntlmssp negotiateflags ... Fix endian-conversion bug in function parse_ntlm_auth_nego_flags Bug OISF#5783	2 years ago
Philippe Antoine	233ab11148	smb: handles records with trailing nbss data ... If a file (read/write) SMB record has padding/trailing data after the buffer being read or written, and that Suricata falls in one case where it skips the data, it should skip until the very end of the NBSS record, meaning it should also skip the padding/trailing data. Otherwise, an attacker may smuggle some NBSS/SMB record in this trailing data, that will be interpreted by Suricata, but not by the SMB client/server, leading to evasions. Ticket: #5786	2 years ago
Philippe Antoine	c1b7befb18	smb: checks against nbss records length ... When Suricata handles files over SMB, it does not wait for the NBSS record to be complete, and can stream the payload to the file... But it did not check the consistency of the SMB record length being read or written against the NBSS record length. This could lead to an evasion where an attacker crafts a SMB write with a too big Length field, and then sends its evil payload, even if the server returned an error for the write request. Ticket: #5770	2 years ago
Jason Ish	717e2b0248	smb: fix duplicate interface logging ... An array of interfaces was being logged without creating an array, resulting in duplicate "interface" objects being logged. Instead put these interfaces into an array like already done elsewhere. Issue: 5814	2 years ago
Jason Ish	67baab573b	smb: remove duplicate tree_id logging ... Remove the second occurrence of tree_id logging which appears to always be a duplicate of the first tree_id logged, even though they come from different data structures. Issue: 5811	2 years ago
Jason Ish	7080ecbb76	rust: remove explicit lifetimes where not needed	2 years ago
Victor Julien	37f13a4fc7	smb: set defaults for file transfer limits ... Ticket: #5782.	2 years ago
Victor Julien	6cc9811edd	files: move FileContainer into FileTransferTracker ... Update SMB, NFS, HTTP2.	2 years ago
Victor Julien	e3e55406a7	files: update API and callers to take stream config ... This is to allow not storing the stream buffer config in each file.	2 years ago
Victor Julien	71bc9e75f5	app-layer: get sbconfg with files	2 years ago
Victor Julien	4b1e9f7c21	smb: explicity free files ... In preparation of adding an argument to the free functions which means the drop trait can't be used anymore.	2 years ago
Victor Julien	33f6a16290	smb: file handling cleanups	2 years ago
Philippe Antoine	55c4834e4e	smb: configurable max number of transactions per flow ... Ticket: #5753	2 years ago
Philippe Antoine	1d9183638f	smb: convert transaction list to vecdeque ... Allows for more efficient removal from front of the list. Ticket: #5753	2 years ago
Philippe Antoine	cb89192ec3	smb: fix typo in comment	2 years ago
Philippe Antoine	3979acb5ed	smb: set event for ntlmssp unusual order	2 years ago
Philippe Antoine	e41c01a483	smb: rustfmt ntlmssp_records.rs	2 years ago
Philippe Antoine	1db8685848	smb/ntlmssp: parse fields independently of order ... Instead of relying on the usual ordering... Ticket: #5258	2 years ago
Jason Ish	da12b77f18	rust/clippy: fix lint: new_without_default	2 years ago
Jason Ish	e8823644ec	rust/clippy: fix lint: nonminimal_bool	2 years ago
Jason Ish	5d62995e26	rust/clippy: fix lint: explicit_counter_loop	2 years ago
Jason Ish	f250b92180	rust/clippy: fix lint: extra_unused_lifetimes	2 years ago
Jason Ish	c026d8531b	rust/clippy: fix lint: match_ref_pats	2 years ago
Jason Ish	359d5fcb7e	rust/clippy: fix lint: needless_lifetimes	2 years ago
Jason Ish	f15ffbc869	rust/clippy: fix lint: single_match ... Allow this lint in some cases where a match statement adds clarity.	2 years ago
Victor Julien	45eb038e63	smb: fix file reopening issue ... Fuzzing highlighted an issue where a command sequence on the same file id triggered a logging issue: file data for id N close id N file data for id N If this happened in a single blob of data passed to the parser, the existing file tx would be reused, the file "reopened", confusing the file logging logic. This would trigger a debug assert. This patch makes sure a new file tx is created for the file data coming in after the first file tx is closed. Bug: #5567.	2 years ago
Philippe Antoine	af44504550	smb: do not use tree id to match request and response ... Completes commit e94920b49f This must be true for access to state ssn2vecoffset_map Ticket: #5161	2 years ago
Philippe Antoine	286bd2a7ed	rust: fix cargo clippy --all-features	2 years ago
Philippe Antoine	bc287018e5	rust: cargo clippy --all-features --fix --allow-no-vcs	2 years ago
Kristina Jefferson	9cd00424c3	rust: fix lint warnings about ptr_arg ... Ticket: #4599	2 years ago
Jason Ish	21bb697bc9	rust: fix clippy lint for unneeded late initialization	2 years ago
Jason Ish	f0952aef0d	rust: fix clippy lints for unneeded reference in debug code	2 years ago
Jason Ish	04f0ee0151	rust: fix clippy lints for clippy::unnecessary_cast	2 years ago
Jason Ish	b6cc0e25b1	rust: fix clippy lints for clippy::redundant_static_lifetimes	2 years ago
Jason Ish	119e02cf81	rust: fix clippy lints for clippy::collapsible_if	2 years ago
Jason Ish	6b71d69356	rust: fix clippy lints for clippy::bool_comparison	2 years ago
Jason Ish	565da0d0af	rust: fix clippy lints for clippy::redundant_field_names	2 years ago