52 Commits (43cc06eabeca8d1bdf8456e98e61d004bf226367)

Author	SHA1	Message	Date
Victor Julien	bfd4bc8233	detect: constify Signature/SigMatch use at runtime	9 years ago
Victor Julien	2758f82515	flowvar: cleanups	9 years ago
Victor Julien	408948815f	detect: simplify flow locking ... To simplify locking, move all locking out of the individual detect code. Instead at the start of detection lock the flow, and at the end of detection unlock it. The lua code can be called without a lock still (from the output code paths), so still pass around a lock hint to take care of this.	9 years ago
Victor Julien	e67ae0f174	detect keywords: use parse regex util func	9 years ago
Victor Julien	dea8dda3c1	vars: redo var name <-> idx handling ... Can't use sm type anymore as multiple var carriers (host/flow/etc) will all have xbits.	10 years ago
Victor Julien	5111aa2ec0	detect-state: handle 'post match' locking ... The post match list was called with an unlocked flow until now. However, recent de_state handling updates changed this. The stateful detection code can now call the post match functions while keeping the flow locked. The normal detection code still calls it with an unlocked flow. This patch adds a hint to the DetectEngineThreadCtx called 'flow_locked' that is set to true if the caller has already locked the flow.	10 years ago
Ken Steele	923a77e952	Change Match() function to take const SigMatchCtx* ... The Match functions don't need a pointer to the SigMatch object, just the context pointer contained inside, so pass the Context to the Match function rather than the SigMatch object. This allows for further optimization. Change SigMatch->ctx to have type SigMatchCtx* rather than void* for better type checking. This requires adding type casts when using or assigning it. The SigMatch contex should not be changed by the Match() funciton, so pass it as a const SigMatchCtx*.	11 years ago
Ken Steele	b96645ded2	Create a wrapper around DetectFlowvarProcessList() to check for empty list ... Creates an inline wrapper to check for flowvarlist == NULL before calling DetectFlowvarProcessList() to remove the overhead of checking since the list is usually empty.	11 years ago
Ken Steele	8f1d75039a	Enforce function coding standard ... Functions should be defined as: int foo(void) { } Rather than: int food(void) { } All functions where changed by a script to match this standard.	11 years ago
Eric Leblond	28c5c68192	error checking: add missing alloc error treatment ... The return of some malloc like functions was not treated in some places of the code.	12 years ago
Victor Julien	b4e6bbe4bc	flowvar: initialize new memory to prevent issues on error handling	12 years ago
Victor Julien	6e18ed0489	luajit flowvar support ... This patch adds flowvar support to luajit. It does so by exposing two special C functions to the luajit scripts: ScFlowvarGet and ScFlowvarSet.	12 years ago
Victor Julien	6ba52230ed	Update DetectContentDataParse to reflect the actual data types content uses.	12 years ago
Victor Julien	8023007fbd	flowvar: cleanup keyword argument parsing. Should also address Coverity 400655.	12 years ago
Victor Julien	07b751b0df	Coverity 1005134: fix minor memory leak on flowvar rule setup errors.	12 years ago
Victor Julien	00a691fc1b	flowvar: clean up properly on signature clean up.	12 years ago
Victor Julien	4cd736fcc9	flowvar: fix deadlock with http buffers ... Bug #802 Flowvars are set from pcre, and lock the flow when being set. However when HTTP buffers were inspected, flow was already locked: deadlock. This patch introduces a post-match list in the detection engine thread ctx, where store candidates are kept. Then a post-match function is used to finalize the storing if the rule matches. Solves the deadlock and brings the handling of flowvars more in line with flowbits and flowints.	12 years ago
Victor Julien	a698a7600d	clang: fix warnings when debug is enabled	13 years ago
Victor Julien	84bad6db77	Silence compiler warnings found by clang	13 years ago
Eric Leblond	e176be6fcc	Use unlikely for error treatment. ... When handling error case on SCMallog, SCCalloc or SCStrdup we are in an unlikely case. This patch adds the unlikely() expression to indicate this to gcc. This patch has been obtained via coccinelle. The transformation is the following: @istested@ identifier x; statement S1; identifier func =~ "(SCMalloc|SCStrdup|SCCalloc)"; @@ x = func(...) ... when != x - if (x == NULL) S1 + if (unlikely(x == NULL)) S1	13 years ago
Anoop Saldanha	f2dd61868d	variable names global vars, global no more. Moved to detection engine ctx, a place it belongs	13 years ago
Victor Julien	19a7e7f395	flow: create a flow lock macro API, implement it for mutex and rwlocks. Mutex remains the default.	14 years ago
Anoop Saldanha	a4638fb0ad	code cleanup - replace SigMatchAppendPacket with SigMatchAppendSMToList	14 years ago
Victor Julien	e19f6ebaf4	Various fixes for issues reported by clang.	15 years ago
Gurvinder Singh	8852b83fa7	flowbits, flowvars, pktvars, flow flags and app layer info added to alert-debug.log	15 years ago
William Metcalf	2eef905c07	GPL and Copyright header updates.	15 years ago
Gerardo Iglesias Galvan	9f4fae5b1a	Fix inconsistent use of dynamic memory allocation	15 years ago
William Metcalf	ce01927515	Import of GPLv2 Header 050410	15 years ago
Victor Julien	8b30226914	Detection keyword cleanup	16 years ago
Victor Julien	b259e362cd	Convert uricontent to use new scanning methods as well. Move http_method and http_cookie keywords out of pmatch list for now.	16 years ago
Pablo Rincon	25a3a5c6d8	Adding mem wrapper to debug runtime alloc()/free() functions. Fixing some memory leaks.	16 years ago
Gerardo Iglesias Galvan	ba6d807a6e	Improve information about errors on signature failure	16 years ago
Steve Grubb	60ad9d29c5	Memory leak cleanup in detectors ... Hello, I ran the code through an analysis program and found several leaks that should be cleaned up. *In src/detect-engine-address-ipv4.c at line 472, the test for ag == NULL will never be true since that is the loop entry test. *In src/detect-engine-port.c at line 1133, the test for p == NULL will never be true since that is the loop entry test. *In src/detect-engine-mpm.c at line 263 is a return without freeing fast_pattern *In src/detect-ack.c at line 80 and 85, data catches the return from malloc. One of them should be deleted. *In src/detect-seq.c at line 81 and 86, data catches the return from malloc. One of them should be deleted. *In src/detect-content.c at line 749, many of the paths that lead to the error exit still has temp pointing to allocated memory. To clean this up, temp should be set to NULL if not immediately assigning and new value. *In src/detect-uricontent.c at line 319, both cd and str needto be freed. At lines 344, str needs to be freed. And at line 347 str and temp need to be freed. *In src/detect-flowbits.c at line 231 and 235, str was not being freed. cd was not being freed at line 235. *In src/detect-flowvar.c at line 127, str was not being freed. At line 194, cd and str were not being freed. *In src/detect-flowint.c at line 277, sfd was not being freed. At line 315, str was not being freed. *In src/detect-pktvar.c at line 121, str was not being freed. At line 188, str and cd was not being freed. *In src/detect-pcre.c at line 389, there is an extra free of "re" that should be deleted. *In src/detect-depth.c at line 42 & 48, str has not been freed. *In src/detect-distance.c at line 49 and 55, str has not been freed *In src/detect-offset.c at line 45, str has not been freed. The patch below fixes these issues. -Steve	16 years ago
Pablo Rincon	705471e4ee	Adding single pattern matcher algorithms. If you cannot store a context for the patterns, use SpmSearch() macro. Adding unittests and stats	16 years ago
Victor Julien	ecf86f9c23	Rename to Suricata.	16 years ago
Gurvinder Singh	a0f184866c	http_cookie keywork support	16 years ago
Pablo Rincon	a8d7b71490	First version of flowints	16 years ago
Pablo Rincon	e26833be3f	Changing mutex/spinlocks/conditions naming types	16 years ago
Pablo Rincon	769022f4be	Adding support for Mac OS X, FreeBSD, centrailizing mutex/spins/conditions in a macro API, and some unittests	16 years ago
Victor Julien	968d8df12b	More logging API usage. Changed logging macro's slightly so the vars inside them won't conflict with vars used by the calling function.	16 years ago
Victor Julien	0d0ffb9963	Reorganize header inclusions.	16 years ago
Victor Julien	1727d191a4	Add pktvar and flowvar tests to ip only unittest. Make output cleaner.	16 years ago
Victor Julien	39724df664	2nd try of fixing some bugs reported by static code analysis tool.	16 years ago
Victor Julien	6eaff4be12	Fixes for issues found by static code analyzer.	16 years ago
Victor Julien	1132ab635a	Rename all pmt->det_ctx.	16 years ago
Victor Julien	b9972a9d2c	Cleanups	16 years ago
Victor Julien	451adaff34	Small name support code update for flowbits, flowvars and pktvars.	16 years ago
Brian Rectanus	fa5939ca91	64 bit cleanup part2	16 years ago
Victor Julien	766ebed4d4	Fix Flowvar idx retrieval.	16 years ago
Victor Julien	ff4b5a5db7	Add support for flowbits.	16 years ago