22 Commits (3b1558946dff9e0466910273c2588e3071d19cb5)

Author	SHA1	Message	Date
Victor Julien	edf93ae5b6	decode/mpls/tests: improve pkt handling; cleanups	3 years ago
Philippe Antoine	73ed780095	decode: fix integer warnings ... Ticket: 4516	3 years ago
Juliana Fajardini	a6bda3596b	unittests: alloc Packet with PacketGetFromAlloc ... Some unittests used SCMalloc for allocating new Packet the unittests. While this is valid, it leads to segmentation faults when we move to dynamic allocation of the maximum alerts allowed to be triggered by a single packet. This massive patch uses PacketGetFromAlloc, which initializes a Packet in such a way that any dynamic allocated structures within will also be initialized. Related to Task #4207	3 years ago
Jeff Lucovsky	83067e5a55	decode: Eliminate NULL pkt checks ... This commit removes the NULL pkt check that each decoder performs as this is a "can't happen" case.	4 years ago
Philippe Antoine	7500c29300	decode: limits the number of decoded layers ... so as to avoid overrecursion leading to stack exhaustion	5 years ago
Victor Julien	f8aed4ce2d	threading: change local packet queue logic ... Previously each 'TmSlot' had it's own packet queue that was passed to the registered SlotFunc as an argument. This was used mostly for tunnel packets by the decoders and by defrag. This patch removes that in favor of a single queue in the ThreadVars: decode_pq. This is the non-locked version of the queue as this is only a temporary store for handling packets within a thread. This patch removes the PacketQueue pointer argument from the API. The new queue can be accessed directly through the ThreadVars pointer.	6 years ago
Victor Julien	579cc9f02b	const: constify decoder, app-layer, detect funcs	6 years ago
Jason Ish	b8ce7f2885	mpls: check buffer length before peeking at next header ... Check that we have enough bytes before peaking into the MPLS packet payload. Redmine issue: https://redmine.openinfosecfoundation.org/issues/2884	6 years ago
Jason Ish	164fb71898	mpls: fix misaligned read ... Instead of casting the packet buffer to a uint32, memcpy it to avoid misaligned read error, as caught by the undefined behavior detector (ubsan). Redmine issue: https://redmine.openinfosecfoundation.org/issues/2903	6 years ago
Maurizio Abba	55b14f3721	decode: set pktlen of decode handler to uint32 ... Change the decode handler signature to increase the size of its decode handler, from uint16 to uint32. This is necessary to let suricata use interfaces with mtu > 65535 (ex: lo interface has default size 65536). It's necessary to change several primitive for Packet manipulation, to unify the parameter "packet length" whenever we are before IP decoding. Add tests before calling DecodeIPVX function to avoid a possible integer overflow over the len parameter.	7 years ago
Victor Julien	11be9bd971	mingw: add SCNtohl and SCNtohs macro's ... On MinGW the result of ntohl needs to be casted to uint32_t and the result of ntohs to uint16_t. To avoid doing this everywhere add SCNtohl and SCNtohs macros.	8 years ago
Jason Ish	796dd5223b	tests: no longer necessary to provide successful return code ... 1 pass, 0 is fail.	10 years ago
Victor Julien	1c0b4ee0ae	counters: s/SCPerfCounterIncr/StatsIncr/g	10 years ago
Victor Julien	e9b067c1eb	counters: make increment call take threadvars ... This hides the implementation from the caller.	10 years ago
Victor Julien	9a8bff7d96	counters: threadvars s/sc_perf_pca/perf_private_ctx/g	10 years ago
Jason Ish	2d12209194	Use ENGINE_SET_INVALID_EVENT when the packet is too small for an ... MPLS header, and when the payload type can not be determined.	11 years ago
Jason Ish	65f40cbeaa	Don't default to ethernet, ethernet should be preceded by a pseudowire. ... If the payload type can't be determined, raise an alert.	11 years ago
Jason Ish	348b0e0e9f	Set decoder events for labels that shouldn't be seen on the wire. ... Add unit tests to test for mpls decoder events.	11 years ago
Jason Ish	66a321ca2d	Handle encapsulated ethernet without a PW by defaulting to ethernet ... if a fall back.	11 years ago
Jason Ish	025342dc6c	Handle explicitly IPv6 and IPv6 labels as well as encapsulated ethernet.	11 years ago
Jason Ish	3e3ab2dc9f	Add MPLS counter. ... Check length before decoding each label.	11 years ago
Jason Ish	7642489874	Basic MPLS decoder.	11 years ago