Philippe Antoine
8461e3f3e7
src: do not include "util-unittest.h" directly
...
It is included in suricata-common.h
Ticket: 945
3 weeks ago
Victor Julien
3f4af00fdd
counters: remove ThreadVars from API
11 months ago
Victor Julien
70096873ce
counters: threadvar init func
...
Add initializion.
Also fixes DetectDsizeIcmpv6Test01 using two different ThreadVar
structs.
11 months ago
Victor Julien
efc19868c6
unittests: clean up memory for detect rpc tests
1 year ago
Philippe Antoine
a2b5225612
rust: bindgen SCSigMatchAppendSMToList
...
Ticket: 7667
1 year ago
Victor Julien
5c3036bea8
decode/udp: add and use PacketIsUDP inline func
...
Replace PKT_IS_UDP macro with PacketIsUDP inline function.
For better readability and type checking.
Ticket: #5517 .
3 years ago
Victor Julien
cca912e9b3
decode/tcp: add and use PacketIsTCP inline func
...
To prepare future changes to the Packet header pointers.
Ticket: #5517 .
3 years ago
Philippe Antoine
c272a646c5
detect: SigMatchAppendSMToList can fail
...
Ticket: #6104
And failures should be handled to say that the rule failed to load
Reverts the fix by 299ee6ed55
that was simple, but not complete (memory leak),
to have this bigger API change which simplifies code.
3 years ago
Jeff Lucovsky
3286c3b912
detect/pcre: Use local match variables
...
pcre2 is not thread-safe wrt match objects so use locally scoped
objects.
Issue: 4797
3 years ago
Victor Julien
b31ffde6f4
output: remove error codes from output
4 years ago
Victor Julien
39f5c7f56a
error: use SC_EINVAL for invalid input
4 years ago
Philippe Antoine
1f066cbbe8
unittest: fix unneeded includes as per cppclean
...
Especially because there is conditional inclusion from a header
4 years ago
Victor Julien
e250ef6402
debug: remove empty header
4 years ago
Philippe Antoine
02f2602dde
src: rework includes as per cppclean
4 years ago
Philippe Antoine
3de99a214c
pcre2: migrate keywords parsing
5 years ago
Juliana Fajardini
97350d9a2c
detect/rpc: clean up unittests
...
- detect-rpc: convert unit tests to new FAIL/PASS API.
- detect-rpc: replace SigInit with DetectEngineAppendSig for more
concise code.
6 years ago
Victor Julien
6ab323d323
detect: hide RegisterTests behind ifdef UNITTESTS
...
Update all callers to more aggressively use UNITTESTS guards as well.
6 years ago
Victor Julien
26bcc97515
detect/keywords: dynamic version part of doc URL
7 years ago
Jeff Lucovsky
d3a65fe156
detect: Provide `de_ctx` to free functions
...
This commit makes sure that the `DetectEngineCtx *` is available
to each detector's "free" function.
7 years ago
Shivani Bhardwaj
0e4f261224
Use StringParse* for all parsers and configurations
7 years ago
Jeff Lucovsky
7f6af10fed
general: copyright bump
7 years ago
Jeff Lucovsky
4b0085b03c
detect: Update to take advantage of PCRE refactor
...
This commit changes the keyword detectors to use the refactored PCRE
modifications from detect-parse.[ch]
7 years ago
Victor Julien
14896365ef
detect: remove Threadvars argument from API calls
...
Remove it as it's (almost) never used. If it is really needed it can
be accessed through DetectEngineThreadCtx::tv as well.
7 years ago
Victor Julien
11be9bd971
mingw: add SCNtohl and SCNtohs macro's
...
On MinGW the result of ntohl needs to be casted to uint32_t and
the result of ntohs to uint16_t. To avoid doing this everywhere
add SCNtohl and SCNtohs macros.
9 years ago
Victor Julien
7e72553ff8
gcc7: fix format truncation warning
...
detect-rpc.c: In function ‘DetectRpcParse’:
detect-rpc.c:225:50: error: ‘%s’ directive argument is null [-Werror=format-truncation=]
SCLogError(SC_ERR_INVALID_VALUE, "invalid rpc option %s",args[i]);
^
util-debug.h:239:77: note: in definition of macro ‘SCLogErr’
int _sc_log_ret = snprintf(_sc_log_msg, SC_LOG_MAX_LOG_MSG_LEN, __VA_ARGS__); \
^~~~~~~~~~~
detect-rpc.c:225:17: note: in expansion of macro ‘SCLogError’
SCLogError(SC_ERR_INVALID_VALUE, "invalid rpc option %s",args[i]);
^~~~~~~~~~
9 years ago
Victor Julien
ab1200fbd7
compiler: more strict compiler warnings
...
Set flags by default:
-Wmissing-prototypes
-Wmissing-declarations
-Wstrict-prototypes
-Wwrite-strings
-Wcast-align
-Wbad-function-cast
-Wformat-security
-Wno-format-nonliteral
-Wmissing-format-attribute
-funsigned-char
Fix minor compiler warnings for these new flags on gcc and clang.
10 years ago
Victor Julien
bfd4bc8233
detect: constify Signature/SigMatch use at runtime
10 years ago
Eric Leblond
a2e2f50fb9
documentation: fix list keywords URLs
...
Update URLs in keyword definition to point to sphinx documentation.
10 years ago
Victor Julien
e67ae0f174
detect keywords: use parse regex util func
11 years ago
Jason Ish
796dd5223b
tests: no longer necessary to provide successful return code
...
1 pass, 0 is fail.
11 years ago
Victor Julien
9bd8197009
detect-address: remove debug mem counters
11 years ago
Victor Julien
e0111fbb90
detect grouping: remove debug mem counters
11 years ago
Ken Steele
923a77e952
Change Match() function to take const SigMatchCtx*
...
The Match functions don't need a pointer to the SigMatch object, just the
context pointer contained inside, so pass the Context to the Match function
rather than the SigMatch object. This allows for further optimization.
Change SigMatch->ctx to have type SigMatchCtx* rather than void* for better
type checking. This requires adding type casts when using or assigning it.
The SigMatch contex should not be changed by the Match() funciton, so pass it
as a const SigMatchCtx*.
12 years ago
Ken Steele
8f1d75039a
Enforce function coding standard
...
Functions should be defined as:
int foo(void)
{
}
Rather than:
int food(void) {
}
All functions where changed by a script to match this standard.
12 years ago
Last G
8ae11f73b2
Added parentheses to fix Eclipse static code analysis
...
Fixed bug in action priority (REJECT_DST had lowest prio)
14 years ago
Eric Leblond
6842545331
Add documentation url in list-keyword output.
...
The output of the list-keyword is modified to include the url to
the keyword documentation when this is available. All documented
keywords should have their link set.
list-keyword can be used with an optional value:
no option or short: display list of keywords
csv: display a csv output on info an all keywords
all: display a human readable output of keywords info
$KWD: display the info about one keyword.
14 years ago
Eric Leblond
e176be6fcc
Use unlikely for error treatment.
...
When handling error case on SCMallog, SCCalloc or SCStrdup
we are in an unlikely case. This patch adds the unlikely()
expression to indicate this to gcc.
This patch has been obtained via coccinelle. The transformation
is the following:
@istested@
identifier x;
statement S1;
identifier func =~ "(SCMalloc|SCStrdup|SCCalloc)";
@@
x = func(...)
... when != x
- if (x == NULL) S1
+ if (unlikely(x == NULL)) S1
14 years ago
Anoop Saldanha
a4638fb0ad
code cleanup - replace SigMatchAppendPacket with SigMatchAppendSMToList
15 years ago
Anoop Saldanha
17f3f36d38
packet keywords only added for packet mpm. Rest in stream mpm. Update detection engine to handle the same
15 years ago
Victor Julien
014f62247a
Another batch of clang fixes. Nothing really serious. Includes a couple of fixes for broken fixes from yesterday.
16 years ago
Victor Julien
3f47eade6b
Fix couple of cases where incorrect handling of keyword parsing errors would lead to access of uninitialized memory. Found by clang.
16 years ago
Victor Julien
d1ce1c502b
Fix -Wall -Werror compilation after unittests update.
16 years ago
Victor Julien
1071a53210
Fix unittests after ip_proto keyword change.
16 years ago
Gerardo Iglesias Galvan
9f4fae5b1a
Fix inconsistent use of dynamic memory allocation
17 years ago
William Metcalf
ce01927515
Import of GPLv2 Header 050410
17 years ago
Victor Julien
e6ba571c0b
Rename structures that don't adhere to our naming conventions.
17 years ago
Victor Julien
8b30226914
Detection keyword cleanup
17 years ago
Victor Julien
b259e362cd
Convert uricontent to use new scanning methods as well. Move http_method and http_cookie keywords out of pmatch list for now.
17 years ago
Victor Julien
bef70a04ce
First stage of detect engine redesign: equal patterns share id's, search phase no longer used, new match verification phase.
17 years ago
Pablo Rincon
25a3a5c6d8
Adding mem wrapper to debug runtime alloc()/free() functions. Fixing some memory leaks.
17 years ago