Commit Graph

9365 Commits (345ec58df490a638d7052bb60264dd9f9cd70fda)
 

Author SHA1 Message Date
Jason Ish 345ec58df4 configure: allow for --disable-suricata-update
This is to prevent suricata-update from being installed if it
would otherwise be installed based on in being bundled, and
its dependencies being available.

Warn the user that Suricata-Update will not be installed if it
is bundled, but python-yaml is missing (this will also cover
the case where Python is missing).

Add "Install suricata-update" to the build summary. For consistency,
relable "Suricatasc install" as "Install suricatasc".
6 years ago
Jason Ish db36708756 configure: check for python-yaml
Don't install suricata-update if python-yaml does not
exist.
6 years ago
Jason Ish 5eb7f0f77c configure: print datarootdir
This is relevant now as its where Suricata engine rules
get installed.
6 years ago
Victor Julien 6f2b974f9c detect/mpm: fix fast_pattern handling of len >255
The fast pattern selection logic would truncate a patterns len to
255 leading to assigning the same pid to different patterns.

This in turn would be caught by the hyperscan setup code which would
abort.

Bug #2714.
6 years ago
Victor Julien eedf08be29 rust/filetracker: remove reachable panic
Remove reachable panic condition when an existing file chunk is not
completed. Instead trunc the file and reset.

Related to bug #2717
6 years ago
Victor Julien 1b1e136c4f nfs: improve file tracking under packet loss
In case of packet loss during an in-progress chunk the file tracker
could loose track of a file because it couldn't map the XID to a
file handle.

The file tracker would then panic if a new file was opened, as
it noticed the last chunk wasn't yet complete.

This patch tracks the file handle for a in-progress chunk in the
state, just like the tracking of the size that is left.

Bug #2717
6 years ago
Victor Julien 27f87567ca rust/nfs: improve debug output 6 years ago
Victor Julien 961610489a iprep: small cleanups 6 years ago
Victor Julien 5740c79b93 iprep: improve error checking of path handling 6 years ago
Victor Julien 0b3220a0df detect: improve inspect buffer handling
Fix and Optimize cleanup. For the simple single inspect buffer optimize
the cleanup by keeping track of the actually used buffers. This avoid
looping over unused buffers.

Fix the case of cleaning not being done after a tx if the next tx is
also inspected in the context of the same packet.

Fix cleanup of the multi-inspect buffers. Optimize in 2 ways. First
like with single keep track of which multi-inspect buffers have been
used. Second, keep a max of the buffers within a multi-inspect buffer.
Use this max to limit (nested) looping.
6 years ago
jason taylor 683be94830 profiling: set loop limit to match array size
Signed-off-by: jason taylor <jtfas90@gmail.com>
6 years ago
Victor Julien 5aef72efd1 prelude: fix potential uninitialized value use 6 years ago
Victor Julien ca1161d798 detect: suppress coverity deadcode warnings
Suppress as scan-build-7 relies on this 'dead' code to not issue
a warning.
6 years ago
Victor Julien 7b318592e6 filestore: suppress coverity toctou warning 6 years ago
Victor Julien cb2008fb27 detect: fix coverity memory leak warnings 6 years ago
Victor Julien 16100e592d file: use u32 file id everywhere 6 years ago
Victor Julien 59d526481c detect/distance: improve value parsing and fix broken test 6 years ago
Victor Julien 9cce1995ef detect/within: clean up option value parsing 6 years ago
Victor Julien 8814b994b5 detect/within: test cleanups 6 years ago
Victor Julien 1803af7aa6 eve/dns: improve version warning message 6 years ago
Victor Julien 758acd4b7e detect/offset: improve value parsing 6 years ago
Mats Klepsland b5dfc9ed41 app-layer-ssl: fix coverty error (RESOURCE_LEAK)
Bug #2677
6 years ago
Victor Julien 787473ec64 changelog: update for 4.1 6 years ago
Victor Julien 36e84b929c smtp/mime: fix null ptr deref on bad traffic
Due to missing error handling, a bad mime message could put the
mime parser in an error state, without the SMTP layer taking this
into account. So the SMTP layer would continue to pass data to the
mime parser, even though it was in an error state.

When the parser would be fed a very long line while in this state,
it would try to set an error flag in the state. However, due to
the error state, this setting of the flag would dereference a null
pointer.

This patch fixes this issue by updating the mime parser to check
the state it is in when receiving new input. It will refuse to
process futher data while in the error state. It will also return
a new error code to indicate to the SMTP layer that the parser
was in an error state.
6 years ago
Victor Julien fa2ce043cf ipv6: disable zero len padN rule by default 6 years ago
jason taylor 131112de13 doc: Remove gulp references
Signed-off-by: jason taylor <jtfas90@gmail.com>
6 years ago
jason taylor fc54d750dd doc: add bypass keyword documentation
Signed-off-by: jason taylor <jtfas90@gmail.com>
6 years ago
Jason Ish 961931e73a filestore: fix compiler truncation warnings
And error out if the constructed filename is truncated.
6 years ago
Mats Klepsland 033e756905 app-layer-ssl: add Facebook TLSv1.3 draft versions
Add draft versions for Facebooks custom TLSv1.3 implementation "fizz"
to SSLVersionToString().
6 years ago
Mats Klepsland dd5374c20d app-layer-ssl: change how TLSv1.3 drafts are logged
Change from logging TLSv1.3 drafts as "TLS 1.3 (draft 28)" to
"TLS 1.3 draft-28" instead.
6 years ago
Mats Klepsland be8c06adfd userguide: add documentation for ssl_version keyword 6 years ago
Victor Julien 9291d434c6 pfring: default to runmode workers
Now that threads:auto is implemented workers is a better default
as it generally performs better.
6 years ago
Victor Julien 1467c30883 pfring: implement 'threads: auto'
If threads is set to auto, first try the CPU count. If that would
fail, fall back to RSS queue count.
6 years ago
Victor Julien 5f2831d60f pfring: support checking/disabling offloading 6 years ago
Victor Julien 7c02b40be6 pfring: fix bypass counter print uninitialized values
If the option was disabled in the config the value would be uninitialized.
6 years ago
Victor Julien 1360e030b1 storage: don't leak memory for unittests 6 years ago
Victor Julien 121b3021df radix: fix a memleak when removing the last node 6 years ago
Victor Julien 3836fe2353 detect/address: minor memory handling cleanups 6 years ago
Victor Julien 00e9fd7a36 detect: suppress scan-build warnings 6 years ago
Victor Julien 0a39e06535 detect/flags: cleanup parsing to not alloc temp strings 6 years ago
Victor Julien e22a833b94 mpm: fix minor scan-build warning 6 years ago
Victor Julien e180576afe pool: avoid possible double free in error path
Should be impossible as a double free, but scan-build-7 thinks it
is possible.
6 years ago
Victor Julien 7ce1ebe0d3 pool: small code cleanups 6 years ago
Victor Julien 478caac975 stream: don't assume malformed TCP packets
This deep in the stream engine packets are valid, so don't check
for the tcph header in a packet as it confuses scan-build.

Do add a DEBUG_VALIDATE_BUG_ON so in QA we double check.
6 years ago
Victor Julien cf37faff31 decode/tcp: rewrite options decoding to assist scan-build 6 years ago
Victor Julien 347e64e8d4 smb/c: don't accept null input 6 years ago
Victor Julien ce1753c715 htp: fix potential (but unlikely) memleak in uri normalization 6 years ago
Victor Julien 7ef8d31e4f thresholds: remove dead code in parsing 6 years ago
Victor Julien 8ef0818c3b radix: fix memory leak in error path 6 years ago
Victor Julien 506f299b09 coverity: suppress warnings 6 years ago