Jeff Lucovsky
2c9c18a9d0
log/json: Convert log output to use JsonBuilder
...
This commit converts the file logging logic to use JsonBuilder instead
of libjansson.
2 years ago
Jeff Lucovsky
e7c2298203
config: Clarify when log format can be overridden
2 years ago
Jeff Lucovsky
3a37cf4507
log: Use SCCalloc instead of alloc/clear
2 years ago
Jeff Lucovsky
f8474344cd
log: Add module and subsystem identifiers to log
...
Issue: 2497
This changeset provides subsystem and module identifiers in the log when
the log format string contains "%S". By convention, the log format
surrounds "%S" with brackets.
The subsystem name is generally the same as the thread name. The module
name is derived from the source code module name and usually consists of
the first one or 2 segments of the name using the dash character as the
segment delimiter.
2 years ago
Victor Julien
197aa010d6
unix-socket: minor output improvements
2 years ago
Victor Julien
381e9f2bdf
mpm/ac: remove dead code
2 years ago
Victor Julien
f33784bed3
mpm/ac: use FatalError instead of Critical and exit
2 years ago
Victor Julien
dcf2f6b2be
detect: more compact message on error
2 years ago
Victor Julien
8b846bdcff
af-packet: output cleanups and unification
...
Make all messages use the same format:
<iface>: <message>
2 years ago
Victor Julien
806104c09a
output: issue warning if file can't be opened
2 years ago
Victor Julien
79c84211d5
output: remove all custom errors
2 years ago
Victor Julien
b31ffde6f4
output: remove error codes from output
2 years ago
Victor Julien
39f5c7f56a
error: use SC_EINVAL for invalid input
2 years ago
Victor Julien
e855fa0fe7
error: remove unused alloc error code
2 years ago
Victor Julien
e042cd785e
error: use SC_ENOMEM for alloc errors
2 years ago
Victor Julien
d2c98c3281
logopenfile: errno style error handling
2 years ago
Victor Julien
1e36db9d0e
hashlist: use errno style error handling
2 years ago
Victor Julien
0efdab1f5a
membuffer: errno style error reporting
2 years ago
Victor Julien
8ef95c10a8
pool: use errno style error reporting
2 years ago
Victor Julien
e621416d80
error: bootstrap errno like error code approach
2 years ago
Victor Julien
cdd52dc8cd
detect/mpm: output cleanups
2 years ago
Victor Julien
cdac0425a8
device: special case handling of dpdk devices
2 years ago
Victor Julien
d84bcdfd5c
device: output tweak
2 years ago
Victor Julien
c78ebd1352
dpdk: set RSS flags for igb driver
...
Tested on i340.
2 years ago
Victor Julien
b08e3e7460
dpdk: ips output cleanups
2 years ago
Victor Julien
62a451a9ab
eve/schema: bittorrent format fixup
2 years ago
Victor Julien
70b69a3171
output: minor code cleanups
2 years ago
Victor Julien
10c26bb628
unix-socket: don't print unix socket message twice
2 years ago
Jeff Lucovsky
82158f92c1
general: Correct typos
2 years ago
Victor Julien
be895d67b6
runmodes: minor output cleanup
2 years ago
Victor Julien
cef0a84bd2
detect: turn cleanup message into debug message
2 years ago
Victor Julien
b76f6dfa42
device/mtu: clean up mtu message
2 years ago
Victor Julien
7ccfa9b9a6
device: cleanup stats print
2 years ago
Victor Julien
fd4e522038
runmode: log test mode later
2 years ago
Victor Julien
181400bfdd
pcap-file: output cleanups
2 years ago
Victor Julien
ef881c942b
af-packet: output cleanups
2 years ago
Victor Julien
393546af07
mpm/hs: turn cleanup messages in to debug
2 years ago
Victor Julien
892b7021b2
stream: debug message cleanup
2 years ago
Victor Julien
d973e1021c
threading: memset cpu_set_t to address cppcheck warning
...
src/tm-threads.c:734:5: error: Uninitialized variable: cs [uninitvar]
CPU_ZERO(&cs);
2 years ago
Victor Julien
58c28d1778
dpdk: fix cppcheck warnings
...
src/runmode-dpdk.c:202:11: warning: Size of pointer 'argv' used instead of size of its data. This is likely to lead to a buffer overflow. You probably intend to write 'sizeof(*argv)'. [pointerSize]
args->argv = SCCalloc(capacity, sizeof(args->argv));
^
src/runmode-dpdk.c:777:23: error: Shifting 32-bit value by 63 bits is undefined behaviour [shiftTooManyBits]
if (bits & (1 << i))
^
src/runmode-dpdk.c:776:23: note: Assuming that condition 'i<64' is not redundant
for (int i = 0; i < 64; i++) {
^
src/runmode-dpdk.c:777:23: note: Shift
if (bits & (1 << i))
^
2 years ago
Victor Julien
17cd41c887
frames: suppress cppcheck warning
...
src/app-layer-frames.c:471:5: warning: Identical condition 'stream_slice->input==NULL', second condition is always false [identicalConditionAfterEarlyExit]
BUG_ON(stream_slice->input == NULL);
^
src/app-layer-frames.c:468:29: note: If condition 'stream_slice->input==NULL' is true, the function will return/exit
if (stream_slice->input == NULL)
^
src/app-layer-frames.c:471:5: note: Testing identical condition 'stream_slice->input==NULL'
BUG_ON(stream_slice->input == NULL);
^
src/app-layer-frames.c:548:5: warning: Identical condition 'stream_slice->input==NULL', second condition is always false [identicalConditionAfterEarlyExit]
BUG_ON(stream_slice->input == NULL);
^
src/app-layer-frames.c:545:29: note: If condition 'stream_slice->input==NULL' is true, the function will return/exit
if (stream_slice->input == NULL)
^
src/app-layer-frames.c:548:5: note: Testing identical condition 'stream_slice->input==NULL'
BUG_ON(stream_slice->input == NULL);
^
2 years ago
Victor Julien
16c19bd2f6
capture: remove unnecessary mtu check
2 years ago
Victor Julien
f45914cd99
classification: avoid duplicate errors
2 years ago
Victor Julien
7d46d4217f
unix-socket: avoid duplicate errors
2 years ago
Victor Julien
4dfb584164
dnp3: no error logging in packet path
2 years ago
dependabot[bot]
b4538134fa
github-actions: bump actions/checkout from 3.1.0 to 3.2.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.1.0...v3.2.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
Juliana Fajardini
8b56f688a1
github: update contrib guide link in PR template
...
Even though we have moved the contribution process guide to our read the
docs, the template was still pointing to our redmine link.
2 years ago
Haleema Khan
05e87bf32e
detect-detection: Convert unittests to new FAIL/PASS API
...
Ticket: #4019
2 years ago
Haleema Khan
6094aeee9e
detect-detection: Apply clang-format
2 years ago
Victor Julien
eb69902719
dpdk: NUMA output adjustments
...
Reduce verbosity of the NUMA logs; switch them to start with the
iface.
Don't print the cpu number.
2 years ago