Victor Julien
f6e37dcc90
Bug 1061: fix multiple vars per sig in ordering
...
In sigordering rules that had multiple vars doing the same operation,
like setting multiple flowbits, would not be considered correctly.
Bug 1061.
12 years ago
Ken Steele
85a51638c9
Improve Signature sorting speed
...
Changed the signature sorting code to use a a single merge sort instead
of the multiple pass sorting that was being used. This reduces startup
time on Tile by a factor of 3.
Also replace the user array of pointers to ints with a simpler array of
ints.
12 years ago
Anoop Saldanha
ab1f8afbc3
Removed Signature->order_id and replaced it with Signature->num.
12 years ago
Anoop Saldanha
43d1229dfa
1. Fix assignment of signums, which affected how we used read
...
sigs(priority wise) inside staging.
Previously we would assign signums before sig ordering, and hence the
order didn't actually reflect the order of the sig in the
sig_list(assuming sig reordering changed the sig_list). Staging would
use the old sig_nums to decide the priority of sigs.
2. Fix sig ordering for flowvar, flowbits, flowint, pktvar sigs. We have
introduced a new priority to treat sigs with set + read as lower
priority compared to set only sigs.
3. Previously we treated sigs with a "priority(keyword)" > another sig's
priority, as a sig with greater priority than the later. We have
reversed it. Now the sig priority ordering is 1,2,.etc. Updated
sigordering unittests to reflect the same.
12 years ago
Anoop Saldanha
71609229cc
sigorder cleaned up.
13 years ago
Anoop Saldanha
0c24a8a92f
fix(more like a feature update) for bug #708 .
...
Add support for flowint based sig ordering.
13 years ago
Last G
8ae11f73b2
Added parentheses to fix Eclipse static code analysis
...
Fixed bug in action priority (REJECT_DST had lowest prio)
13 years ago
Victor Julien
472e061c6d
build: more checking for includes
13 years ago
Anoop Saldanha
bff2866aed
more coverity fixes
13 years ago
Victor Julien
cdba2f50d1
Various fixes and improvements based on feedback by Coverity analyzer.
14 years ago
Victor Julien
e244934566
Disable unittest that fails without libnet support.
14 years ago
Victor Julien
791fc2f6ea
Adapt signature ordering to new flowbits post-match handling.
14 years ago
Victor Julien
aac2d91bcc
Set DROP flag for reject action so in addition to sending the rst, in IPS mode also drop the offending packet.
14 years ago
Anoop Saldanha
420befb180
Changed my email address to anoopsaldanha at gmail dot com from my current one
14 years ago
Victor Julien
8186565240
Fix a number of potential issues found by CLANG and cppcheck.
14 years ago
Victor Julien
e19f6ebaf4
Various fixes for issues reported by clang.
15 years ago
Anoop Saldanha
58c228a56b
fix sig ordering bugs. Flowvars and pktvars user type retrieval should be from pmatch list, as well as from match list. Also fix lousy unit tests
15 years ago
Anoop Saldanha
82fd581b64
replace all sm lists (match, pmatch, dmatch, umatch, amatch, tmatch) with an array Signature->sm_lists[]. Replace all Signature->match instances in the engine with Signature->sm_lists[DETECT_SM_LIST_MATCH]
15 years ago
Victor Julien
3062b19068
Clean up output of signature ordering module.
15 years ago
Pablo Rincon
0c3906a99b
Fix for bug 204 (signature ordering with flowbit priority)
15 years ago
Gurvinder Singh
cda664a8c4
memroy leaks fixes in detection module, app layer and counters
15 years ago
Gerardo Iglesias Galvan
9f4fae5b1a
Fix inconsistent use of dynamic memory allocation
15 years ago
Pablo Rincon
1238668961
Adding actions order and suport for rule action "pass"
15 years ago
William Metcalf
ce01927515
Import of GPLv2 Header 050410
15 years ago
Gurvinder Singh
69a4fee757
fixed the API and logic error reported by clang tool
15 years ago
Pablo Rincon
25a3a5c6d8
Adding mem wrapper to debug runtime alloc()/free() functions. Fixing some memory leaks.
16 years ago
Victor Julien
ecf86f9c23
Rename to Suricata.
16 years ago
Victor Julien
7a7bb7a390
Get rid of global mpm_ctx.
16 years ago
William Metcalf
24b27136cc
various unittest fixes for detect-engine-sigorder
16 years ago
Victor Julien
968d8df12b
More logging API usage. Changed logging macro's slightly so the vars inside them won't conflict with vars used by the calling function.
16 years ago
Anoop Saldanha
f658ffbc9c
Order the signatures based on certain rule parameters like actions, flowbits, flowvar, pktvar, priority etc
16 years ago