Victor Julien
e44b2effd0
util/var-name: switch to SCTime_t
2 years ago
Victor Julien
0e21c71490
threads: track wall clock time precisely
...
Issue warning if thread sleeps for a long time.
2 years ago
Victor Julien
5bb2132bb8
time: add SCTIME_CMP_EQ
2 years ago
Victor Julien
f0c4f9d64b
util/hash-string: fix compile warning
...
Clang 19:
util-hash-string.c:41:16: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
41 | int len1 = strlen((char *)data1);
| ~~~~ ^~~~~~~~~~~~~~~~~~~~~
util-hash-string.c:42:16: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
42 | int len2 = strlen((char *)data2);
| ~~~~ ^~~~~~~~~~~~~~~~~~~~~
2 errors generated.
2 years ago
Victor Julien
270e19191b
time: add gettimeofday wrapper for SCTime_t
2 years ago
Victor Julien
bdc0df8454
time: remove unused function
...
It tripped up cppcheck:
src/util-time.h:124:35: error: syntax error [syntaxError]
return !timercmp(first, second, >);
2 years ago
Victor Julien
3f85addaac
stream: track pcap log segments timestamp with SCTime_t
...
This is a more compact time format.
2 years ago
Jason Ish
a739d7623b
eve/tls: don't construct const from other const
...
Some compiler/platform combinations don't like creating one const from
another as it can't guarantee the other is defined, resulting in the
following compile error:
output-json-tls.c:102:5: error: initializer element is not constant
BASIC_FIELDS |
^~~~~~~~~~~~
Fixes commit 377989df6c
2 years ago
Adam Kiripolsky
175e690222
dpdk/hw_offload: add support for vlan stripping
...
Utilize DPDK API for hardware vlan stripping if supported by NIC.
Ticket: 7330
2 years ago
Nancy Enos
e22c2a2332
applayer/htp: convert to new FAIL/PASS API
...
Ticket: #6935
2 years ago
Jason Ish
d4a3ee163d
misc: remove unneeded headers
...
Remove unneeded headers from worked on in previous commits, just
simple ones flagged by clangd.
2 years ago
Jason Ish
ab6dcb3fc1
app-layer: use uint8_t consistent for event IDs
...
Introduce a common function for mapping names to IDs that performs
bounds checking.
Note: For event IDs in the enum that are larger than a uint8_t, -1
will be returned instead of -4. -4 has special meaning during
signature parsin that means requirements were not met. -4 has no
special handling prior to requirements, or the meaning has been lost.
2 years ago
Alice Akaki
5e563b0c8b
detect/analyzer: add more details for flow_age
...
Ticket: #6312
2 years ago
Sascha Steinbiss
285cc29ec0
redis: add automatic trimming support for streams
2 years ago
Sascha Steinbiss
d3d9f1c395
redis: implement XADD stream support
...
Ticket: #7082
2 years ago
Juliana Fajardini
1860aa81e6
userguide: fix integer keyword matches list format
...
List wasn't being properly rendered.
2 years ago
Jason Ish
45384ef969
rust/applayer: use c_int as return type for get_info_by_id
...
Rust was using i8 as the return type, while C uses int. As of Rust
1.82, the return value is turned to garbage over the FFI boundary.
Ticket: #7338
2 years ago
Jason Ish
b44fc62e60
eve/schema: add missing field "code" anomaly events
2 years ago
Jason Ish
30806ce2b7
eve/tls: use BIT_U64 for flags
...
Minor cleanup.
2 years ago
Jason Ish
2462d9d4cf
eve/tls: remove unused SC_ATOMIC_EXTERN
2 years ago
Jason Ish
cc519beb91
suricata.yaml: add missing custom tls fields
...
Also update the suricata.yaml in the userguide.
2 years ago
Jason Ish
714ada136c
eve/tls: cleanup headers; update copyright year
2 years ago
Jason Ish
377989df6c
eve/tls: reimplement basic and extended logging in terms of custom
...
Will prevent custom logging options getting out of sync with whats
available in extended.
Ticket: #7333
2 years ago
Jason Ish
2e788408c0
eve/tls: remove broken check for ja3 being enabled
...
During EVE TLS setup, a broken check for Ja3 being enabled led to Ja3
being disabled, but only in custom mode. This check is not needed, if
Ja3 is disabled, it won't be available, and won't be logged.
This is required to implement "extended" in terms of "custom" fields.
2 years ago
Jason Ish
6a185a8f96
eve/tls: add alpn logging to custom output
...
Adds custom fields "client_alpns" and "server_alpns".
Ticket: #7333
2 years ago
Jason Ish
3ddd9e2512
eve/tls: disable clang formatting around tls_fields array
2 years ago
Jeff Lucovsky
799822c3db
profiling: Correct profiling data array size
...
The profiling arrays are incorrectly sized by the number of thread
modules. Since they contain app-layer protocol data, they should be
sized by ALPROTO_MAX.
2 years ago
Philippe Antoine
b5fcf16d97
enip/detect: remove double registration of enip_command keyword
...
As found with
./src/suricata --list-keywords | sort | uniq -c | awk '$1 > 1'
2 years ago
Juliana Fajardini
55b922ceed
tls/conf: clarify usage of custom vs extended logs
...
Since enabling custom logging will replace the extended logging, thus
possibly leading to certain fields disappearing from the logs, mention
this aspect.
Related to
Bug #7333
2 years ago
Juliana Fajardini
69fe5121a1
tls: fix duplicate EVE field (issuerdn)
...
Wrong function call caused `issuerdn` to be logged when
`subjectaltname` was enabled, for custom logging, only.
Bug #7332
2 years ago
Juliana Fajardini
2eefc4dac8
schema/tls: add missing custom fields chain/cert
...
Task #7287
2 years ago
dependabot[bot]
7ae522f16a
github-actions: bump github/codeql-action from 3.26.12 to 3.26.13
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.12 to 3.26.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Commits](https://github.com/github/codeql-action/compare/v3.26.12...v3.26.13 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
Shivani Bhardwaj
37fa2a6775
detect: rename port whitelisting to priority
...
This was done following the fact that this setting was historically
named incorrectly. The purpose of the setting was always to define the
ports that will be prioritized and have rule groups associated w them on
priority. Rename all occurences of this to correctly reflect the purpose
of the setting.
2 years ago
Shivani Bhardwaj
abbdeed931
detect/engine: rename fn, add comments
2 years ago
Shivani Bhardwaj
f8a5c91448
detect/proto: use BIT macros instead of expr
2 years ago
Shivani Bhardwaj
86c1e458f9
detect/engine: use combined flags for TCP
2 years ago
dependabot[bot]
285113a1e5
github-actions: bump actions/checkout from 4.2.0 to 4.2.1
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](d632683dd7...eef61447b9 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
dependabot[bot]
9e0151cce5
github-actions: bump github/codeql-action from 3.26.10 to 3.26.12
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.10 to 3.26.12.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Commits](https://github.com/github/codeql-action/compare/v3.26.10...v3.26.12 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
dependabot[bot]
4ad45fc8d0
github-actions: bump actions/upload-artifact from 4.4.0 to 4.4.3
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.0 to 4.4.3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](50769540e7...b4b15b8c7c )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
Alice Akaki
fa1addae64
detect/analyzer: add more details for icmp_id
...
Ticket: #6360
2 years ago
Philippe Antoine
378f678d95
fuzz/detect: forbid rule with pcre only on stream
...
to avoid fuzzing blocks on timeouts with known bad rules
Ticket: 4858
2 years ago
Philippe Antoine
81f7ef89c4
stream: fix -Wshorten-64-to-32 warnings
...
Ticket: #6186
2 years ago
Philippe Antoine
58f7af8a31
output: fix -Wshorten-64-to-32 warnings
...
Ticket: #6186
2 years ago
Philippe Antoine
2fb89f1b79
ldap: improve some rust style
2 years ago
Victor Julien
97d525d18d
github-action: share cargo registry cache
2 years ago
Victor Julien
d574d88bca
github-action: share cargo cache for windows jobs
2 years ago
Victor Julien
f334532063
rust: update dependencies
2 years ago
Victor Julien
9b6a1355ac
github-actions: cache netmap checkout
...
To avoid build failures due to rate limiting, cache the netmap checkout.
Explicitly restore and save to avoid the checkout action cleaning the
checkout up before it can be stored in the cache.
2 years ago
Jason Ish
15c4eb3d16
threads: move wait for unpause outside of loop
...
Threads are only set to paused upon initialization and never again, we
should only have to wait once, so move the wait before any loop that
was waiting before.
Additionally, if the thread was killed while waiting to be unpaused,
don't enter the loop.
2 years ago
Jason Ish
7492fb6a91
threads: merge unpause test into wait for pause function
...
TmThreadTestThreadUnPaused was only being used by
TmThreadsWaitForUnpause and is still enough to just become one
function.
2 years ago