76 Commits (001e87310d8e2b366934abc7d57b8248f323f2cc)

Author	SHA1	Message	Date
Jason Ish	796dd5223b	tests: no longer necessary to provide successful return code ... 1 pass, 0 is fail.	10 years ago
Victor Julien	d5c6d08bc8	detect-port: remove debug mem counters	10 years ago
Victor Julien	0311f01b97	rule grouping: speed up port based grouping ... Create a hash table of unique DetectPort objects before trying to create a unique list of these objects. This safes a lot of cycles in the creation of the list.	10 years ago
Victor Julien	cbf80de6fe	detect-port: cleanup	10 years ago
Victor Julien	f0ba00e51d	detect: remove old unused code	10 years ago
Alexander Gozman	69785f186c	BUG #1689: fix stack overflow when parsing variables ... Suricata crashed when variable (either address or port) referred to itself or if one created a looped chain of variables. For instance: HOME_NET: "!$EXTERNAL_NET" EXTERNAL_NET: "!$HOME_NET" Or: Var1: "$Var2" Var2: "$Var3" Var3: "$Var1"	10 years ago
Victor Julien	066c4b0b24	detect ports: fix memory leak ... Fix mem leak on rules that contained ports like "![21,25,119]".	10 years ago
Victor Julien	0bc27c7dc7	rule-vars: take detect engine as arg	11 years ago
Victor Julien	3083f51cc6	detect:pass DetectEngineCtx to port parsing ... Preparation for prefix handling in port parsing.	11 years ago
Ken Steele	8f1d75039a	Enforce function coding standard ... Functions should be defined as: int foo(void) { } Rather than: int food(void) { } All functions where changed by a script to match this standard.	11 years ago
Victor Julien	90cf8d4c6e	port parsing: improve memory handling	12 years ago
Victor Julien	d5db0cc033	port: don't lead memory on port parsing failure ... [src/detect-engine-port.c:1354]: (error) Memory leak: gh	12 years ago
Victor Julien	2ce8895f0a	address and port: reduce memory allocs	12 years ago
Victor Julien	3f8b9dde04	Dead code removal	12 years ago
Victor Julien	1be6a8a48b	Fix small leak in ports validation at startup	12 years ago
Eric Leblond	c5bd04f102	unittest: recycle packet before exit ... To avoid an issue with flow validation, we need to recycle the packet before cleaning the flow.	12 years ago
Victor Julien	d0c1410cf5	Fix sig grouping bug when certain sigs are mixed. Add tests.	13 years ago
Anoop Saldanha	f59ce70c17	fix for #694. ... Invalidate any address/port vars in the conf that uses a sequence without quotes.	13 years ago
Last G	8ae11f73b2	Added parentheses to fix Eclipse static code analysis ... Fixed bug in action priority (REJECT_DST had lowest prio)	13 years ago
Victor Julien	c3f4f8d46a	Dead code cleanup. Coverity 728047, 728048, 728049.	13 years ago
Eric Leblond	e176be6fcc	Use unlikely for error treatment. ... When handling error case on SCMallog, SCCalloc or SCStrdup we are in an unlikely case. This patch adds the unlikely() expression to indicate this to gcc. This patch has been obtained via coccinelle. The transformation is the following: @istested@ identifier x; statement S1; identifier func =~ "(SCMalloc|SCStrdup|SCCalloc)"; @@ x = func(...) ... when != x - if (x == NULL) S1 + if (unlikely(x == NULL)) S1	13 years ago
Eric Leblond	d292004880	Add some missing checks of SCStrdup return.	13 years ago
Anoop Saldanha	970fdee204	detection engine port api unittests cleanup	13 years ago
Victor Julien	5e95524122	Improve error reporting in case of syntax errors in the address and port vars.	13 years ago
Anoop Saldanha	4689783342	bug #454 - rebase fix. Also use better error code to indicate invalid address var yaml entry	13 years ago
Anoop Saldanha	678763c3f4	bug #454 - global check to see if address and port vars are properly configured	13 years ago
Anoop Saldanha	e682796d03	feature #414 - support listing supported keywords. Remove support for dummy keywords __address__, __proto__, __port__. Remove support for recursive keyword and all references to it	14 years ago
Victor Julien	c4b34e6ef7	Fix various minor clang/scan-build warnings.	14 years ago
Anoop Saldanha	7433d92dd2	undo this commit - ... commit eff08f93d8 Author: Anoop Saldanha <poonaatsoc@gmail.com> Date: Thu Nov 3 14:31:24 2011 +0530 update failing unittest to reflect the mpm design update Fixed a bug in the mpm code that would make all the changes in the commit just undone wrong.	14 years ago
Anoop Saldanha	eff08f93d8	update failing unittest to reflect the mpm design update	14 years ago
Victor Julien	bfff14aa78	Improve error detection in the port and address parsing in signatures. Bug #295.	14 years ago
Gurvinder Singh	cda664a8c4	memroy leaks fixes in detection module, app layer and counters	15 years ago
William Metcalf	73d2349149	Null deref fix for detect-engine-port.c	15 years ago
Gerardo Iglesias Galvan	9f4fae5b1a	Fix inconsistent use of dynamic memory allocation	16 years ago
Victor Julien	46831e0f8f	Fix signature grouping bug for protocols without ports. Add debugging code.	16 years ago
Victor Julien	a372c1d14e	Fix/workaround a strange detection issue.	16 years ago
William Metcalf	ce01927515	Import of GPLv2 Header 050410	16 years ago
Gurvinder Singh	cf2d254cc6	fixed the memory leaks and buffer overflows reported by parfait	16 years ago
Pablo Rincon	25a3a5c6d8	Adding mem wrapper to debug runtime alloc()/free() functions. Fixing some memory leaks.	16 years ago
Pablo Rincon	d0404d8447	Renaming errors with naming conventions	16 years ago
Pablo Rincon	ad2c136e8f	Renaming errors (naming conventions)	16 years ago
Victor Julien	2481f2102b	Add missing return value evaluation in port parsing and fix broken unittest.	16 years ago
Steve Grubb	60ad9d29c5	Memory leak cleanup in detectors ... Hello, I ran the code through an analysis program and found several leaks that should be cleaned up. *In src/detect-engine-address-ipv4.c at line 472, the test for ag == NULL will never be true since that is the loop entry test. *In src/detect-engine-port.c at line 1133, the test for p == NULL will never be true since that is the loop entry test. *In src/detect-engine-mpm.c at line 263 is a return without freeing fast_pattern *In src/detect-ack.c at line 80 and 85, data catches the return from malloc. One of them should be deleted. *In src/detect-seq.c at line 81 and 86, data catches the return from malloc. One of them should be deleted. *In src/detect-content.c at line 749, many of the paths that lead to the error exit still has temp pointing to allocated memory. To clean this up, temp should be set to NULL if not immediately assigning and new value. *In src/detect-uricontent.c at line 319, both cd and str needto be freed. At lines 344, str needs to be freed. And at line 347 str and temp need to be freed. *In src/detect-flowbits.c at line 231 and 235, str was not being freed. cd was not being freed at line 235. *In src/detect-flowvar.c at line 127, str was not being freed. At line 194, cd and str were not being freed. *In src/detect-flowint.c at line 277, sfd was not being freed. At line 315, str was not being freed. *In src/detect-pktvar.c at line 121, str was not being freed. At line 188, str and cd was not being freed. *In src/detect-pcre.c at line 389, there is an extra free of "re" that should be deleted. *In src/detect-depth.c at line 42 & 48, str has not been freed. *In src/detect-distance.c at line 49 and 55, str has not been freed *In src/detect-offset.c at line 45, str has not been freed. The patch below fixes these issues. -Steve	16 years ago
Victor Julien	b7bac14040	Fixup code to compile with -Wall -Werror -Wextra -Wno-unused-parameter compiler options.	16 years ago
Victor Julien	0ab9adabd4	Test PortTestMatchDoubleNegation is no longer expected to fail.	16 years ago
Victor Julien	50c07f9901	Fix wrong negation of ports.	16 years ago
Victor Julien	53041eeb67	Small cleanups.	16 years ago
Anoop Saldanha	f8edb74439	double port/address negation is parsed incorrectly	16 years ago
Victor Julien	ecf86f9c23	Rename to Suricata.	16 years ago
Victor Julien	2cfa284999	Fix app layer detect to actually work.	16 years ago