fix lock issue with mpms inspecting http state for body, header

15 years ago · ea3fd38291
parent b140ed1c9c
commit ea3fd38291
2 changed files with 1 additions and 8 deletions
--- a/src/detect-engine-hcbd.c
+++ b/src/detect-engine-hcbd.c
@ -417,9 +417,6 @@ int DetectEngineInspectHttpClientBody(DetectEngineCtx *de_ctx,
        SCReturnInt(0);
    }

-    /* locking the flow, we will inspect the htp state */
-    SCMutexLock(&f->m);
-
    if (htp_state->connp == NULL || htp_state->connp->conn == NULL) {
        SCLogDebug("HTP state has no conn(p)");
        goto end;
@ -472,7 +469,6 @@ int DetectEngineInspectHttpClientBody(DetectEngineCtx *de_ctx,
    }

 end:
-    SCMutexUnlock(&f->m);
    SCReturnInt(r);
 }

--- a/src/detect-engine-hhd.c
+++ b/src/detect-engine-hhd.c
@ -398,9 +398,6 @@ int DetectEngineInspectHttpHeader(DetectEngineCtx *de_ctx,
        SCReturnInt(0);
    }

-    /* locking the flow, we will inspect the htp state */
-    SCMutexLock(&f->m);
-
    if (htp_state->connp == NULL || htp_state->connp->conn == NULL) {
        SCLogDebug("HTP state has no conn(p)");
        goto end;
@ -436,6 +433,7 @@ int DetectEngineInspectHttpHeader(DetectEngineCtx *de_ctx,
    //    }
    //}

+
    for (i = 0; i < det_ctx->hhd_buffers_list_len; i++) {
        uint8_t *hhd_buffer = det_ctx->hhd_buffers[i];
        uint32_t hhd_buffer_len = det_ctx->hhd_buffers_len[i];
@ -451,7 +449,6 @@ int DetectEngineInspectHttpHeader(DetectEngineCtx *de_ctx,
    }

 end:
-    SCMutexUnlock(&f->m);
    SCReturnInt(r);
 }