From e2444f0ed5ebfcac8a721c961423890b4f807213 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Tue, 25 Jun 2013 17:14:02 +0200 Subject: [PATCH] Coverity 1038092 & 1038093: remove dead code --- src/app-layer-ssh.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/src/app-layer-ssh.c b/src/app-layer-ssh.c index b2c6489278..2fd7db4884 100644 --- a/src/app-layer-ssh.c +++ b/src/app-layer-ssh.c @@ -229,13 +229,8 @@ static int SSHParseServerRecord(Flow *f, void *ssh_state, AppLayerParserState *p if ( !(state->flags & SSH_FLAG_SERVER_VERSION_PARSED)) { ret = SSHParseServerVersion(f, ssh_state, pstate, input, input_len, output); if (ret < 0) { - if (ret <= -1) { - SCLogDebug("Invalid version string"); - SCReturnInt(-1); - } - SCLogDebug("Version string not parsed yet"); - pstate->parse_field = 0; - SCReturnInt(ret); + SCLogDebug("Invalid version string"); + SCReturnInt(-1); } else if (state->flags & SSH_FLAG_SERVER_VERSION_PARSED) { SCLogDebug("Version string parsed"); input += input_len - ret; @@ -560,13 +555,8 @@ static int SSHParseClientRecord(Flow *f, void *ssh_state, AppLayerParserState *p if ( !(state->flags & SSH_FLAG_CLIENT_VERSION_PARSED)) { ret = SSHParseClientVersion(f, ssh_state, pstate, input, input_len, output); if (ret < 0) { - if (ret <= -1) { - SCLogDebug("Invalid version string"); - SCReturnInt(-1); - } - SCLogDebug("Version string not parsed yet"); - pstate->parse_field = 0; - SCReturnInt(0); + SCLogDebug("Invalid version string"); + SCReturnInt(-1); } else if (state->flags & SSH_FLAG_CLIENT_VERSION_PARSED) { SCLogDebug("Version string parsed"); input += input_len - ret;