From dc80d520affa690c0f7141fb55aaec47fbf2ade4 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Tue, 11 Jun 2019 12:09:38 +0200 Subject: [PATCH] ftp: implement progress tracking Make sure FTP_STATE_FINISHED is returned for transactions that are marked 'done'. This is necessary for timely logging and inspection. --- src/app-layer-ftp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/app-layer-ftp.c b/src/app-layer-ftp.c index 0916b2ac75..26c0f99300 100644 --- a/src/app-layer-ftp.c +++ b/src/app-layer-ftp.c @@ -1014,9 +1014,10 @@ static int FTPGetAlstateProgress(void *vtx, uint8_t direction) return FTP_STATE_PORT_DONE; } - /* TODO: figure out further progress handling */ + if (!tx->done) + return FTP_STATE_IN_PROGRESS; - return FTP_STATE_IN_PROGRESS; + return FTP_STATE_FINISHED; }