detect/doc: remove unexisting links

Ticket: 8257

And add TODO comments if rules doc should be written

rust/ffi/src/detect.rs

@@ -43,7 +43,11 @@ pub struct SigTableElmtStickyBuffer {
 fn helper_keyword_register_buffer_flags(kw: &SigTableElmtStickyBuffer, flags: u32) -> u16 {
     let name = CString::new(kw.name.as_bytes()).unwrap().into_raw();
     let desc = CString::new(kw.desc.as_bytes()).unwrap().into_raw();
-    let url = CString::new(kw.url.as_bytes()).unwrap().into_raw();
+    let url = if kw.url.is_empty() {
+        std::ptr::null_mut()
+    } else {
+        CString::new(kw.url.as_bytes()).unwrap().into_raw()
+    };
     let st = SCSigTableAppLiteElmt {
         name,
         desc,

rust/src/detect/mod.rs

@@ -79,7 +79,9 @@ pub struct SCSigTableNamesElmt {
 pub unsafe extern "C" fn SCDetectSigMatchNamesFree(kw: &mut SCSigTableNamesElmt) {
     let _ = CString::from_raw(kw.name);
     let _ = CString::from_raw(kw.desc);
+    if !kw.url.is_null() {
         let _ = CString::from_raw(kw.url);
+    }
 }
 
 pub use suricata_sys::sys::{

rust/src/quic/detect.rs

@@ -239,7 +239,8 @@ pub unsafe extern "C" fn SCDetectQuicRegister() {
     let kw = SigTableElmtStickyBuffer {
         name: String::from("quic.sni"),
         desc: String::from("match Quic sni"),
-        url: String::from("/rules/quic-keywords.html#quic-sni"),
+        // TODO write doc or deprecate keyword
+        url: String::from(""),
         setup: quic_sni_setup,
     };
     helper_keyword_register_sticky_buffer(&kw);
@@ -254,7 +255,8 @@ pub unsafe extern "C" fn SCDetectQuicRegister() {
     let kw = SigTableElmtStickyBuffer {
         name: String::from("quic.ua"),
         desc: String::from("match Quic ua"),
-        url: String::from("/rules/quic-keywords.html#quic-ua"),
+        // TODO write doc or deprecate keyword
+        url: String::from(""),
         setup: quic_ua_setup,
     };
     helper_keyword_register_sticky_buffer(&kw);

src/detect-http-header.c

@@ -369,8 +369,7 @@ void DetectHttpHeaderRegister(void)
     sigmatch_table[DETECT_HTTP_HEADER_CM].name = "http_header";
     sigmatch_table[DETECT_HTTP_HEADER_CM].desc =
             "content modifier to match only on the HTTP header-buffer";
-    sigmatch_table[DETECT_HTTP_HEADER_CM].url =
-            "/rules/http-keywords.html#http-header-and-http-raw-header";
+    // no doc url for this obsolete keyword, see http.header
     sigmatch_table[DETECT_HTTP_HEADER_CM].Setup = DetectHttpHeaderSetup;
 #ifdef UNITTESTS
     sigmatch_table[DETECT_HTTP_HEADER_CM].RegisterTests = DetectHttpHeaderRegisterTests;

src/detect-http-host.c

@@ -94,8 +94,7 @@ void DetectHttpHHRegister(void)
     /* http_host content modifier */
     sigmatch_table[DETECT_HTTP_HOST_CM].name = "http_host";
     sigmatch_table[DETECT_HTTP_HOST_CM].desc = "content modifier to match on the HTTP hostname";
-    sigmatch_table[DETECT_HTTP_HOST_CM].url =
-            "/rules/http-keywords.html#http-host-and-http-raw-host";
+    // no doc url for this obsolete keyword, see http.host
     sigmatch_table[DETECT_HTTP_HOST_CM].Setup = DetectHttpHHSetup;
 #ifdef UNITTESTS
     sigmatch_table[DETECT_HTTP_HOST_CM].RegisterTests = DetectHttpHHRegisterTests;
@@ -137,8 +136,7 @@ void DetectHttpHHRegister(void)
     sigmatch_table[DETECT_HTTP_RAW_HOST].name = "http_raw_host";
     sigmatch_table[DETECT_HTTP_RAW_HOST].desc = "content modifier to match on the HTTP host header "
                                                 "or the raw hostname from the HTTP uri";
-    sigmatch_table[DETECT_HTTP_RAW_HOST].url =
-            "/rules/http-keywords.html#http-host-and-http-raw-host";
+    // no doc url for this obsolete keyword, see http.host.raw
     sigmatch_table[DETECT_HTTP_RAW_HOST].Setup = DetectHttpHRHSetup;
     sigmatch_table[DETECT_HTTP_RAW_HOST].flags |= SIGMATCH_NOOPT | SIGMATCH_INFO_CONTENT_MODIFIER;
     sigmatch_table[DETECT_HTTP_RAW_HOST].alternative = DETECT_HTTP_HOST_RAW;

src/detect-http-raw-header.c

@@ -85,8 +85,7 @@ void DetectHttpRawHeaderRegister(void)
     sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].name = "http_raw_header";
     sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].desc =
             "content modifier to match the raw HTTP header buffer";
-    sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].url =
-            "/rules/http-keywords.html#http-header-and-http-raw-header";
+    // no doc url for this obsolete keyword, see http.header.raw
     sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].Setup = DetectHttpRawHeaderSetup;
 #ifdef UNITTESTS
     sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].RegisterTests = DetectHttpRawHeaderRegisterTests;

src/detect-http-uri.c

@@ -91,7 +91,7 @@ void DetectHttpUriRegister (void)
     sigmatch_table[DETECT_HTTP_URI_CM].name = "http_uri";
     sigmatch_table[DETECT_HTTP_URI_CM].desc =
             "content modifier to match specifically and only on the HTTP uri-buffer";
-    sigmatch_table[DETECT_HTTP_URI_CM].url = "/rules/http-keywords.html#http-uri-and-http-uri-raw";
+    // no doc url for this obsolete keyword, see http.uri
     sigmatch_table[DETECT_HTTP_URI_CM].Setup = DetectHttpUriSetup;
 #ifdef UNITTESTS
     sigmatch_table[DETECT_HTTP_URI_CM].RegisterTests = DetectHttpUriRegisterTests;
@@ -132,7 +132,7 @@ void DetectHttpUriRegister (void)
     /* http_raw_uri content modifier */
     sigmatch_table[DETECT_HTTP_RAW_URI].name = "http_raw_uri";
     sigmatch_table[DETECT_HTTP_RAW_URI].desc = "content modifier to match on the raw HTTP uri";
-    sigmatch_table[DETECT_HTTP_RAW_URI].url = "/rules/http-keywords.html#http_uri-and-http_raw-uri";
+    // no doc url for this obsolete keyword, see http.uri.raw
     sigmatch_table[DETECT_HTTP_RAW_URI].Setup = DetectHttpRawUriSetup;
     sigmatch_table[DETECT_HTTP_RAW_URI].flags |= SIGMATCH_NOOPT | SIGMATCH_INFO_CONTENT_MODIFIER;
     sigmatch_table[DETECT_HTTP_RAW_URI].alternative = DETECT_HTTP_URI_RAW;

src/detect-nfs-version.c

@@ -64,7 +64,8 @@ void DetectNfsVersionRegister (void)
     sigmatch_table[DETECT_NFS_VERSION].name = "nfs.version";
     sigmatch_table[DETECT_NFS_VERSION].alias = "nfs_version";
     sigmatch_table[DETECT_NFS_VERSION].desc = "match NFS version";
-    sigmatch_table[DETECT_NFS_VERSION].url = "/rules/nfs-keywords.html#version";
+    // TODO write doc sigmatch_table[DETECT_NFS_VERSION].url =
+    // "/rules/nfs-keywords.html#nfs-version";
     sigmatch_table[DETECT_NFS_VERSION].AppLayerTxMatch = DetectNfsVersionMatch;
     sigmatch_table[DETECT_NFS_VERSION].Setup = DetectNfsVersionSetup;
     sigmatch_table[DETECT_NFS_VERSION].Free = DetectNfsVersionFree;

src/detect-uricontent.c

@@ -68,7 +68,7 @@ void DetectUricontentRegister (void)
 {
     sigmatch_table[DETECT_URICONTENT].name = "uricontent";
     sigmatch_table[DETECT_URICONTENT].desc = "legacy keyword to match on the request URI buffer";
-    sigmatch_table[DETECT_URICONTENT].url = "/rules/http-keywords.html#uricontent";
+    // No url doc for this obsolete keyword
     sigmatch_table[DETECT_URICONTENT].Match = NULL;
     sigmatch_table[DETECT_URICONTENT].Setup = DetectUricontentSetup;
     sigmatch_table[DETECT_URICONTENT].Free = DetectUricontentFree;