From d34fbfa234fa02a86e820153e445b8094060aefd Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Sat, 2 May 2026 12:21:13 +0200 Subject: [PATCH] ftp: fix compile warnings app-layer-ftp.c:278:14: error: initializing 'uint8_t *' (aka 'unsigned char *') with an expression of type 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] 278 | uint8_t *lf_idx = memchr(input->buf + input->consumed, 0x0a, input->len); | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ app-layer-ftp.c:1392:11: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] 1392 | char *c = strchr(buffer, '\n'); | ^ ~~~~~~~~~~~~~~~~~~~~ 2 errors generated. (cherry picked from commit c21275cab3c96f99d1a15bf38d9e0bb37d3f50f3) --- src/app-layer-ftp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app-layer-ftp.c b/src/app-layer-ftp.c index a2afd91ed1..ed412e27c5 100644 --- a/src/app-layer-ftp.c +++ b/src/app-layer-ftp.c @@ -357,7 +357,7 @@ static AppLayerResult FTPGetLineForDirection( if (input->len <= 0) return APP_LAYER_ERROR; - uint8_t *lf_idx = memchr(input->buf + input->consumed, 0x0a, input->len); + const uint8_t *lf_idx = memchr(input->buf + input->consumed, 0x0a, input->len); if (lf_idx == NULL) { if (!(*current_line_truncated) && (uint32_t)input->len >= ftp_max_line_len) { @@ -1415,7 +1415,7 @@ uint16_t JsonGetNextLineFromBuffer(const char *buffer, const uint16_t len) return UINT16_MAX; } - char *c = strchr(buffer, '\n'); + const char *c = strchr(buffer, '\n'); return c == NULL ? len : (uint16_t)(c - buffer + 1); }