From d1009e295c76e1eda1bdb07a1ccaaddf9a6d1349 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Thu, 13 Oct 2022 19:04:46 +0200 Subject: [PATCH] packetpool: remove debug validation check Current packet might be the root or a child. Root would have set drop action set, but Packet::pkt_src might be set in either. --- src/tmqh-packetpool.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/tmqh-packetpool.c b/src/tmqh-packetpool.c index 5c78968e61..f715c393f8 100644 --- a/src/tmqh-packetpool.c +++ b/src/tmqh-packetpool.c @@ -363,14 +363,6 @@ void TmqhOutputPacketpool(ThreadVars *t, Packet *p) SCEnter(); SCLogDebug("Packet %p, p->root %p, alloced %s", p, p->root, p->flags & PKT_ALLOC ? "true" : "false"); -#ifdef DEBUG_VALIDATION - /* Check that the drop reason has been set, if we have a drop. - * Use macro to avoid testing Packet::root. */ - if (PACKET_TEST_ACTION(p, ACTION_DROP)) { - DEBUG_VALIDATE_BUG_ON((p)->drop_reason == PKT_DROP_REASON_NOT_SET); - } -#endif - if (IS_TUNNEL_PKT(p)) { SCLogDebug("Packet %p is a tunnel packet: %s", p,p->root ? "upper layer" : "tunnel root");