aiden
/
suricata
mirror of https://github.com/OISF/suricata
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dns: turn debug BUG_ON's into events

Browse Source
pull/1915/head
Victor Julien 10 years ago
parent c0b16fa2bb
commit bda9869af7
1 changed files with 7 additions and 21 deletions
Show Stats Download Patch File Download Diff File

28
src/app-layer-dns-common.c
Unescape Escape View File

@ -788,10 +788,7 @@ const uint8_t *DNSReponseParse(DNSState *dns_state, const DNSHeader * const dns_
if ((fqdn_len = DNSResponseGetNameByOffset(input, input_len, if ((fqdn_len = DNSResponseGetNameByOffset(input, input_len,
data - input, fqdn, sizeof(fqdn))) == 0) data - input, fqdn, sizeof(fqdn))) == 0)
{ {
#if DEBUG DNSSetEvent(dns_state, DNS_DECODER_EVENT_MALFORMED_DATA);
PrintRawDataFp(stdout, (uint8_t *)input, input_len);
BUG_ON(1);
#endif
goto insufficient_data; goto insufficient_data;
} }
//PrintRawDataFp(stdout, fqdn, fqdn_len); //PrintRawDataFp(stdout, fqdn, fqdn_len);
@ -806,10 +803,7 @@ const uint8_t *DNSReponseParse(DNSState *dns_state, const DNSHeader * const dns_
if ((fqdn_len = DNSResponseGetNameByOffset(input, input_len, if ((fqdn_len = DNSResponseGetNameByOffset(input, input_len,
offset, fqdn, sizeof(fqdn))) == 0) offset, fqdn, sizeof(fqdn))) == 0)
{ {
#if DEBUG DNSSetEvent(dns_state, DNS_DECODER_EVENT_MALFORMED_DATA);
PrintRawDataFp(stdout, (uint8_t *)input, input_len);
BUG_ON(1);
#endif
goto insufficient_data; goto insufficient_data;
} }
//PrintRawDataFp(stdout, fqdn, fqdn_len); //PrintRawDataFp(stdout, fqdn, fqdn_len);
@ -886,11 +880,9 @@ const uint8_t *DNSReponseParse(DNSState *dns_state, const DNSHeader * const dns_
} }
if ((name_len = DNSResponseGetNameByOffset(input, input_len, if ((name_len = DNSResponseGetNameByOffset(input, input_len,
data - input + skip, name, sizeof(name))) == 0) { data - input + skip, name, sizeof(name))) == 0)
#if DEBUG {
PrintRawDataFp(stdout, (uint8_t *)input, input_len); DNSSetEvent(dns_state, DNS_DECODER_EVENT_MALFORMED_DATA);
BUG_ON(1);
#endif
goto insufficient_data; goto insufficient_data;
} }
@ -910,10 +902,7 @@ const uint8_t *DNSReponseParse(DNSState *dns_state, const DNSHeader * const dns_
if ((pname_len = DNSResponseGetNameByOffset(input, input_len, if ((pname_len = DNSResponseGetNameByOffset(input, input_len,
data - input, pname, sizeof(pname))) == 0) data - input, pname, sizeof(pname))) == 0)
{ {
#if DEBUG DNSSetEvent(dns_state, DNS_DECODER_EVENT_MALFORMED_DATA);
PrintRawDataFp(stdout, (uint8_t *)input, input_len);
BUG_ON(1);
#endif
goto insufficient_data; goto insufficient_data;
} }
@ -929,10 +918,7 @@ const uint8_t *DNSReponseParse(DNSState *dns_state, const DNSHeader * const dns_
if ((pmail_len = DNSResponseGetNameByOffset(input, input_len, if ((pmail_len = DNSResponseGetNameByOffset(input, input_len,
sdata - input, pmail, sizeof(pmail))) == 0) sdata - input, pmail, sizeof(pmail))) == 0)
{ {
#if DEBUG DNSSetEvent(dns_state, DNS_DECODER_EVENT_MALFORMED_DATA);
PrintRawDataFp(stdout, (uint8_t *)input, input_len);
BUG_ON(1);
#endif
goto insufficient_data; goto insufficient_data;
} }
SCLogDebug("pmail_len %u", pmail_len); SCLogDebug("pmail_len %u", pmail_len);

Write Preview
Loading…
Cancel
Save