detect/threshold: fix unittests for storage based cache

(cherry picked from commit f67dadc3d8)

src/detect-engine-threshold.c

@@ -485,16 +485,26 @@ static void ThresholdCacheThreadFree(void *ptr)
 
 static void ThresholdCacheInit(void)
 {
-    /* Register thread storage. */
+#ifdef UNITTESTS
-    thread_storage_id = ThreadStorageRegister(
+    /* many tests don't manage the thread storage correctly, so skip the cache in unittests */
-            "threshold_cache", sizeof(void *), NULL, ThresholdCacheThreadFree);
+    if (!(RunmodeIsUnittests())) {
-    if (thread_storage_id.id < 0) {
+#endif
-        FatalError("Failed to register threshold_cache thread storage");
+        /* Register thread storage. */
+        thread_storage_id = ThreadStorageRegister(
+                "threshold_cache", sizeof(void *), NULL, ThresholdCacheThreadFree);
+        if (thread_storage_id.id < 0) {
+            FatalError("Failed to register threshold_cache thread storage");
+        }
+#ifdef UNITTESTS
     }
+#endif
 }
 
 int ThresholdCacheThreadInit(DetectEngineThreadCtx *det_ctx)
 {
+    if (thread_storage_id.id < 0)
+        return 0;
+
     struct ThresholdCacheThreadCtx *tctx = SCCalloc(1, sizeof(*tctx));
     if (tctx == NULL)
         return -1;