src: doc: remove double-space typos

pull/14559/head
Lukas Sismis 8 months ago committed by Victor Julien
parent 66e595fb10
commit b596073a79

@ -526,7 +526,7 @@ of the interface ::
xdp-mode: hw
use-percpu-hash: no
The load balancing will be done on IP pairs inside the eBPF code, so
The load balancing will be done on IP pairs inside the eBPF code, so
using `cluster_qm` as cluster type is a good idea ::
cluster-type: cluster_qm

@ -2399,7 +2399,7 @@ memory pools per interface. The total size of all mempools of the interface is
set with the ``mempool-size``. The recommend size of the memory pool can be
auto-calculated by setting ``mempool-size: auto``. If ``mempool-size`` is set
manually (to e.g. ``mempool-size: 65536``), the value is divided by the number of
worker cores of the interface (on 4 worker threads, each worker is assigned
worker cores of the interface (on 4 worker threads, each worker is assigned
with a mempool containing 16383 packet objects).
Memory (in bytes) for interface's memory pools is calculated as:
``mempool-size`` * ``mtu``.

@ -15,7 +15,7 @@ There are a few ways of testing Suricata:
- **Static and dynamic analysis tools**: to help in finding bugs, memory leaks and other issues (like `scan-build <https://clang-analyzer.llvm.org/scan-build.html#scanbuild_basicusage>`_, from `clang`, which is also used for our C formatting checks; or ASAN, which checks for memory issues);
- **Fuzz testing**: especially good for uncovering existing, often non-trivial bugs. For more on how to fuzz test Suricata, check :doc:`fuzz-testing`;
- **CI checks**: each PR submitted to the project's public repositories will be run against a suit of Continuous Integration
workflows, as part of our QA process. Those cover: formatting and commit checks; fuzz tests (CI Fuzz), and several builds. See our `github workflows <https://github.com/OISF/suricata/tree/main/.github/workflows>`_ for details and those in
workflows, as part of our QA process. Those cover: formatting and commit checks; fuzz tests (CI Fuzz), and several builds. See our `github workflows <https://github.com/OISF/suricata/tree/main/.github/workflows>`_ for details and those in
action at `<https://github.com/OISF/suricata/actions>`_.
.. note:: If you can run unit tests or other checks and report failures in our `issue tracker <https://redmine.openinfosecfoundation.org/projects/suricata/issues>`_, that is rather useful and appreciated!

@ -53,7 +53,7 @@ org/projects/suricata/issues>`_. Tickets help us keep track of the work done,
indicate when changes need backports etc.
They are also important if you would like to see your new feature officially
added to our tool: the ticket documents your ideas so we can analyze how do they
added to our tool: the ticket documents your ideas so we can analyze how do they
fit in our plans for Suricata, and, if the feature is accepted, we can properly
track progress etc.
@ -149,7 +149,7 @@ The team and/or community members can then consider offering help. It is best
to indicate this prior to doing the actual work, because we will reject features
if no one steps up.
It is also important to note that *community supported* features will be
It is also important to note that *community supported* features will be
disabled by default, and if it brings in new dependencies (libraries or Rust
crates) those will also be optional and disabled by default.

@ -144,7 +144,7 @@ The Frame API calls parameters represent:
- ``frame_type``: type of frame it's being registering (defined in an enum, as shown further above)
- ``tx_id``: an optional transaction id, if the frame belongs to a transaction. May be set later like `frame_len`
``StreamSlice`` contains the input data to the parser, alongside other Stream-related data important in parsing context. Definition is found in *applayer.rs*:
``StreamSlice`` contains the input data to the parser, alongside other Stream-related data important in parsing context. Definition is found in *applayer.rs*:
.. literalinclude:: ../../../../../rust/src/applayer.rs
:caption: rust/src/applayer.rs

@ -309,7 +309,7 @@ Work In Progress changes
An ongoing effort is to limit the number of transactions per flow, to prevent
Denial of Service (DoS) by quadratic complexity - a type of attack that may
happen to protocols which can have multiple transactions at the same time -
such as HTTP2 so-called streams (see https://redmine.openinfosecfoundation.org/issues/4530).
such as HTTP2 so-called streams (see https://redmine.openinfosecfoundation.org/issues/4530).
Common words and abbreviations
==============================

@ -359,7 +359,7 @@ on one network interface card.
With host stack mode, Netmap establishes a pair of host stack mode rings (one each for RX and TX). Packets
pass through the host operating system network protocol stack. Ingress network packets flow from the network
interface card to the network protocol stack and then into the host stack mode rings. Outbound packets
flow from the host stack mode rings to the network protocol stack and finally, to the network interface card.
flow from the host stack mode rings to the network protocol stack and finally, to the network interface card.
Suricata receives packets from the host stack mode rings and, in IPS mode, places packets to be transmitted into
the host stack mode rings. Packets transmitted by Suricata into the host stack mode rings are available for
other host OS applications.

@ -241,9 +241,9 @@ In the af-packet section of suricata.yaml config :
block-size: 1048576
That way 36 worker threads can be mapped (18 per each af-packet interface slot)
in total per CPUs NUMA 1 range - 18-35,54-71. That part is done via the
in total per CPUs NUMA 1 range - 18-35,54-71. That part is done via the
``worker-cpu-set`` affinity settings. ``ring-size`` and ``block-size`` in the
config section above are decent default values to start with. Those can be
config section above are decent default values to start with. Those can be
better adjusted if needed as explained in :doc:`tuning-considerations`.
AMD based systems
@ -359,7 +359,7 @@ this config is positioned on NUMA 0 so starting with 15 RSS queues on that
NUMA node and keeping those off for other tools in the system could offer the
best advantage.
.. note:: Performance and optimization of the whole system can be affected upon regular NIC driver and pkg/kernel upgrades so it should be monitored regularly and tested out in QA/test environments first. As a general suggestion it is always recommended to run the latest stable firmware and drivers as instructed and provided by the particular NIC vendor.
.. note:: Performance and optimization of the whole system can be affected upon regular NIC driver and pkg/kernel upgrades so it should be monitored regularly and tested out in QA/test environments first. As a general suggestion it is always recommended to run the latest stable firmware and drivers as instructed and provided by the particular NIC vendor.
Other considerations
~~~~~~~~~~~~~~~~~~~~

@ -7,7 +7,7 @@ may be trusted, or perhaps a backup stream should be ignored.
Capture Filters (BPF)
---------------------
Through BPFs the capture methods pcap, af-packet, netmap and pf_ring can be
Through BPFs the capture methods pcap, af-packet, netmap and pf_ring can be
told what to send to Suricata, and what not. For example a simple
filter 'tcp' will only capture tcp packets.

@ -136,7 +136,7 @@ Major changes
new default configuration file or :ref:`lua-output-yaml` for more
details.
- If the configuration value ``ftp.memcap`` is invalid, Suricata will set it to ``0`` which means
no limit will be placed. In previous Suricata releases, Suricata would terminate execution. A
no limit will be placed. In previous Suricata releases, Suricata would terminate execution. A
warning message will be displayed `Invalid value <value> for ftp.memcap` when this occurs.
- The utility applications ``suricatasc`` and ``suricatactl`` have
been rewritten in Rust. For most end-users this is a transparent

@ -413,7 +413,7 @@ static int DecodePPPOEtest06(void)
}
/** DecodePPPOEtest07
* \brief Valid PPPOE packet with 8 bit protocol field - check the valid ICMP type is accepted
* \brief Valid PPPOE packet with 8 bit protocol field - check the valid ICMP type is accepted
* \retval 1 Expected test value
*/
static int DecodePPPOEtest07(void)
@ -468,7 +468,7 @@ static int DecodePPPOEtest08(void)
}
/** DecodePPPOEtest09
* \brief Valid PPPOE packet with 16 bit protocol field - check the valid ICMP type is accepted
* \brief Valid PPPOE packet with 16 bit protocol field - check the valid ICMP type is accepted
* \retval 1 Expected test value
*/
static int DecodePPPOEtest09(void)

@ -174,7 +174,7 @@ static int DetectDceStubDataSetup(DetectEngineCtx *de_ctx, Signature *s, const c
#include "detect-engine-alert.h"
/**
* \test Test a valid dce_stub_data entry with bind, bind_ack, request frags.
* \test Test a valid dce_stub_data entry with bind, bind_ack, request frags.
*/
static int DetectDceStubDataTestParse02(void)
{

@ -394,7 +394,7 @@ static int EngineEventTestParse03 (void)
}
/**
* \test EngineEventTestParse04 is a test for an invalid upper case decode-event value
* \test EngineEventTestParse04 is a test for an invalid upper case decode-event value
*/
static int EngineEventTestParse04 (void)
{
@ -408,7 +408,7 @@ static int EngineEventTestParse04 (void)
}
/**
* \test EngineEventTestParse05 is a test for an invalid char into the decode-event value
* \test EngineEventTestParse05 is a test for an invalid char into the decode-event value
*/
static int EngineEventTestParse05 (void)
{

@ -20,7 +20,7 @@
*
* \author Eric Leblond <eric@regit.org>
*
* Implements the mark keyword. Based on detect-gid
* Implements the mark keyword. Based on detect-gid
* by Breno Silva <breno.silva@gmail.com>
*/

@ -3142,7 +3142,7 @@ static uint32_t DetectParseDupSigHashFunc(HashListTable *ht, void *data, uint16_
}
/**
* \brief The Compare function to be used by the hash table -
* \brief The Compare function to be used by the hash table -
* DetectEngineCtx->dup_sig_hash_table.
*
* \param data1 Pointer to the first SigDuplWrapper.

@ -90,7 +90,7 @@ void DetectQuicSniRegister(void)
/**
* \internal
* \brief this function is used to add the parsed sigmatch into the current signature
* \brief this function is used to add the parsed sigmatch into the current signature
*
* \param de_ctx pointer to the Detection Engine Context
* \param s pointer to the Current Signature

@ -90,7 +90,7 @@ void DetectQuicUaRegister(void)
/**
* \internal
* \brief this function is used to add the parsed sigmatch into the current signature
* \brief this function is used to add the parsed sigmatch into the current signature
*
* \param de_ctx pointer to the Detection Engine Context
* \param s pointer to the Current Signature

@ -94,7 +94,7 @@ void DetectQuicVersionRegister(void)
/**
* \internal
* \brief this function is used to add the parsed sigmatch into the current signature
* \brief this function is used to add the parsed sigmatch into the current signature
*
* \param de_ctx pointer to the Detection Engine Context
* \param s pointer to the Current Signature

@ -268,7 +268,7 @@ static bool PcapLogCondition(ThreadVars *tv, void *thread_data, const Packet *p)
/**
* \brief Function to close pcaplog file
*
* \param t Thread Variable containing input/output queue, cpu affinity etc.
* \param t Thread Variable containing input/output queue, cpu affinity etc.
* \param pl PcapLog thread variable.
*/
static int PcapLogCloseFile(ThreadVars *t, PcapLogData *pl)
@ -343,7 +343,7 @@ static void PcapFileNameFree(PcapFileName *pf)
/**
* \brief Function to rotate pcaplog file
*
* \param t Thread Variable containing input/output queue, cpu affinity etc.
* \param t Thread Variable containing input/output queue, cpu affinity etc.
* \param pl PcapLog thread variable.
*
* \retval 0 on success
@ -1210,7 +1210,7 @@ static void PcapLogDataFree(PcapLogData *pl)
/**
* \brief Thread deinit function.
*
* \param t Thread Variable containing input/output queue, cpu affinity etc.
* \param t Thread Variable containing input/output queue, cpu affinity etc.
* \param data PcapLog thread data.
* \retval TM_ECODE_OK on success
* \retval TM_ECODE_FAILED on failure

@ -3773,8 +3773,8 @@ void StreamTcpReassembleRegisterTests(void)
StreamTcpReassembleTest25);
UtRegisterTest("StreamTcpReassembleTest26 -- Gap at middle Reassembly Test",
StreamTcpReassembleTest26);
UtRegisterTest("StreamTcpReassembleTest27 -- Gap at after Reassembly Test",
StreamTcpReassembleTest27);
UtRegisterTest(
"StreamTcpReassembleTest27 -- Gap at after Reassembly Test", StreamTcpReassembleTest27);
UtRegisterTest("StreamTcpReassembleTest28 -- Gap at Start IDS missed packet Reassembly Test",
StreamTcpReassembleTest28);
UtRegisterTest("StreamTcpReassembleTest29 -- Gap at Middle IDS missed packet Reassembly Test",

@ -1185,7 +1185,7 @@ static int StreamTcpPacketIsRetransmission(TcpStream *stream, Packet *p)
* packets while the session state is None which means a newly
* initialized structure, or a fully closed session.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*
@ -2129,7 +2129,7 @@ failure:
* SYN, SYN/ACK, RST packets and correspondingly changes the connection
* state.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*/
@ -2466,7 +2466,7 @@ static int StreamTcpPacketStateSynSent(
* SYN, SYN/ACK, ACK, FIN, RST packets and correspondingly changes
* the connection state.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*
@ -2895,7 +2895,7 @@ static int StreamTcpPacketStateSynRecv(
*
* Timestamp has already been checked at this point.
*
* \param tv Thread Variable containing input/output queue, cpu affinity etc.
* \param tv Thread Variable containing input/output queue, cpu affinity etc.
* \param ssn Pointer to the current TCP session
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
@ -3070,7 +3070,7 @@ static int HandleEstablishedPacketToServer(
*
* Timestamp has already been checked at this point.
*
* \param tv Thread Variable containing input/output queue, cpu affinity etc.
* \param tv Thread Variable containing input/output queue, cpu affinity etc.
* \param ssn Pointer to the current TCP session
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
@ -3397,7 +3397,7 @@ static int StreamTcpPacketIsSpuriousRetransmission(const TcpSession *ssn, Packet
* state. The function handles the data inside packets and call
* StreamTcpReassembleHandleSegment(tv, ) to handle the reassembling.
*
* \param tv Thread Variable containing input/output queue, cpu affinity etc.
* \param tv Thread Variable containing input/output queue, cpu affinity etc.
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*/
@ -3598,7 +3598,7 @@ static int StreamTcpPacketStateEstablished(
* \brief Function to handle the FIN packets for states TCP_SYN_RECV and
* TCP_ESTABLISHED and changes to another TCP state as required.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*
@ -3730,7 +3730,7 @@ static int StreamTcpHandleFin(ThreadVars *tv, StreamTcpThread *stt, TcpSession *
* ACK, FIN, RST packets and correspondingly changes the connection
* state.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*
@ -4175,7 +4175,7 @@ static int StreamTcpPacketStateFinWait1(
* ACK, RST, FIN packets and correspondingly changes the connection
* state.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*/
@ -4473,7 +4473,7 @@ static int StreamTcpPacketStateFinWait2(
* the connection goes to TCP_TIME_WAIT state. The state has been
* reached as both end application has been closed.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*/
@ -4634,7 +4634,7 @@ static int StreamTcpPacketStateClosing(
* packet from server the connection goes to TCP_LAST_ACK state.
* The state is possible only for server host.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*/
@ -4929,7 +4929,7 @@ static int StreamTcpPacketStateCloseWait(
* the connection goes to TCP_CLOSED state and stream memory is
* returned back to pool. The state is possible only for server host.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*/
@ -5050,7 +5050,7 @@ static int StreamTcpPacketStateLastAck(
* the connection goes to TCP_CLOSED state and stream memory is
* returned back to pool.
*
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param tv Thread Variable containing input/output queue, cpu affinity
* \param p Packet which has to be handled in this TCP state.
* \param stt Stream Thread module registered to handle the stream handling
*/

@ -206,7 +206,7 @@ static int NetmaskCount(RADIX_NODE_TYPE *node)
* \param prefix Pointer to the ip prefix that is being checked.
* \param netmask The netmask value for which we will have to return the user_data
* \param exact_match Bool flag which indicates if we should check if the prefix
* holds proper netblock or not.
* holds proper netblock or not.
* \param[out] user_data_result user data pointer
*
* \retval 1 On match.

@ -468,7 +468,7 @@ void SCRConfReferenceHashFree(void *data)
* \brief Loads the Reference info from the reference.config file.
*
* The reference.config file contains references that can be used in
* Signatures. Each line of the file should have the following format -
* Signatures. Each line of the file should have the following format -
* config reference: system_name, reference_url.
*
* \param de_ctx Pointer to the Detection Engine Context that should be updated

@ -2469,7 +2469,7 @@ static int SCThresholdConfTest22(void)
p1->ts = TimeGet();
p2->ts = p3->ts = p1->ts;
/* All should be alerted, only p1 must be dropped due to rate_filter*/
/* All should be alerted, only p1 must be dropped due to rate_filter*/
SigMatchSignatures(&th_v, de_ctx, det_ctx, p1);
FAIL_IF_NOT(PacketTestAction(p1, ACTION_DROP));
FAIL_IF(PacketAlertCheck(p1, 10) != 1);

Loading…
Cancel
Save