diff --git a/src/Makefile.am b/src/Makefile.am index b589dbf526..875f9b8441 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -248,6 +248,7 @@ detect-tcp-flags.c detect-tcp-flags.h \ detect-tcp-seq.c detect-tcp-seq.h \ detect-tcp-window.c detect-tcp-window.h \ detect-tcphdr.c detect-tcphdr.h \ +detect-udphdr.c detect-udphdr.h \ detect-tcpmss.c detect-tcpmss.h \ detect-template.c detect-template.h \ detect-template2.c detect-template2.h \ diff --git a/src/detect-engine-mpm.c b/src/detect-engine-mpm.c index 9ecf78f7db..35ddd59af4 100644 --- a/src/detect-engine-mpm.c +++ b/src/detect-engine-mpm.c @@ -42,7 +42,9 @@ #include "util-memcpy.h" #include "conf.h" #include "detect-fast-pattern.h" + #include "detect-tcphdr.h" +#include "detect-udphdr.h" #include "flow.h" #include "flow-var.h" @@ -1415,12 +1417,20 @@ int PatternMatchPrepareGroup(DetectEngineCtx *de_ctx, SigGroupHead *sh) if (mpm_store != NULL) { PrefilterPktPayloadRegister(de_ctx, sh, mpm_store->mpm_ctx); } + mpm_store = MpmStorePrepareBuffer(de_ctx, sh, MPMB_L4HDR_TS); + if (mpm_store != NULL) { + PrefilterUdpHeaderRegister(de_ctx, sh, mpm_store->mpm_ctx); + } } if (SGH_DIRECTION_TC(sh)) { mpm_store = MpmStorePrepareBuffer(de_ctx, sh, MPMB_UDP_TC); if (mpm_store != NULL) { PrefilterPktPayloadRegister(de_ctx, sh, mpm_store->mpm_ctx); } + mpm_store = MpmStorePrepareBuffer(de_ctx, sh, MPMB_L4HDR_TC); + if (mpm_store != NULL) { + PrefilterUdpHeaderRegister(de_ctx, sh, mpm_store->mpm_ctx); + } } } else { mpm_store = MpmStorePrepareBuffer(de_ctx, sh, MPMB_OTHERIP); diff --git a/src/detect-engine-register.c b/src/detect-engine-register.c index 3f67b8757b..84066e7a63 100644 --- a/src/detect-engine-register.c +++ b/src/detect-engine-register.c @@ -169,6 +169,7 @@ #include "detect-template2.h" #include "detect-tcphdr.h" #include "detect-tcpmss.h" +#include "detect-udphdr.h" #include "detect-krb5-cname.h" #include "detect-krb5-errcode.h" #include "detect-krb5-msgtype.h" @@ -526,6 +527,7 @@ void SigTableSetup(void) DetectTemplateRegister(); DetectTemplate2Register(); DetectTcphdrRegister(); + DetectUdphdrRegister(); DetectTcpmssRegister(); DetectKrb5CNameRegister(); DetectKrb5ErrCodeRegister(); diff --git a/src/detect-engine-register.h b/src/detect-engine-register.h index 76ee057933..c7f38c5784 100644 --- a/src/detect-engine-register.h +++ b/src/detect-engine-register.h @@ -226,6 +226,7 @@ enum { DETECT_TEMPLATE, DETECT_TEMPLATE2, DETECT_TCPHDR, + DETECT_UDPHDR, DETECT_TCPMSS, DETECT_FTPDATA, DETECT_TARGET, diff --git a/src/detect-udphdr.c b/src/detect-udphdr.c new file mode 100644 index 0000000000..2bc5d80df8 --- /dev/null +++ b/src/detect-udphdr.c @@ -0,0 +1,166 @@ +/* Copyright (C) 2007-2019 Open Information Security Foundation + * + * You can copy, redistribute or modify this Program under the terms of + * the GNU General Public License version 2 as published by the Free + * Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * version 2 along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA + * 02110-1301, USA. + */ + +/** + * \file + * + * \author Victor Julien + * + */ + +#include "suricata-common.h" + +#include "detect.h" +#include "detect-parse.h" +#include "detect-engine.h" +#include "detect-engine-prefilter.h" +#include "detect-engine-content-inspection.h" +#include "detect-fast-pattern.h" +#include "detect-udphdr.h" + +/* prototypes */ +static int DetectUdphdrSetup (DetectEngineCtx *, Signature *, const char *); +#ifdef UNITTESTS +void DetectUdphdrRegisterTests (void); +#endif + +/** + * \brief Registration function for tcphdr: keyword + */ + +void DetectUdphdrRegister(void) +{ + sigmatch_table[DETECT_UDPHDR].name = "udp.hdr"; + sigmatch_table[DETECT_UDPHDR].desc = "sticky buffer to match on the UDP header"; + sigmatch_table[DETECT_UDPHDR].url = DOC_URL DOC_VERSION "/rules/header-keywords.html#udphdr"; + sigmatch_table[DETECT_UDPHDR].Setup = DetectUdphdrSetup; + sigmatch_table[DETECT_UDPHDR].flags |= SIGMATCH_NOOPT | SIGMATCH_INFO_STICKY_BUFFER; +#ifdef UNITTESTS + sigmatch_table[DETECT_UDPHDR].RegisterTests = DetectUdphdrRegisterTests; +#endif + SupportFastPatternForSigMatchList(DETECT_SM_LIST_L4HDR, 2); + return; +} + +/** + * \brief this function is used to atcphdrd the parsed tcphdr data into the current signature + * + * \param de_ctx pointer to the Detection Engine Context + * \param s pointer to the Current Signature + * \param tcphdrstr pointer to the user provided tcphdr options + * + * \retval 0 on Success + * \retval -1 on Failure + */ +static int DetectUdphdrSetup (DetectEngineCtx *de_ctx, Signature *s, const char *tcphdrstr) +{ + if (!(DetectProtoContainsProto(&s->proto, IPPROTO_UDP))) + return -1; + + s->flags |= SIG_FLAG_REQUIRE_PACKET; + + if (DetectBufferSetActiveList(s, DETECT_SM_LIST_L4HDR) < 0) + return -1; + + return 0; +} + +static void PrefilterUdpHeader(DetectEngineThreadCtx *det_ctx, + Packet *p, const void *pectx) +{ + SCEnter(); + + if (((uint8_t *)p->udph + (ptrdiff_t)UDP_HEADER_LEN) > + ((uint8_t *)GET_PKT_DATA(p) + (ptrdiff_t)GET_PKT_LEN(p))) + { + SCLogDebug("data out of range: %p > %p", + ((uint8_t *)p->udph + (ptrdiff_t)UDP_HEADER_LEN), + ((uint8_t *)GET_PKT_DATA(p) + (ptrdiff_t)GET_PKT_LEN(p))); + SCReturn; + } + + const MpmCtx *mpm_ctx = (MpmCtx *)pectx; + if (UDP_HEADER_LEN < mpm_ctx->minlen) + SCReturn; + + (void)mpm_table[mpm_ctx->mpm_type].Search(mpm_ctx, + &det_ctx->mtc, &det_ctx->pmq, + (uint8_t *)p->udph, UDP_HEADER_LEN); +} + +int PrefilterUdpHeaderRegister(DetectEngineCtx *de_ctx, + SigGroupHead *sgh, MpmCtx *mpm_ctx) +{ + return PrefilterAppendEngine(de_ctx, sgh, + PrefilterUdpHeader, mpm_ctx, NULL, "udp.hdr"); +} + +/** + * \brief Do the content inspection & validation for a signature + * + * \param det_ctx Detection engine thread context + * \param s Signature to inspect + * \param p Packet + * + * \retval false no match + * \retval true match + */ +bool DetectEngineInspectRuleUdpHeaderMatches( + ThreadVars *tv, DetectEngineThreadCtx *det_ctx, + const Signature *s, const SigMatchData *sm_data, + Flow *f, Packet *p, + uint8_t *alert_flags) +{ + SCEnter(); + + BUG_ON(sm_data == NULL); + BUG_ON(sm_data != s->sm_arrays[DETECT_SM_LIST_L4HDR]); + + if (!(PKT_IS_UDP(p))) { + SCReturnInt(false); + } + if (((uint8_t *)p->udph + (ptrdiff_t)UDP_HEADER_LEN) > + ((uint8_t *)GET_PKT_DATA(p) + (ptrdiff_t)GET_PKT_LEN(p))) + { + SCLogDebug("data out of range: %p > %p", + ((uint8_t *)p->udph + (ptrdiff_t)UDP_HEADER_LEN), + ((uint8_t *)GET_PKT_DATA(p) + (ptrdiff_t)GET_PKT_LEN(p))); + SCReturnInt(false); + } + +#ifdef DEBUG + det_ctx->payload_persig_cnt++; + det_ctx->payload_persig_size += UDP_HEADER_LEN; +#endif + det_ctx->buffer_offset = 0; + det_ctx->discontinue_matching = 0; + det_ctx->inspection_recursion_counter = 0; + det_ctx->replist = NULL; + + int r = DetectEngineContentInspection(det_ctx->de_ctx, det_ctx, + s, sm_data, + p, NULL, (uint8_t *)p->udph, UDP_HEADER_LEN, 0, + DETECT_CI_FLAGS_SINGLE, DETECT_ENGINE_CONTENT_INSPECTION_MODE_HEADER); + if (r == 1) { + SCReturnInt(true); + } + SCReturnInt(false); +} + +#ifdef UNITTESTS +#include "tests/detect-udphdr.c" +#endif diff --git a/src/detect-udphdr.h b/src/detect-udphdr.h new file mode 100644 index 0000000000..29a7e07bbb --- /dev/null +++ b/src/detect-udphdr.h @@ -0,0 +1,36 @@ +/* Copyright (C) 2007-2019 Open Information Security Foundation + * + * You can copy, redistribute or modify this Program under the terms of + * the GNU General Public License version 2 as published by the Free + * Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * version 2 along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA + * 02110-1301, USA. + */ + +/** + * \file + * + * \author Victor Julien + */ + +#ifndef _DETECT_UDPHDR_H +#define _DETECT_UDPHDR_H + +int PrefilterUdpHeaderRegister(DetectEngineCtx *de_ctx, + SigGroupHead *sgh, MpmCtx *mpm_ctx); +bool DetectEngineInspectRuleUdpHeaderMatches( + ThreadVars *tv, DetectEngineThreadCtx *det_ctx, + const Signature *s, const SigMatchData *sm_data, + Flow *f, Packet *p, + uint8_t *alert_flags); +void DetectUdphdrRegister(void); + +#endif /* _DETECT_UDPHDR_H */ diff --git a/src/tests/detect-udphdr.c b/src/tests/detect-udphdr.c new file mode 100644 index 0000000000..5e661fb57b --- /dev/null +++ b/src/tests/detect-udphdr.c @@ -0,0 +1,47 @@ +/* Copyright (C) 2007-2018 Open Information Security Foundation + * + * You can copy, redistribute or modify this Program under the terms of + * the GNU General Public License version 2 as published by the Free + * Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * version 2 along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA + * 02110-1301, USA. + */ + +#include "../suricata-common.h" + +#include "../detect.h" +#include "../detect-parse.h" +#include "../detect-engine-prefilter-common.h" + +#include "../detect-tcphdr.h" + +#include "../util-unittest.h" + +static int DetectUdphdrParseTest01 (void) +{ + DetectEngineCtx *de_ctx = DetectEngineCtxInit(); + FAIL_IF_NULL(de_ctx); + + Signature *sig = DetectEngineAppendSig(de_ctx, + "alert udp any any -> any any (udp.hdr; content:\"A\"; sid:1; rev:1;)"); + FAIL_IF_NULL(sig); + + DetectEngineCtxFree(de_ctx); + PASS; +} + +/** + * \brief this function registers unit tests for DetectUdphdr + */ +void DetectUdphdrRegisterTests(void) +{ + UtRegisterTest("DetectUdphdrParseTest01", DetectUdphdrParseTest01); +}