detect/firewall: minor code cleanup

1 month ago · a9b3ad49ea
parent 4db84cfa28
commit a9b3ad49ea
1 changed files with 5 additions and 6 deletions
--- a/src/detect.c
+++ b/src/detect.c
@ -2447,12 +2447,11 @@ static void DetectRunTx(ThreadVars *tv,
             * policies. */
            const int r = DetectTxFirewallNoRulesApplyPolicies(
                    det_ctx, p, f, &tx, alproto, flow_flags, array_idx, last_tx);
-            if (r != 0) {
-                if (r == 1) {
-                    SCLogDebug("done");
-                    return;
-                } else if (r == 2)
-                    goto next_tx_fw; /* next tx */
+            if (r == 1) {
+                SCLogDebug("done");
+                return;
+            } else if (r == 2) {
+                goto next_tx_fw; /* next tx, need to clean up buffers */
            }
        }