From a8f257e05f1227771078ad797bc9b72313d70476 Mon Sep 17 00:00:00 2001
From: Victor Julien <victor@inliniac.net>
Date: Fri, 27 May 2016 16:39:14 +0200
Subject: [PATCH] detect: no longer a thread module

Like stream, detect is now invoked directly by the FlowWorker.
---
 src/detect.c            | 36 ------------------------------------
 src/runmode-unittests.c |  1 +
 src/suricata.c          |  2 --
 src/tm-modules.c        |  1 -
 src/tm-threads-common.h |  1 -
 5 files changed, 1 insertion(+), 40 deletions(-)

diff --git a/src/detect.c b/src/detect.c
index 860b330b3d..9fb005fcf1 100644
--- a/src/detect.c
+++ b/src/detect.c
@@ -219,32 +219,6 @@ void DbgPrintSigs(DetectEngineCtx *, SigGroupHead *);
 void DbgPrintSigs2(DetectEngineCtx *, SigGroupHead *);
 static void PacketCreateMask(Packet *, SignatureMask *, uint16_t, int, StreamMsg *, int);
 
-/* tm module api functions */
-TmEcode Detect(ThreadVars *, Packet *, void *, PacketQueue *, PacketQueue *);
-TmEcode DetectThreadInit(ThreadVars *, void *, void **);
-TmEcode DetectThreadDeinit(ThreadVars *, void *);
-
-void TmModuleDetectRegister (void)
-{
-    tmm_modules[TMM_DETECT].name = "Detect";
-    tmm_modules[TMM_DETECT].ThreadInit = DetectThreadInit;
-    tmm_modules[TMM_DETECT].Func = Detect;
-    tmm_modules[TMM_DETECT].ThreadExitPrintStats = DetectExitPrintStats;
-    tmm_modules[TMM_DETECT].ThreadDeinit = DetectThreadDeinit;
-    tmm_modules[TMM_DETECT].RegisterTests = SigRegisterTests;
-    tmm_modules[TMM_DETECT].cap_flags = 0;
-    tmm_modules[TMM_DETECT].flags = TM_FLAG_DETECT_TM;
-
-    PacketAlertTagInit();
-}
-
-void DetectExitPrintStats(ThreadVars *tv, void *data)
-{
-    DetectEngineThreadCtx *det_ctx = (DetectEngineThreadCtx *)data;
-    if (det_ctx == NULL)
-        return;
-}
-
 /**
  *  \brief Create the path if default-rule-path was specified
  *  \param sig_file The name of the file
@@ -2062,16 +2036,6 @@ error:
     return TM_ECODE_FAILED;
 }
 
-TmEcode DetectThreadInit(ThreadVars *t, void *initdata, void **data)
-{
-    return DetectEngineThreadCtxInit(t,initdata,data);
-}
-
-TmEcode DetectThreadDeinit(ThreadVars *t, void *data)
-{
-    return DetectEngineThreadCtxDeinit(t,data);
-}
-
 void SigCleanSignatures(DetectEngineCtx *de_ctx)
 {
     Signature *s = NULL, *ns;
diff --git a/src/runmode-unittests.c b/src/runmode-unittests.c
index 74e194afc0..b5d22bd3b1 100644
--- a/src/runmode-unittests.c
+++ b/src/runmode-unittests.c
@@ -196,6 +196,7 @@ void RunUnittests(int list_unittests, char *regex_arg)
     UtInitialize();
     UTHRegisterTests();
     StreamTcpRegisterTests();
+    SigRegisterTests();
     SCReputationRegisterTests();
     TmModuleRegisterTests();
     SigTableRegisterTests();
diff --git a/src/suricata.c b/src/suricata.c
index b619233ca3..4b77edf240 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -859,8 +859,6 @@ void RegisterAllModules()
 
     /* flow worker */
     TmModuleFlowWorkerRegister();
-    /* detection */
-    TmModuleDetectRegister();
     /* respond-reject */
     TmModuleRespondRejectRegister();
 
diff --git a/src/tm-modules.c b/src/tm-modules.c
index 0b835fa345..6627a822a1 100644
--- a/src/tm-modules.c
+++ b/src/tm-modules.c
@@ -211,7 +211,6 @@ const char * TmModuleTmmIdToString(TmmId id)
         CASE_CODE (TMM_DECODEPCAPFILE);
         CASE_CODE (TMM_RECEIVEPFRING);
         CASE_CODE (TMM_DECODEPFRING);
-        CASE_CODE (TMM_DETECT);
         CASE_CODE (TMM_ALERTFASTLOG);
         CASE_CODE (TMM_ALERTFASTLOG4);
         CASE_CODE (TMM_ALERTFASTLOG6);
diff --git a/src/tm-threads-common.h b/src/tm-threads-common.h
index ed442ba8e0..af04988f57 100644
--- a/src/tm-threads-common.h
+++ b/src/tm-threads-common.h
@@ -41,7 +41,6 @@ typedef enum {
     TMM_DECODEPCAPFILE,
     TMM_RECEIVEPFRING,
     TMM_DECODEPFRING,
-    TMM_DETECT,
     TMM_ALERTFASTLOG,
     TMM_ALERTFASTLOG4,
     TMM_ALERTFASTLOG6,