flow: avoid double state update on reuse

Avoids an unnecessary atomic operation.
5 years ago · 9b13c1b804
parent fd2dff8542
commit 9b13c1b804
1 changed files with 1 additions and 2 deletions
--- a/src/flow-hash.c
+++ b/src/flow-hash.c
@ -574,6 +574,7 @@ static Flow *TcpReuseReplace(ThreadVars *tv, DecodeThreadVars *dtv,
    FlowInit(f, p);
    f->flow_hash = hash;
    f->fb = fb;
+    FlowUpdateState(f, FLOW_STATE_NEW);

    f->thread_id[0] = thread_id[0];
    f->thread_id[1] = thread_id[1];
@ -952,8 +953,6 @@ static Flow *FlowGetUsedFlow(ThreadVars *tv, DecodeThreadVars *dtv)

        FlowClearMemory(f, f->protomap);

-        FlowUpdateState(f, FLOW_STATE_NEW);
-
        FLOWLOCK_UNLOCK(f);
        return f;
    }