scan-build: fix potential 0 size allocation warnings

pull/8763/head
Victor Julien 2 years ago
parent 0265c13550
commit 9586aed43b

@ -111,6 +111,10 @@ static int FlowbitOrAddData(DetectEngineCtx *de_ctx, DetectFlowbitsData *cd, cha
next: next:
arrptr = NULL; arrptr = NULL;
} }
if (i == 0) {
SCLogError("No valid flowbits specified");
return -1;
}
cd->or_list_size = i; cd->or_list_size = i;
cd->or_list = SCCalloc(cd->or_list_size, sizeof(uint32_t)); cd->or_list = SCCalloc(cd->or_list_size, sizeof(uint32_t));

@ -101,6 +101,10 @@ Pool *PoolInit(uint32_t size, uint32_t prealloc_size, uint32_t elt_size,
sc_errno = SC_EINVAL; sc_errno = SC_EINVAL;
goto error; goto error;
} }
if (elt_size == 0 && Alloc == NULL) {
sc_errno = SC_EINVAL;
goto error;
}
/* setup the filter */ /* setup the filter */
p = SCMalloc(sizeof(Pool)); p = SCMalloc(sizeof(Pool));

@ -133,7 +133,7 @@ static SCRadixPrefix *SCRadixCreatePrefix(uint8_t *key_stream,
{ {
SCRadixPrefix *prefix = NULL; SCRadixPrefix *prefix = NULL;
if ((key_bitlen % 8 != 0)) { if (key_bitlen == 0 || (key_bitlen % 8 != 0)) {
SCLogError("Invalid argument bitlen - %d", key_bitlen); SCLogError("Invalid argument bitlen - %d", key_bitlen);
return NULL; return NULL;
} }

Loading…
Cancel
Save