detect/bytetest: don't print errors at runtime

pull/3652/head
Victor Julien 7 years ago
parent 25112ee7e3
commit 94191ea960

@ -157,7 +157,7 @@ int DetectBytetestDoMatch(DetectEngineThreadCtx *det_ctx,
SCLogDebug("No Numeric value"); SCLogDebug("No Numeric value");
SCReturnInt(0); SCReturnInt(0);
} else { } else {
SCLogError(SC_ERR_INVALID_NUM_BYTES, "Error extracting %d " SCLogDebug("error extracting %d "
"bytes of string data: %d", data->nbytes, extbytes); "bytes of string data: %d", data->nbytes, extbytes);
SCReturnInt(-1); SCReturnInt(-1);
} }
@ -171,8 +171,8 @@ int DetectBytetestDoMatch(DetectEngineThreadCtx *det_ctx,
BYTE_LITTLE_ENDIAN : BYTE_BIG_ENDIAN; BYTE_LITTLE_ENDIAN : BYTE_BIG_ENDIAN;
extbytes = ByteExtractUint64(&val, endianness, data->nbytes, ptr); extbytes = ByteExtractUint64(&val, endianness, data->nbytes, ptr);
if (extbytes != data->nbytes) { if (extbytes != data->nbytes) {
SCLogError(SC_ERR_INVALID_NUM_BYTES, "Error extracting %d bytes " SCLogDebug("error extracting %d bytes "
"of numeric data: %d\n", data->nbytes, extbytes); "of numeric data: %d", data->nbytes, extbytes);
SCReturnInt(-1); SCReturnInt(-1);
} }

@ -149,7 +149,7 @@ int ByteExtractString(uint64_t *res, int base, uint16_t len, const char *str)
char strbuf[24]; char strbuf[24];
if (len > 23) { if (len > 23) {
SCLogError(SC_ERR_ARG_LEN_LONG, "len too large (23 max)"); SCLogDebug("len too large (23 max)");
return -1; return -1;
} }
@ -164,15 +164,15 @@ int ByteExtractString(uint64_t *res, int base, uint16_t len, const char *str)
*res = strtoull(ptr, &endptr, base); *res = strtoull(ptr, &endptr, base);
if (errno == ERANGE) { if (errno == ERANGE) {
SCLogError(SC_ERR_NUMERIC_VALUE_ERANGE, "Numeric value out of range"); SCLogDebug("numeric value out of range");
return -1; return -1;
/* If there is no numeric value in the given string then strtoull(), makes /* If there is no numeric value in the given string then strtoull(), makes
endptr equals to ptr and return 0 as result */ endptr equals to ptr and return 0 as result */
} else if (endptr == ptr && *res == 0) { } else if (endptr == ptr && *res == 0) {
SCLogDebug("No numeric value"); SCLogDebug("no numeric value");
return -1; return -1;
} else if (endptr == ptr) { } else if (endptr == ptr) {
SCLogError(SC_ERR_INVALID_NUMERIC_VALUE, "Invalid numeric value"); SCLogDebug("invalid numeric value");
return -1; return -1;
} }
/* This will interfere with some rules that do not know the length /* This will interfere with some rules that do not know the length

Loading…
Cancel
Save