app-layer-ssl: fix use-after-free (CID 1433623)

Ja3BufferAddValue frees the buffer on error, so there is no point
in doing it twice (use-after-free).
pull/3321/head
Mats Klepsland 8 years ago committed by Victor Julien
parent fc0e339467
commit 900c27e235

@ -660,7 +660,6 @@ static inline int TLSDecodeHSHelloCipherSuites(SSLState *ssl_state,
if (TLSDecodeValueIsGREASE(cipher_suite) != 1) {
rc = Ja3BufferAddValue(ja3_cipher_suites, cipher_suite);
if (rc != 0) {
Ja3BufferFree(&ja3_cipher_suites);
return -1;
}
}

Loading…
Cancel
Save