pcre: fixes a memory leak on alloc error

4 years ago · 8a50edbd10
parent 8536048443
commit 8a50edbd10
1 changed files with 3 additions and 2 deletions
--- a/src/detect-pcre.c
+++ b/src/detect-pcre.c
@ -266,8 +266,9 @@ int DetectPcrePayloadMatch(DetectEngineThreadCtx *det_ctx, const Signature *s,
                        capture_len = (capture_len < 0xffff) ? (uint16_t)capture_len : 0xffff;
                        uint8_t *str_ptr2 = SCMalloc(capture_len);
                        if (unlikely(str_ptr2 == NULL)) {
-                            pcre2_substring_free((PCRE2_UCHAR8 *)pcre2_str_ptr);
-                            continue;
+                            SCFree(str_ptr);
+                            pcre2_substring_free((PCRE2_UCHAR8 *)pcre2_str_ptr2);
+                            break;
                        }
                        memcpy(str_ptr2, pcre2_str_ptr2, capture_len);
                        pcre2_substring_free((PCRE2_UCHAR8 *)pcre2_str_ptr2);