From 7e2ed11a11cae89bc07e9a25425192581687993d Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Tue, 26 Apr 2022 21:33:52 +0200 Subject: [PATCH] detect: fix bad BUG_ON pattern cppcheck: src/detect-engine-uint.c:73:13: warning: Conversion of string literal "unknown mode" to bool always evaluates to true. [incorrectStringBooleanError] BUG_ON("unknown mode"); ^ src/detect-engine-uint.c:328:13: warning: Conversion of string literal "unknown mode" to bool always evaluates to true. [incorrectStringBooleanError] BUG_ON("unknown mode"); ^ src/detect-pcre.c:291:25: warning: Conversion of string literal "Impossible captype" to bool always evaluates to true. [incorrectStringBooleanError] BUG_ON("Impossible captype"); ^ Bug: #5291. --- src/detect-engine-uint.c | 4 ++-- src/detect-pcre.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/detect-engine-uint.c b/src/detect-engine-uint.c index d44c6bfaf2..c8cf28dd72 100644 --- a/src/detect-engine-uint.c +++ b/src/detect-engine-uint.c @@ -70,7 +70,7 @@ int DetectU32Match(const uint32_t parg, const DetectU32Data *du32) } return 0; default: - BUG_ON("unknown mode"); + BUG_ON(1); // unknown mode } return 0; } @@ -325,7 +325,7 @@ int DetectU8Match(const uint8_t parg, const DetectU8Data *du8) } return 0; default: - BUG_ON("unknown mode"); + BUG_ON(1); // unknown mode } return 0; } diff --git a/src/detect-pcre.c b/src/detect-pcre.c index 4311fcad52..6f89ba8463 100644 --- a/src/detect-pcre.c +++ b/src/detect-pcre.c @@ -288,7 +288,7 @@ int DetectPcrePayloadMatch(DetectEngineThreadCtx *det_ctx, const Signature *s, (uint8_t *)str_ptr, capture_len, DETECT_VAR_TYPE_FLOW_POSTMATCH); } else { - BUG_ON("Impossible captype"); + BUG_ON(1); // Impossible captype SCFree(str_ptr); } }