Make sure to only alloc a new pseudo packet once during ip defrag.

src/decode-tcp.c

@@ -164,6 +164,7 @@ void DecodeTCP(ThreadVars *tv, DecodeThreadVars *dtv, Packet *p, uint8_t *pkt, u
     SCPerfCounterIncr(dtv->counter_tcp, tv->sc_perf_pca);
 
     if (unlikely(DecodeTCPPacket(tv, p,pkt,len) < 0)) {
+        SCLogDebug("invalid TCP packet");
         p->tcph = NULL;
         return;
     }

src/defrag.c

@@ -551,6 +551,7 @@ Defrag4Reassemble(ThreadVars *tv, DefragContext *dc, DefragTracker *tracker,
         if (frag->data_len - frag->ltrim <= 0)
             continue;
         if (frag->offset == 0) {
+            if (rp == NULL) {
                 /* Allocate a Packet for the reassembled packet.  On failure we
                  * SCFree all the resources held by this tracker. */
                 rp = PacketPseudoPktSetup(p, frag->pkt, frag->len,
@@ -562,6 +563,7 @@ Defrag4Reassemble(ThreadVars *tv, DefragContext *dc, DefragTracker *tracker,
                 }
                 SCLogDebug("Packet rp %p, p %p, rp->root %p", rp, p, rp->root);
                 rp->recursion_level = p->recursion_level;
+            }
 
             hlen = frag->hlen;
             ip_hdr_offset = frag->ip_hdr_offset;
@@ -878,8 +880,9 @@ DefragInsertFrag(ThreadVars *tv, DecodeThreadVars *dtv, DefragContext *dc,
                 if ((frag_offset >= prev->offset) &&
                     (frag_end <= prev->offset + prev->data_len))
                     goto done;
-                if (frag_offset < prev->offset)
+                if (frag_offset < prev->offset) {
                     goto insert;
+                }
                 if (frag_offset < prev->offset + prev->data_len) {
                     ltrim = prev->offset + prev->data_len - frag_offset;
                     goto insert;
@@ -887,8 +890,9 @@ DefragInsertFrag(ThreadVars *tv, DecodeThreadVars *dtv, DefragContext *dc,
                 break;
             case DEFRAG_POLICY_LAST:
                 if (frag_offset <= prev->offset) {
-                    if (frag_end > prev->offset)
+                    if (frag_end > prev->offset) {
                         prev->ltrim = frag_end - prev->offset;
+                    }
                     goto insert;
                 }
                 break;