http: simplify tx removal interface

rust/htp/src/c_api/transaction.rs

@@ -8,9 +8,9 @@ use std::convert::{TryFrom, TryInto};
 /// # Safety
 /// When calling this method, you have to ensure that tx is either properly initialized or NULL
 #[no_mangle]
-pub unsafe extern "C" fn htp_tx_destroy(connp: *mut ConnectionParser, tx: *const Transaction) {
-    if let (Some(connp), Some(tx)) = (connp.as_mut(), tx.as_ref()) {
-        connp.remove_tx(tx.index)
+pub unsafe extern "C" fn htp_tx_destroy(connp: *mut ConnectionParser, index: usize) {
+    if let Some(connp) = connp.as_mut() {
+        connp.remove_tx(index)
     }
 }
 

src/app-layer-htp.c

@@ -536,11 +536,7 @@ static void HTPStateTransactionFree(void *state, uint64_t id)
     HtpState *s = (HtpState *)state;
 
     SCLogDebug("state %p, id %"PRIu64, s, id);
-
-    htp_tx_t *tx = HTPStateGetTx(s, id);
-    if (tx != NULL) {
-        htp_tx_destroy(s->connp, tx);
-    }
+    htp_tx_destroy(s->connp, id);
 }
 
 /**