aiden
/
suricata
mirror of https://github.com/OISF/suricata
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

unittests: don't leak memory in checks

Browse Source 
Result of bstr_util_strdup_to_c needs to be freed
pull/14025/head
Victor Julien 2 months ago committed by Victor Julien
parent 28ae95e8da
commit 73c1c489f7
2 changed files with 33 additions and 11 deletions
Show Stats Download Patch File Download Diff File

32
src/app-layer-htp-file.c
Unescape Escape View File

@ -404,7 +404,9 @@ static int HTPFileParserTest01(void)
FAIL_IF_NULL(tx);
FAIL_IF_NULL(htp_tx_request_method(tx));
FAIL_IF(memcmp(bstr_util_strdup_to_c(htp_tx_request_method(tx)), "POST", 4) != 0);
char *m = bstr_util_strdup_to_c(htp_tx_request_method(tx));
FAIL_IF(memcmp(m, "POST", 4) != 0);
SCFree(m);
AppLayerParserThreadCtxFree(alp_tctx);
StreamTcpFreeConfig(true);
@ -477,7 +479,9 @@ static int HTPFileParserTest02(void)
htp_tx_t *tx = AppLayerParserGetTx(IPPROTO_TCP, ALPROTO_HTTP1, http_state, 0);
FAIL_IF_NULL(tx);
FAIL_IF_NULL(htp_tx_request_method(tx));
FAIL_IF(memcmp(bstr_util_strdup_to_c(htp_tx_request_method(tx)), "POST", 4) != 0);
char *m = bstr_util_strdup_to_c(htp_tx_request_method(tx));
FAIL_IF(memcmp(m, "POST", 4) != 0);
SCFree(m);
HtpTxUserData *tx_ud = htp_tx_get_user_data(tx);
FAIL_IF_NULL(tx_ud);
FAIL_IF_NULL(tx_ud->files_ts.tail);
@ -570,7 +574,9 @@ static int HTPFileParserTest03(void)
FAIL_IF_NULL(tx);
FAIL_IF_NULL(htp_tx_request_method(tx));
FAIL_IF(memcmp(bstr_util_strdup_to_c(htp_tx_request_method(tx)), "POST", 4) != 0);
char *m = bstr_util_strdup_to_c(htp_tx_request_method(tx));
FAIL_IF(memcmp(m, "POST", 4) != 0);
SCFree(m);
HtpTxUserData *tx_ud = htp_tx_get_user_data(tx);
FAIL_IF_NULL(tx_ud);
@ -666,7 +672,9 @@ static int HTPFileParserTest04(void)
FAIL_IF_NULL(tx);
FAIL_IF_NULL(htp_tx_request_method(tx));
FAIL_IF(memcmp(bstr_util_strdup_to_c(htp_tx_request_method(tx)), "POST", 4) != 0);
char *m = bstr_util_strdup_to_c(htp_tx_request_method(tx));
FAIL_IF(memcmp(m, "POST", 4) != 0);
SCFree(m);
HtpTxUserData *tx_ud = htp_tx_get_user_data(tx);
FAIL_IF_NULL(tx_ud);
@ -732,7 +740,9 @@ static int HTPFileParserTest05(void)
FAIL_IF_NULL(tx);
FAIL_IF_NULL(htp_tx_request_method(tx));
FAIL_IF(memcmp(bstr_util_strdup_to_c(htp_tx_request_method(tx)), "POST", 4) != 0);
char *m = bstr_util_strdup_to_c(htp_tx_request_method(tx));
FAIL_IF(memcmp(m, "POST", 4) != 0);
SCFree(m);
HtpTxUserData *tx_ud = htp_tx_get_user_data(tx);
FAIL_IF_NULL(tx_ud);
@ -807,7 +817,9 @@ static int HTPFileParserTest06(void)
FAIL_IF_NULL(tx);
FAIL_IF_NULL(htp_tx_request_method(tx));
FAIL_IF(memcmp(bstr_util_strdup_to_c(htp_tx_request_method(tx)), "POST", 4) != 0);
char *m = bstr_util_strdup_to_c(htp_tx_request_method(tx));
FAIL_IF(memcmp(m, "POST", 4) != 0);
SCFree(m);
HtpTxUserData *tx_ud = htp_tx_get_user_data(tx);
FAIL_IF_NULL(tx_ud);
@ -871,7 +883,9 @@ static int HTPFileParserTest07(void)
htp_tx_t *tx = AppLayerParserGetTx(IPPROTO_TCP, ALPROTO_HTTP1, http_state, 0);
FAIL_IF_NULL(tx);
FAIL_IF_NULL(htp_tx_request_method(tx));
FAIL_IF(memcmp(bstr_util_strdup_to_c(htp_tx_request_method(tx)), "POST", 4) != 0);
char *m = bstr_util_strdup_to_c(htp_tx_request_method(tx));
FAIL_IF(memcmp(m, "POST", 4) != 0);
SCFree(m);
HtpTxUserData *tx_ud = htp_tx_get_user_data(tx);
FAIL_IF_NULL(tx_ud);
@ -1194,7 +1208,9 @@ static int HTPFileParserTest11(void)
FAIL_IF_NULL(tx);
FAIL_IF_NULL(htp_tx_request_method(tx));
FAIL_IF(memcmp(bstr_util_strdup_to_c(htp_tx_request_method(tx)), "POST", 4) != 0);
char *m = bstr_util_strdup_to_c(htp_tx_request_method(tx));
FAIL_IF(memcmp(m, "POST", 4) != 0);
SCFree(m);
HtpTxUserData *tx_ud = htp_tx_get_user_data(tx);
FAIL_IF_NULL(tx_ud);

12
src/app-layer-htp.c
Unescape Escape View File

@ -2784,7 +2784,9 @@ static int HTPParserTest01b(void)
const htp_header_t *h = htp_tx_request_header_index(tx, 0);
FAIL_IF_NULL(h);
FAIL_IF(strcmp(bstr_util_strdup_to_c(htp_header_value(h)), "Victor/1.0"));
char *v = bstr_util_strdup_to_c(htp_header_value(h));
FAIL_IF(strcmp(v, "Victor/1.0"));
SCFree(v);
FAIL_IF(htp_tx_request_method_number(tx) != HTP_METHOD_POST);
FAIL_IF(htp_tx_request_protocol_number(tx) != HTP_PROTOCOL_V1_0);
@ -2839,7 +2841,9 @@ static int HTPParserTest01c(void)
const htp_header_t *h = htp_tx_request_header_index(tx, 0);
FAIL_IF_NULL(h);
FAIL_IF(strcmp(bstr_util_strdup_to_c(htp_header_value(h)), "Victor/1.0"));
char *v = bstr_util_strdup_to_c(htp_header_value(h));
FAIL_IF(strcmp(v, "Victor/1.0"));
SCFree(v);
FAIL_IF(htp_tx_request_method_number(tx) != HTP_METHOD_POST);
FAIL_IF(htp_tx_request_protocol_number(tx) != HTP_PROTOCOL_V1_0);
@ -2895,7 +2899,9 @@ static int HTPParserTest01a(void)
const htp_header_t *h = htp_tx_request_header_index(tx, 0);
FAIL_IF_NULL(h);
FAIL_IF(strcmp(bstr_util_strdup_to_c(htp_header_value(h)), "Victor/1.0"));
char *v = bstr_util_strdup_to_c(htp_header_value(h));
FAIL_IF(strcmp(v, "Victor/1.0"));
SCFree(v);
FAIL_IF(htp_tx_request_method_number(tx) != HTP_METHOD_POST);
FAIL_IF(htp_tx_request_protocol_number(tx) != HTP_PROTOCOL_V1_0);

Write Preview
Loading…
Cancel
Save