diff --git a/src/runmode-erf-file.c b/src/runmode-erf-file.c index abb85244a2..f449a953a2 100644 --- a/src/runmode-erf-file.c +++ b/src/runmode-erf-file.c @@ -207,7 +207,7 @@ int RunModeErfFileAutoFp(void) SCLogDebug("tname %s, qname %s", tname, qname); - SCLogDebug("Assigning %s affinity to cpu %u", thread_name, cpu); + SCLogDebug("Assigning %s affinity to cpu %u", tname, cpu); ThreadVars *tv_detect_ncpu = TmThreadCreatePacketHandler(tname, diff --git a/src/runmodes.c b/src/runmodes.c index 65cccdea2d..b4bf31b6c7 100644 --- a/src/runmodes.c +++ b/src/runmodes.c @@ -59,16 +59,16 @@ int debuglog_enabled = 0; /* Runmode Global Thread Names */ -char *thread_name_autofp = "RX"; -char *thread_name_single = "W"; -char *thread_name_workers = "W"; -char *thread_name_verdict = "TX"; -char *thread_name_flow_mgr = "FM"; -char *thread_name_flow_rec = "FR"; -char *thread_name_unix_socket = "US"; -char *thread_name_detect_loader = "DL"; -char *thread_name_counter_stats = "CS"; -char *thread_name_counter_wakeup = "CW"; +const char *thread_name_autofp = "RX"; +const char *thread_name_single = "W"; +const char *thread_name_workers = "W"; +const char *thread_name_verdict = "TX"; +const char *thread_name_flow_mgr = "FM"; +const char *thread_name_flow_rec = "FR"; +const char *thread_name_unix_socket = "US"; +const char *thread_name_detect_loader = "DL"; +const char *thread_name_counter_stats = "CS"; +const char *thread_name_counter_wakeup = "CW"; /** * \brief Holds description for a runmode. diff --git a/src/runmodes.h b/src/runmodes.h index 165bfe45c8..d935b9a3fe 100644 --- a/src/runmodes.h +++ b/src/runmodes.h @@ -61,16 +61,16 @@ enum { }; /* Run Mode Global Thread Names */ -extern char *thread_name_autofp; -extern char *thread_name_single; -extern char *thread_name_workers; -extern char *thread_name_verdict; -extern char *thread_name_flow_mgr; -extern char *thread_name_flow_rec; -extern char *thread_name_unix_socket; -extern char *thread_name_detect_loader; -extern char *thread_name_counter_stats; -extern char *thread_name_counter_wakeup; +extern const char *thread_name_autofp; +extern const char *thread_name_single; +extern const char *thread_name_workers; +extern const char *thread_name_verdict; +extern const char *thread_name_flow_mgr; +extern const char *thread_name_flow_rec; +extern const char *thread_name_unix_socket; +extern const char *thread_name_detect_loader; +extern const char *thread_name_counter_stats; +extern const char *thread_name_counter_wakeup; char *RunmodeGetActive(void); const char *RunModeGetMainMode(void); diff --git a/src/tm-threads.c b/src/tm-threads.c index b21357871e..4fbc54a2e2 100644 --- a/src/tm-threads.c +++ b/src/tm-threads.c @@ -1143,7 +1143,7 @@ TmEcode TmThreadSetupOptions(ThreadVars *tv) * * \retval the newly created TV instance, or NULL on error */ -ThreadVars *TmThreadCreate(char *name, char *inq_name, char *inqh_name, +ThreadVars *TmThreadCreate(const char *name, char *inq_name, char *inqh_name, char *outq_name, char *outqh_name, char *slots, void * (*fn_p)(void *), int mucond) { @@ -1266,7 +1266,7 @@ error: * * \retval the newly created TV instance, or NULL on error */ -ThreadVars *TmThreadCreatePacketHandler(char *name, char *inq_name, +ThreadVars *TmThreadCreatePacketHandler(const char *name, char *inq_name, char *inqh_name, char *outq_name, char *outqh_name, char *slots) { @@ -1296,7 +1296,7 @@ ThreadVars *TmThreadCreatePacketHandler(char *name, char *inq_name, * * \retval the newly created TV instance, or NULL on error */ -ThreadVars *TmThreadCreateMgmtThread(char *name, void *(fn_p)(void *), +ThreadVars *TmThreadCreateMgmtThread(const char *name, void *(fn_p)(void *), int mucond) { ThreadVars *tv = NULL; @@ -1324,7 +1324,7 @@ ThreadVars *TmThreadCreateMgmtThread(char *name, void *(fn_p)(void *), * * \retval the newly created TV instance, or NULL on error */ -ThreadVars *TmThreadCreateMgmtThreadByName(char *name, char *module, +ThreadVars *TmThreadCreateMgmtThreadByName(const char *name, char *module, int mucond) { ThreadVars *tv = NULL; @@ -1357,7 +1357,7 @@ ThreadVars *TmThreadCreateMgmtThreadByName(char *name, char *module, * * \retval the newly created TV instance, or NULL on error */ -ThreadVars *TmThreadCreateCmdThreadByName(char *name, char *module, +ThreadVars *TmThreadCreateCmdThreadByName(const char *name, char *module, int mucond) { ThreadVars *tv = NULL; diff --git a/src/tm-threads.h b/src/tm-threads.h index b39bf02f43..d92e1a9462 100644 --- a/src/tm-threads.h +++ b/src/tm-threads.h @@ -84,14 +84,14 @@ void TmSlotSetFuncAppend(ThreadVars *, TmModule *, void *); void TmSlotSetFuncAppendDelayed(ThreadVars *, TmModule *, void *, int delayed); TmSlot *TmSlotGetSlotForTM(int); -ThreadVars *TmThreadCreate(char *, char *, char *, char *, char *, char *, +ThreadVars *TmThreadCreate(const char *, char *, char *, char *, char *, char *, void *(fn_p)(void *), int); -ThreadVars *TmThreadCreatePacketHandler(char *, char *, char *, char *, char *, +ThreadVars *TmThreadCreatePacketHandler(const char *, char *, char *, char *, char *, char *); -ThreadVars *TmThreadCreateMgmtThread(char *name, void *(fn_p)(void *), int); -ThreadVars *TmThreadCreateMgmtThreadByName(char *name, char *module, +ThreadVars *TmThreadCreateMgmtThread(const char *name, void *(fn_p)(void *), int); +ThreadVars *TmThreadCreateMgmtThreadByName(const char *name, char *module, int mucond); -ThreadVars *TmThreadCreateCmdThreadByName(char *name, char *module, +ThreadVars *TmThreadCreateCmdThreadByName(const char *name, char *module, int mucond); TmEcode TmThreadSpawn(ThreadVars *); void TmThreadSetFlags(ThreadVars *, uint8_t); diff --git a/src/util-runmodes.c b/src/util-runmodes.c index 9920653a3f..03ec2ba293 100644 --- a/src/util-runmodes.c +++ b/src/util-runmodes.c @@ -102,8 +102,9 @@ char *RunmodeAutoFpCreatePickupQueuesString(int n) */ int RunModeSetLiveCaptureAutoFp(ConfigIfaceParserFunc ConfigParser, ConfigIfaceThreadsCountFunc ModThreadsCount, - char *recv_mod_name, - char *decode_mod_name, char *thread_name, + const char *recv_mod_name, + const char *decode_mod_name, + const char *thread_name, const char *live_dev) { char tname[TM_THREAD_NAME_MAX]; @@ -305,8 +306,8 @@ int RunModeSetLiveCaptureAutoFp(ConfigIfaceParserFunc ConfigParser, /** */ static int RunModeSetLiveCaptureWorkersForDevice(ConfigIfaceThreadsCountFunc ModThreadsCount, - char *recv_mod_name, - char *decode_mod_name, char *thread_name, + const char *recv_mod_name, + const char *decode_mod_name, const char *thread_name, const char *live_dev, void *aconf, unsigned char single_mode) { @@ -401,8 +402,8 @@ static int RunModeSetLiveCaptureWorkersForDevice(ConfigIfaceThreadsCountFunc Mod int RunModeSetLiveCaptureWorkers(ConfigIfaceParserFunc ConfigParser, ConfigIfaceThreadsCountFunc ModThreadsCount, - char *recv_mod_name, - char *decode_mod_name, char *thread_name, + const char *recv_mod_name, + const char *decode_mod_name, const char *thread_name, const char *live_dev) { int nlive = LiveGetDeviceCount(); @@ -436,8 +437,8 @@ int RunModeSetLiveCaptureWorkers(ConfigIfaceParserFunc ConfigParser, int RunModeSetLiveCaptureSingle(ConfigIfaceParserFunc ConfigParser, ConfigIfaceThreadsCountFunc ModThreadsCount, - char *recv_mod_name, - char *decode_mod_name, char *thread_name, + const char *recv_mod_name, + const char *decode_mod_name, const char *thread_name, const char *live_dev) { int nlive = LiveGetDeviceCount(); @@ -471,9 +472,9 @@ int RunModeSetLiveCaptureSingle(ConfigIfaceParserFunc ConfigParser, /** */ int RunModeSetIPSAutoFp(ConfigIPSParserFunc ConfigParser, - char *recv_mod_name, - char *verdict_mod_name, - char *decode_mod_name) + const char *recv_mod_name, + const char *verdict_mod_name, + const char *decode_mod_name) { SCEnter(); char tname[TM_THREAD_NAME_MAX]; @@ -628,9 +629,9 @@ int RunModeSetIPSAutoFp(ConfigIPSParserFunc ConfigParser, /** */ int RunModeSetIPSWorker(ConfigIPSParserFunc ConfigParser, - char *recv_mod_name, - char *verdict_mod_name, - char *decode_mod_name) + const char *recv_mod_name, + const char *verdict_mod_name, + const char *decode_mod_name) { char tname[TM_THREAD_NAME_MAX]; ThreadVars *tv = NULL; diff --git a/src/util-runmodes.h b/src/util-runmodes.h index 607895a4ab..02d1323749 100644 --- a/src/util-runmodes.h +++ b/src/util-runmodes.h @@ -32,37 +32,37 @@ typedef int (*ConfigIfaceThreadsCountFunc) (void *); int RunModeSetLiveCaptureAuto(ConfigIfaceParserFunc configparser, ConfigIfaceThreadsCountFunc ModThreadsCount, - char *recv_mod_name, - char *decode_mod_name, char *thread_name, + const char *recv_mod_name, + const char *decode_mod_name, const char *thread_name, const char *live_dev); int RunModeSetLiveCaptureAutoFp(ConfigIfaceParserFunc configparser, ConfigIfaceThreadsCountFunc ModThreadsCount, - char *recv_mod_name, - char *decode_mod_name, char *thread_name, + const char *recv_mod_name, + const char *decode_mod_name, const char *thread_name, const char *live_dev); int RunModeSetLiveCaptureSingle(ConfigIfaceParserFunc configparser, ConfigIfaceThreadsCountFunc ModThreadsCount, - char *recv_mod_name, - char *decode_mod_name, char *thread_name, + const char *recv_mod_name, + const char *decode_mod_name, const char *thread_name, const char *live_dev); int RunModeSetLiveCaptureWorkers(ConfigIfaceParserFunc configparser, ConfigIfaceThreadsCountFunc ModThreadsCount, - char *recv_mod_name, - char *decode_mod_name, char *thread_name, + const char *recv_mod_name, + const char *decode_mod_name, const char *thread_name, const char *live_dev); int RunModeSetIPSAutoFp(ConfigIPSParserFunc ConfigParser, - char *recv_mod_name, - char *verdict_mod_name, - char *decode_mod_name); + const char *recv_mod_name, + const char *verdict_mod_name, + const char *decode_mod_name); int RunModeSetIPSWorker(ConfigIPSParserFunc ConfigParser, - char *recv_mod_name, - char *verdict_mod_name, - char *decode_mod_name); + const char *recv_mod_name, + const char *verdict_mod_name, + const char *decode_mod_name); char *RunmodeAutoFpCreatePickupQueuesString(int n);