From 65bf06975c8efdde3b542f44403e2d253e88d91d Mon Sep 17 00:00:00 2001
From: Jason Ish <ish@unx.ca>
Date: Thu, 27 Oct 2016 11:19:05 -0600
Subject: [PATCH] dnp3: fix coverity checks; return value not checked

---
 src/app-layer-dnp3-objects.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/app-layer-dnp3-objects.c b/src/app-layer-dnp3-objects.c
index 275e646b2c..48d39b42b0 100644
--- a/src/app-layer-dnp3-objects.c
+++ b/src/app-layer-dnp3-objects.c
@@ -318,19 +318,25 @@ static int DNP3ReadPrefix(
 
     switch (prefix_len) {
         case sizeof(uint32_t):
-            DNP3ReadUint32(buf, len, out);
+            if (!DNP3ReadUint32(buf, len, out)) {
+                return 0;
+            }
             break;
         case sizeof(uint16_t): {
             /* Temp value for strict-aliasing. */
             uint16_t val = 0;
-            DNP3ReadUint16(buf, len, &val);
+            if (!DNP3ReadUint16(buf, len, &val)) {
+                return 0;
+            }
             *out = val;
             break;
         }
         case sizeof(uint8_t): {
             /* Temp value for strict-aliasing. */
             uint8_t val = 0;
-            DNP3ReadUint8(buf, len, &val);
+            if (!DNP3ReadUint8(buf, len, &val)) {
+                return 0;
+            }
             *out = val;
             break;
         }