app-layer: remove unused detect flags API

rust/src/applayer.rs

@@ -221,12 +221,6 @@ pub struct RustParser {
     /// Function to get the TX iterator
     pub get_tx_iterator:    Option<GetTxIteratorFn>,
 
-    // Function to set TX detect flags.
-    pub set_tx_detect_flags: Option<SetTxDetectFlagsFn>,
-
-    // Function to get TX detect flags.
-    pub get_tx_detect_flags: Option<GetTxDetectFlagsFn>,
-
     pub get_tx_data: GetTxDataFn,
 
     // Function to apply config to a TX. Optional. Normal (bidirectional)
@@ -281,8 +275,6 @@ pub type GetTxIteratorFn    = extern "C" fn (ipproto: u8, alproto: AppProto,
                                              max_tx_id: u64,
                                              istate: &mut u64)
                                              -> AppLayerGetTxIterTuple;
-pub type GetTxDetectFlagsFn = unsafe extern "C" fn(*mut c_void, u8) -> u64;
-pub type SetTxDetectFlagsFn = unsafe extern "C" fn(*mut c_void, u8, u64);
 pub type GetTxDataFn = unsafe extern "C" fn(*mut c_void) -> *mut AppLayerTxData;
 pub type ApplyTxConfigFn = unsafe extern "C" fn (*mut c_void, *mut c_void, c_int, AppLayerTxConfig);
 
@@ -318,12 +310,6 @@ extern {
     pub fn AppLayerParserStateIssetFlag(state: *mut c_void, flag: u8) -> c_int;
     pub fn AppLayerParserConfParserEnabled(ipproto: *const c_char, proto: *const c_char) -> c_int;
     pub fn AppLayerParserRegisterGetTxIterator(ipproto: u8, alproto: AppProto, fun: AppLayerGetTxIteratorFn);
-    pub fn AppLayerParserRegisterDetectFlagsFuncs(
-        ipproto: u8,
-        alproto: AppProto,
-        GetTxDetectFlats: GetTxDetectFlagsFn,
-        SetTxDetectFlags: SetTxDetectFlagsFn,
-    );
     pub fn AppLayerParserRegisterOptionFlags(ipproto: u8, alproto: AppProto, flags: u32);
 }
 

rust/src/applayertemplate/template.rs

@@ -516,8 +516,6 @@ pub unsafe extern "C" fn rs_template_register_parser() {
         localstorage_free: None,
         get_files: None,
         get_tx_iterator: Some(rs_template_state_get_tx_iterator),
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_tx_data: rs_template_get_tx_data,
         apply_tx_config: None,
     };

rust/src/dhcp/dhcp.rs

@@ -435,8 +435,6 @@ pub unsafe extern "C" fn rs_dhcp_register_parser() {
         localstorage_free  : None,
         get_files          : None,
         get_tx_iterator    : Some(rs_dhcp_state_get_tx_iterator),
-        set_tx_detect_flags: None,
-        get_tx_detect_flags: None,
         get_tx_data        : rs_dhcp_get_tx_data,
         apply_tx_config    : None,
     };

rust/src/dns/dns.rs

@@ -976,8 +976,6 @@ pub unsafe extern "C" fn rs_dns_udp_register_parser() {
         localstorage_free: None,
         get_files: None,
         get_tx_iterator: None,
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_de_state: rs_dns_state_get_tx_detect_state,
         set_de_state: rs_dns_state_set_tx_detect_state,
         get_tx_data: rs_dns_state_get_tx_data,
@@ -1021,8 +1019,6 @@ pub unsafe extern "C" fn rs_dns_tcp_register_parser() {
         localstorage_free: None,
         get_files: None,
         get_tx_iterator: None,
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_de_state: rs_dns_state_get_tx_detect_state,
         set_de_state: rs_dns_state_set_tx_detect_state,
         get_tx_data: rs_dns_state_get_tx_data,

rust/src/ikev2/ikev2.rs

@@ -710,8 +710,6 @@ pub unsafe extern "C" fn rs_register_ikev2_parser() {
         localstorage_free  : None,
         get_files          : None,
         get_tx_iterator    : None,
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_tx_data        : rs_ikev2_get_tx_data,
         apply_tx_config    : None,
     };

rust/src/krb/krb5.rs

@@ -656,8 +656,6 @@ pub unsafe extern "C" fn rs_register_krb5_parser() {
         localstorage_free  : None,
         get_files          : None,
         get_tx_iterator    : None,
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_tx_data        : rs_krb5_get_tx_data,
         apply_tx_config    : None,
     };

rust/src/ntp/ntp.rs

@@ -406,8 +406,6 @@ pub unsafe extern "C" fn rs_register_ntp_parser() {
         localstorage_free  : None,
         get_files          : None,
         get_tx_iterator    : None,
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_tx_data        : rs_ntp_get_tx_data,
         apply_tx_config    : None,
     };

rust/src/rdp/rdp.rs

@@ -532,8 +532,6 @@ pub unsafe extern "C" fn rs_rdp_register_parser() {
         localstorage_free: None,
         get_files: None,
         get_tx_iterator: None,
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_tx_data: rs_rdp_get_tx_data,
         apply_tx_config: None,
     };

rust/src/rfb/rfb.rs

@@ -698,8 +698,6 @@ pub unsafe extern "C" fn rs_rfb_register_parser() {
         localstorage_free: None,
         get_files: None,
         get_tx_iterator: Some(rs_rfb_state_get_tx_iterator),
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_tx_data: rs_rfb_get_tx_data,
         apply_tx_config: None,
     };

rust/src/sip/sip.rs

@@ -391,8 +391,6 @@ pub unsafe extern "C" fn rs_sip_register_parser() {
         localstorage_free: None,
         get_files: None,
         get_tx_iterator: None,
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_tx_data: rs_sip_get_tx_data,
         apply_tx_config: None,
     };

rust/src/snmp/snmp.rs

@@ -584,8 +584,6 @@ pub unsafe extern "C" fn rs_register_snmp_parser() {
         localstorage_free  : None,
         get_files          : None,
         get_tx_iterator    : None,
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_tx_data        : rs_snmp_get_tx_data,
         apply_tx_config    : None,
     };

rust/src/ssh/ssh.rs

@@ -558,8 +558,6 @@ pub unsafe extern "C" fn rs_ssh_register_parser() {
         localstorage_free: None,
         get_files: None,
         get_tx_iterator: None,
-        get_tx_detect_flags: None,
-        set_tx_detect_flags: None,
         get_tx_data: rs_ssh_get_tx_data,
         apply_tx_config: None,
     };

src/app-layer-register.h

@@ -66,9 +66,6 @@ typedef struct AppLayerParser {
             const AppProto alproto, void *alstate, uint64_t min_tx_id,
             uint64_t max_tx_id, AppLayerGetTxIterState *istate);
 
-    void (*SetTxDetectFlags)(void *, uint8_t, uint64_t);
-    uint64_t (*GetTxDetectFlags)(void *, uint8_t);
-
     AppLayerTxData *(*GetTxData)(void *tx);
     bool (*ApplyTxConfig)(void *state, void *tx, int mode, AppLayerTxConfig);
 } AppLayerParser;